mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-02-24 12:41:41 -05:00
01960c53c7
There exist many usages of `fuzzed_data_provider` where it is evaluated directly in the function call. Unfortunately, the order of evaluation of function arguments is unspecified. This means it can differ between compilers/version/optimization levels etc. But when the evaluation order changes, the same fuzzing input will produce different output, which is bad for coverage/reproducibility. This PR fixes all these cases where by moving multiple calls to `fuzzed_data_provider` out of the function arguments.
36 lines
1.2 KiB
C++
36 lines
1.2 KiB
C++
// Copyright (c) 2019-2022 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#include <chainparams.h>
|
|
#include <consensus/consensus.h>
|
|
#include <core_io.h>
|
|
#include <policy/policy.h>
|
|
#include <script/script.h>
|
|
#include <test/fuzz/FuzzedDataProvider.h>
|
|
#include <test/fuzz/fuzz.h>
|
|
#include <test/fuzz/util.h>
|
|
#include <univalue.h>
|
|
#include <util/chaintype.h>
|
|
|
|
void initialize_script_format()
|
|
{
|
|
SelectParams(ChainType::REGTEST);
|
|
}
|
|
|
|
FUZZ_TARGET(script_format, .init = initialize_script_format)
|
|
{
|
|
FuzzedDataProvider fuzzed_data_provider(buffer.data(), buffer.size());
|
|
const CScript script{ConsumeScript(fuzzed_data_provider)};
|
|
if (script.size() > MAX_STANDARD_TX_WEIGHT / WITNESS_SCALE_FACTOR) {
|
|
return;
|
|
}
|
|
|
|
(void)FormatScript(script);
|
|
(void)ScriptToAsmStr(script, /*fAttemptSighashDecode=*/fuzzed_data_provider.ConsumeBool());
|
|
|
|
UniValue o1(UniValue::VOBJ);
|
|
auto include_hex = fuzzed_data_provider.ConsumeBool();
|
|
auto include_address = fuzzed_data_provider.ConsumeBool();
|
|
ScriptToUniv(script, /*out=*/o1, include_hex, include_address);
|
|
}
|