fanquake 3740cdd125 Merge bitcoin/bitcoin#24091: wallet: Consolidate CInputCoin and COutput ... 049003fe68 coinselection: Remove COutput operators == and != (Andrew Chow) f6c39c6adb coinselection: Remove CInputCoin (Andrew Chow) 70f31f1a81 coinselection: Use COutput instead of CInputCoin (Andrew Chow) 14fbb57b79 coinselection: Add effective value and fees to COutput (Andrew Chow) f0821230b8 moveonly: move COutput to coinselection.h (Andrew Chow) 42e974e15c wallet: Remove CWallet and CWalletTx from COutput's constructor (Andrew Chow) 14d04d5ad1 wallet: Replace CWalletTx in COutput with COutPoint and CTxOut (Andrew Chow) 0ba4d1916e wallet: Provide input bytes to COutput (Andrew Chow) d51f27d3bb wallet: Store whether a COutput is from the wallet (Andrew Chow) b799814bbd wallet: Store tx time in COutput (Andrew Chow) 46022953ee wallet: Remove use_max_sig default value (Andrew Chow) 10379f007f scripted-diff: Rename COutput member variables (Andrew Chow) c7c64db41e wallet: cleanup COutput constructor (Andrew Chow) Pull request description: While working on coin selection code, it occurred to me that `CInputCoin` is really a subset of `COutput` and the conversion of a `COutput` to a `CInputCoin` does not appear to be all that useful. So this PR adds fields that are present in `CInputCoin` to `COutput` and replaces the usage of `CInputCoin` with `COutput`. `COutput` is also moved to coinselection.h. As part of this move, the usage of `CWalletTx` is removed from `COutput`. It is instead replaced by storing a `COutPoint` and the `CTxOut` rather than the entire `CWalletTx` as coin selection does not really need the full `CWalletTx`. The `CWalletTx` was only used for figuring out whether the transaction containing the output was from the current wallet, and for the transaction's time. These are now parameters to `COutput`'s constructor. ACKs for top commit: ryanofsky: Code review ACK 049003fe68, just adding comments and removing == operators since last review w0xlt: reACK 049003f Xekyo: reACK 049003fe68 Tree-SHA512: 048b4cd620a0415e1d9fe8597257ee4bc64656566e1d28a9bdd147d6d72dc87c3f34a3339fa9ab6acf42c388df7901fc4ee900ccaabc3de790ffad162b544c15		2022-03-24 20:46:43 +00:00
..
addresses.cpp	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
backup.cpp	refactor: replace boost::filesystem with std::filesystem	2022-02-03 18:35:52 +08:00
coins.cpp	wallet: Replace CWalletTx in COutput with COutPoint and CTxOut	2022-03-23 14:32:07 -04:00
encrypt.cpp	Replace "can not" with "cannot" in docs, user messages, and tests	2022-02-21 19:07:29 +01:00
signmessage.cpp	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
spend.cpp	doc: Use human-friendly DefaultHint for change_address/changeAddress in wallet RPC help	2022-02-28 23:28:22 +00:00
transactions.cpp	doc: include wtxid in TransactionDescriptionString	2022-02-09 21:15:24 -03:00
util.cpp	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
util.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
wallet.cpp	Merge bitcoin/bitcoin#23732: refactor: Remove gArgs from bdb.h and sqlite.h	2022-03-24 07:40:42 +01:00
wallet.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00