mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-05 10:17:30 -05:00

History

MacroFake 12455acca2 Merge bitcoin/bitcoin#24470 : Disallow more unsafe string->path conversions allowed by path append operators `f64aa9c411` Disallow more unsafe string->path conversions allowed by path append operators (Ryan Ofsky) Pull request description: Add more `fs::path` `operator/` and `operator+` overloads to prevent unsafe string->path conversions on Windows that would cause strings to be decoded according to the current Windows locale & code page instead of the correct string encoding. Update application code to deal with loss of implicit string->path conversions by calling `fs::u8path` or `fs::PathFromString` explicitly, or by just changing variable types from `std::string` to `fs::path` to avoid conversions altogether, or make them happen earlier. In all cases, there's no change in behavior either (1) because strings only contained ASCII characters and would be decoded the same regardless of what encoding was used, or (2) because of the 1:1 mapping between paths and strings using the `PathToString` and `PathFromString` functions. Motivation for this PR was just that I was experimenting with #24469 and noticed that operations like `fs::path / std::string` were allowed, and I thought it would be better not to allow them. ACKs for top commit: hebasto: ACK `f64aa9c411` Tree-SHA512: 944cce49ed51537ee7a35ea4ea7f5feaf0c8fff2fa67ee81ec5adebfd3dcbaf41b73eb35e49973d5f852620367f13506fd12a7a9b5ae3a7a0007414d5c9df50f		2022-05-03 10:39:42 +02:00
..
blockfilter.cpp	Require CBlockIndex::GetBlockPos() to hold mutex cs_main	2022-01-25 20:43:12 +01:00
blockfilter.h
chainstate.h	Disallow more unsafe string->path conversions allowed by path append operators	2022-04-21 12:01:00 -05:00
logging.cpp	scripted-diff: Bump copyright headers	2021-12-30 19:36:57 +02:00
logging.h	util, refactor: Add UNIQUE_NAME helper macro	2022-02-16 14:59:20 +02:00
mining.cpp	Add src/node/* code to node:: namespace	2022-01-06 22:14:16 -05:00
mining.h	Add src/node/* code to node:: namespace	2022-01-06 22:14:16 -05:00
net.cpp	scripted-diff: rename TxRelay members	2022-03-18 11:35:58 +00:00
net.h	net: add new method Sock::SetSockOpt() that wraps setsockopt()	2022-04-15 09:14:49 +02:00
README.md	doc: Add documentation for new test/lib	2019-11-06 11:56:53 -05:00
script.cpp	fuzz: [refactor] Use IsValidFlagCombination in signature_checker fuzz target	2021-03-30 10:42:45 +02:00
script.h	fuzz: [refactor] Use IsValidFlagCombination in signature_checker fuzz target	2021-03-30 10:42:45 +02:00
setup_common.cpp	validation: Prune UnloadBlockIndex and callees	2022-04-27 11:13:38 -04:00
setup_common.h	test: parse the command line arguments in unit tests	2022-01-11 11:53:30 +01:00
str.cpp
str.h	[test] move string helper functions into test library	2019-11-25 01:33:17 +01:00
transaction_utils.cpp	scripted-diff: Bump copyright headers	2020-04-16 13:33:09 -04:00
transaction_utils.h	scripted-diff: TxoutType C++11 scoped enum class	2020-06-21 06:41:55 -04:00
validation.cpp	Add coinstatsindex_unclean_shutdown test	2022-02-25 16:06:27 -05:00
validation.h	Add coinstatsindex_unclean_shutdown test	2022-02-25 16:06:27 -05:00
wallet.cpp	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
wallet.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00

README.md

Test library

This contains files for the test library, which is used by the test binaries (unit tests, benchmarks, fuzzers, gui tests).

Generally, the files in this folder should be well-separated modules. New code should be added to existing modules or (when in doubt) a new module should be created.

The utilities in here are compiled into a library, which does not hold any state. However, the main file setup_common defines the common test setup for all test binaries. The test binaries will handle the global state when they instantiate the BasicTestingSetup (or one of its derived classes).