Wladimir J. van der Laan 81c89e966e Merge #11923: Wallet : remove unused fNoncriticalErrors variable from CWalletDB::FindWalletTx ... ecf9b25 remove unused fNoncriticalErrors variable from CWalletDB::FindWalletTx (Pierre Rochard) Pull request description: The `CWalletDB::FindWalletTx` method was patterned after `CWalletDB::LoadWallet`, where `fNoncriticalErrors` is used when a tx check fails in `ReadKeyValue`. Since `FindWalletTx` is only used by methods which are zapping txs, it makes sense that `ReadKeyValue` is not called and the tx is not checked, so I think that deleting the unused `fNoncriticalErrors` boolean variable and its conditional statement is appropriate. Tree-SHA512: 0976eae97522719fdaeca1fb3f4a080561e46c06d0b8dc75e14262c6bc242998db3f7057183a230a1d7e4ac5fc348e9059f545b7d718ebbcdf6dcdfc63bcc286		2017-12-19 16:16:39 +01:00
..
test	tests: move pwalletMain to wallet test fixture	2017-11-18 14:16:38 +01:00
coincontrol.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
crypter.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
crypter.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
db.cpp	Merge #10574: Remove includes in .cpp files for things the corresponding .h file already included	2017-12-12 14:56:25 +01:00
db.h	Add -walletdir parameter to specify custom wallet dir	2017-11-18 00:50:58 +13:00
feebumper.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
feebumper.h	[wallet] Change feebumper from class to functions	2017-11-10 17:16:46 -05:00
fees.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
fees.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
init.cpp	Create walletdir if datadir doesn't exist and fix tests	2017-11-18 00:50:59 +13:00
init.h	[trivial] fixup comment for VerifyWallets()	2017-09-07 16:22:11 -07:00
rpcdump.cpp	Merge #10839: Don't use pass by reference to const for cheaply-copied types (bool, char, etc.)	2017-12-14 18:28:01 +01:00
rpcwallet.cpp	Merge #11178: Add iswitness parameter to decode- and fundrawtransaction RPCs	2017-12-19 09:55:11 +01:00
rpcwallet.h	[wallet] Add RegisterWalletRPC() function to wallet/init.cpp	2017-09-07 16:21:26 -07:00
wallet.cpp	Merge #10839: Don't use pass by reference to const for cheaply-copied types (bool, char, etc.)	2017-12-14 18:28:01 +01:00
wallet.h	Merge #10839: Don't use pass by reference to const for cheaply-copied types (bool, char, etc.)	2017-12-14 18:28:01 +01:00
walletdb.cpp	remove unused fNoncriticalErrors variable from CWalletDB::FindWalletTx	2017-12-17 11:01:23 -05:00
walletdb.h	Add -walletdir parameter to specify custom wallet dir	2017-11-18 00:50:58 +13:00
walletutil.cpp	Default walletdir is wallets/ if it exists	2017-11-18 00:50:59 +13:00
walletutil.h	Add -walletdir parameter to specify custom wallet dir	2017-11-18 00:50:58 +13:00