0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-09 10:43:19 -05:00
bitcoin-bitcoin-core/src/qt
Andrew Chow 3f8591d46b
Merge bitcoin/bitcoin#26661: wallet: Coin Selection, return accurate error messages
76dc547ee7 gui: create tx, launch error dialog if backend throws runtime_error (furszy)
f4d79477ff wallet: coin selection, add duplicated inputs checks (furszy)
0aa065b14e wallet: return accurate error messages from Coin Selection (furszy)
7e8340ab1a wallet: make SelectCoins flow return util::Result (furszy)
e5e147fe97 wallet: refactor eight consecutive 'AttemptSelection' calls into a loop (furszy)

Pull request description:

  Work decoupled from #25806, which cleanup and improves the Coin Selection flow further.

  Adding the capability to propagate specific error messages from the Coin Selection process to the user.
  Instead of always returning the general "Insufficient funds" message which is not always accurate to what happened internally.
  Letting us instruct the user how to proceed under certain circumstances.

  The following error messages were added:

  1) If the selection result exceeds the maximum transaction weight,
     we now will return:
  -> "The inputs size exceeds the maximum weight. Please try sending
  a smaller amount or manually consolidating your wallet's UTXOs".

  2) If the user pre-selected inputs and disallowed the automatic coin
     selection process (no other inputs are allowed), we now will
     return:
  -> "The preselected coins total amount does not cover the transaction
  target. Please allow other inputs to be automatically selected or include
  more coins manually".

  3) The double-counted preset inputs during Coin Selection error will now
  throw an "internal bug detected" message instead of crashing the node.

  The essence of this work comes from several comments:
  1. https://github.com/bitcoin/bitcoin/pull/26560#discussion_r1037395665
  2. https://github.com/bitcoin/bitcoin/pull/25729#discussion_r940619491
  3. https://github.com/bitcoin/bitcoin/pull/25269#pullrequestreview-1135240825
  4. https://github.com/bitcoin/bitcoin/issues/23144 (which is connected to #24845)

ACKs for top commit:
  ishaanam:
    crACK 76dc547ee7
  achow101:
    ACK 76dc547ee7
  aureleoules:
    ACK 76dc547ee7
  theStack:
    ACK 76dc547ee7 🌇

Tree-SHA512: 9de30792d7a5849cae77747aa978e70390b66ee9d082779a56088a024f82e725b0af050e6603aece0ac8229f6d73bc471ba97b4ab69dc7eddf419f5f56ae89a5
2023-01-03 18:53:36 -05:00
..
android qt: Drop no longer supported Android architecture 2022-06-04 11:42:26 +02:00
forms Fix Transaction Relay tooltip text in Peers details window 2022-11-16 20:54:54 -08:00
locale qt: Update translation source file for string freeze (round 2) 2022-09-14 15:03:07 +01:00
res scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
test scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
addressbookpage.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
addressbookpage.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
addresstablemodel.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
addresstablemodel.h
askpassphrasedialog.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
askpassphrasedialog.h
bantablemodel.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
bantablemodel.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
bitcoin.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
bitcoin.h scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
bitcoin.qrc
bitcoin_locale.qrc qt: Pre-branch translation updates for 23.x 2022-02-28 16:59:56 +01:00
bitcoinaddressvalidator.cpp
bitcoinaddressvalidator.h
bitcoinamountfield.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
bitcoinamountfield.h qt, refactor: Make BitcoinUnits::Unit a scoped enum 2022-02-22 13:50:30 -08:00
bitcoingui.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
bitcoingui.h scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
bitcoinstrings.cpp qt: Update translation source file for string freeze (round 2) 2022-09-14 15:03:07 +01:00
bitcoinunits.cpp qt, refactor: Remove default cases for scoped enum 2022-02-22 13:50:30 -08:00
bitcoinunits.h qt, refactor: Remove BitcoinUnits::valid function 2022-02-22 13:50:30 -08:00
clientmodel.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
clientmodel.h scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
coincontroldialog.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
coincontroldialog.h Add src/wallet/* code to wallet:: namespace 2022-01-06 22:14:16 -05:00
coincontroltreewidget.cpp
coincontroltreewidget.h
createwalletdialog.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
createwalletdialog.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
csvmodelwriter.cpp
csvmodelwriter.h
editaddressdialog.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
editaddressdialog.h
guiconstants.h scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
guiutil.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
guiutil.h scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
initexecutor.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
initexecutor.h qt: Keep InitExecutor in main gui thread 2021-09-27 13:05:40 +01:00
intro.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
intro.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
macdockiconhandler.h
macdockiconhandler.mm
macnotificationhandler.h
macnotificationhandler.mm
macos_appnap.h
macos_appnap.mm
main.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
Makefile
modaloverlay.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
modaloverlay.h scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
networkstyle.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
networkstyle.h
notificator.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
notificator.h scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
openuridialog.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
openuridialog.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
optionsdialog.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
optionsdialog.h scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
optionsmodel.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
optionsmodel.h scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
overviewpage.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
overviewpage.h scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
paymentserver.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
paymentserver.h
peertablemodel.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
peertablemodel.h scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
peertablesortproxy.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
peertablesortproxy.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
platformstyle.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
platformstyle.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
psbtoperationsdialog.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
psbtoperationsdialog.h
qrimagewidget.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
qrimagewidget.h
qvalidatedlineedit.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
qvalidatedlineedit.h scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
qvaluecombobox.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
qvaluecombobox.h
README.md
receivecoinsdialog.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
receivecoinsdialog.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
receiverequestdialog.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
receiverequestdialog.h
recentrequeststablemodel.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
recentrequeststablemodel.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
rpcconsole.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
rpcconsole.h scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
sendcoinsdialog.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
sendcoinsdialog.h scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
sendcoinsentry.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
sendcoinsentry.h scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
sendcoinsrecipient.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
signverifymessagedialog.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
signverifymessagedialog.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
splashscreen.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
splashscreen.h scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
trafficgraphwidget.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
trafficgraphwidget.h scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
transactiondesc.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
transactiondesc.h scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
transactiondescdialog.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
transactiondescdialog.h
transactionfilterproxy.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
transactionfilterproxy.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
transactionoverviewwidget.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
transactionoverviewwidget.h scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
transactionrecord.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
transactionrecord.h scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
transactiontablemodel.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
transactiontablemodel.h
transactionview.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
transactionview.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
utilitydialog.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
utilitydialog.h
walletcontroller.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
walletcontroller.h gui: Add Wallet Restore in the GUI 2022-06-27 10:00:18 -03:00
walletframe.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
walletframe.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
walletmodel.cpp Merge bitcoin/bitcoin#26661: wallet: Coin Selection, return accurate error messages 2023-01-03 18:53:36 -05:00
walletmodel.h scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
walletmodeltransaction.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
walletmodeltransaction.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
walletview.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
walletview.h qt, refactor: Make BitcoinUnits::Unit a scoped enum 2022-02-22 13:50:30 -08:00
winshutdownmonitor.cpp
winshutdownmonitor.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00

This directory contains the source code for the Bitcoin Core graphical user interface (GUI). It uses the Qt cross-platform framework.

The current precise version for Qt 5 is specified in qt.mk.

Compile and run

See build instructions: Unix, macOS, Windows, FreeBSD, NetBSD, OpenBSD

When following your systems build instructions, make sure to install the Qt dependencies.

To run:

./src/qt/bitcoin-qt

Files and Directories

forms/

  • A directory that contains Designer UI files. These files specify the characteristics of form elements in XML. Qt UI files can be edited with Qt Creator or using any text editor.

locale/

  • Contains translations. They are periodically updated and an effort is made to support as many languages as possible. The process of contributing translations is described in doc/translation_process.md.

res/

  • Contains graphical resources used to enhance the UI experience.

test/

  • Functional tests used to ensure proper functionality of the GUI. Significant changes to the GUI code normally require new or updated tests.

bitcoingui.(h/cpp)

  • Represents the main window of the Bitcoin UI.

*model.(h/cpp)

  • The model. When it has a corresponding controller, it generally inherits from QAbstractTableModel. Models that are used by controllers as helpers inherit from other Qt classes like QValidator.
  • ClientModel is used by the main application bitcoingui and several models like peertablemodel.

*page.(h/cpp)

  • A controller. :NAMEpage.cpp generally includes :NAMEmodel.h and forms/:NAME.page.ui with a similar :NAME.

*dialog.(h/cpp)

  • Various dialogs, e.g. to open a URL. Inherit from QDialog.

paymentserver.(h/cpp)

  • (Deprecated) Used to process BIP21 payment URI requests. Also handles URI-based application switching (e.g. when following a bitcoin:... link from a browser).

walletview.(h/cpp)

  • Represents the view to a single wallet.

Other .h/cpp files

  • UI elements like BitcoinAmountField, which inherit from QWidget.
  • bitcoinstrings.cpp: automatically generated
  • bitcoinunits.(h/cpp): BTC / mBTC / etc. handling
  • callback.h
  • guiconstants.h: UI colors, app name, etc.
  • guiutil.h: several helper functions
  • macdockiconhandler.(h/mm): macOS dock icon handler
  • macnotificationhandler.(h/mm): display notifications in macOS

Contribute

See CONTRIBUTING.md for general guidelines.

Note: Do not change local/bitcoin_en.ts. It is updated automatically.

Using Qt Creator as an IDE

Qt Creator is a powerful tool which packages a UI designer tool (Qt Designer) and a C++ IDE into one application. This is especially useful if you want to change the UI layout.

Download Qt Creator

On Unix and macOS, Qt Creator can be installed through your package manager. Alternatively, you can download a binary from the Qt Website.

Note: If installing from a binary grabbed from the Qt Website: During the installation process, uncheck everything except for Qt Creator.

macOS
brew install qt-creator
Ubuntu & Debian
sudo apt-get install qtcreator

Setup Qt Creator

  1. Make sure you've installed all dependencies specified in your systems build instructions
  2. Follow the compile instructions for your system, run ./configure with the --enable-debug flag
  3. Start Qt Creator. At the start page, do: New -> Import Project -> Import Existing Project
  4. Enter bitcoin-qt as the Project Name and enter the absolute path to src/qt as Location
  5. Check over the file selection, you may need to select the forms directory (necessary if you intend to edit *.ui files)
  6. Confirm the Summary page
  7. In the Projects tab, select Manage Kits...

macOS

  • Under Kits: select the default "Desktop" kit
  • Under Compilers: select "Clang (x86 64bit in /usr/bin)"
  • Under Debuggers: select "LLDB" as debugger (you might need to set the path to your LLDB installation)

Ubuntu & Debian

Note: Some of these options may already be set

  • Under Kits: select the default "Desktop" kit
  • Under Compilers: select "GCC (x86 64bit in /usr/bin)"
  • Under Debuggers: select "GDB" as debugger
  1. While in the Projects tab, ensure that you have the bitcoin-qt executable specified under Run
  • If the executable is not specified: click "Choose...", navigate to src/qt, and select bitcoin-qt
  1. You're all set! Start developing, building, and debugging the Bitcoin Core GUI