mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-02-05 10:17:30 -05:00
102867c587
Before this change `CNetAddr::ip` was a fixed-size array of 16 bytes, not being able to store larger addresses (e.g. TORv3) and encoded smaller ones as 16-byte IPv6 addresses. Change its type to `prevector`, so that it can hold larger addresses and do not disguise non-IPv6 addresses as IPv6. So the IPv4 address `1.2.3.4` is now encoded as `01020304` instead of `00000000000000000000FFFF01020304`. Rename `CNetAddr::ip` to `CNetAddr::m_addr` because it is not an "IP" or "IP address" (TOR addresses are not IP addresses). In order to preserve backward compatibility with serialization (where e.g. `1.2.3.4` is serialized as `00000000000000000000FFFF01020304`) introduce `CNetAddr` dedicated legacy serialize/unserialize methods. Adjust `CSubNet` accordingly. Still use `CSubNet::netmask[]` of fixed 16 bytes, but use the first 4 for IPv4 (not the last 4). Only allow subnetting for IPv4 and IPv6. Co-authored-by: Carl Dong <contact@carldong.me>
103 lines
3.8 KiB
C++
103 lines
3.8 KiB
C++
// Copyright (c) 2020 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#include <netaddress.h>
|
|
#include <test/fuzz/FuzzedDataProvider.h>
|
|
#include <test/fuzz/fuzz.h>
|
|
#include <test/fuzz/util.h>
|
|
|
|
#include <cassert>
|
|
#include <cstdint>
|
|
#include <netinet/in.h>
|
|
#include <vector>
|
|
|
|
void test_one_input(const std::vector<uint8_t>& buffer)
|
|
{
|
|
FuzzedDataProvider fuzzed_data_provider(buffer.data(), buffer.size());
|
|
|
|
const CNetAddr net_addr = ConsumeNetAddr(fuzzed_data_provider);
|
|
(void)net_addr.GetHash();
|
|
(void)net_addr.GetNetClass();
|
|
if (net_addr.GetNetwork() == Network::NET_IPV4) {
|
|
assert(net_addr.IsIPv4());
|
|
}
|
|
if (net_addr.GetNetwork() == Network::NET_IPV6) {
|
|
assert(net_addr.IsIPv6());
|
|
}
|
|
if (net_addr.GetNetwork() == Network::NET_ONION) {
|
|
assert(net_addr.IsTor());
|
|
}
|
|
if (net_addr.GetNetwork() == Network::NET_INTERNAL) {
|
|
assert(net_addr.IsInternal());
|
|
}
|
|
if (net_addr.GetNetwork() == Network::NET_UNROUTABLE) {
|
|
assert(!net_addr.IsRoutable());
|
|
}
|
|
(void)net_addr.IsBindAny();
|
|
if (net_addr.IsInternal()) {
|
|
assert(net_addr.GetNetwork() == Network::NET_INTERNAL);
|
|
}
|
|
if (net_addr.IsIPv4()) {
|
|
assert(net_addr.GetNetwork() == Network::NET_IPV4 || net_addr.GetNetwork() == Network::NET_UNROUTABLE);
|
|
}
|
|
if (net_addr.IsIPv6()) {
|
|
assert(net_addr.GetNetwork() == Network::NET_IPV6 || net_addr.GetNetwork() == Network::NET_UNROUTABLE);
|
|
}
|
|
(void)net_addr.IsLocal();
|
|
if (net_addr.IsRFC1918() || net_addr.IsRFC2544() || net_addr.IsRFC6598() || net_addr.IsRFC5737() || net_addr.IsRFC3927()) {
|
|
assert(net_addr.IsIPv4());
|
|
}
|
|
(void)net_addr.IsRFC2544();
|
|
if (net_addr.IsRFC3849() || net_addr.IsRFC3964() || net_addr.IsRFC4380() || net_addr.IsRFC4843() || net_addr.IsRFC7343() || net_addr.IsRFC4862() || net_addr.IsRFC6052() || net_addr.IsRFC6145()) {
|
|
assert(net_addr.IsIPv6());
|
|
}
|
|
(void)net_addr.IsRFC3927();
|
|
(void)net_addr.IsRFC3964();
|
|
if (net_addr.IsRFC4193()) {
|
|
assert(net_addr.GetNetwork() == Network::NET_ONION || net_addr.GetNetwork() == Network::NET_INTERNAL || net_addr.GetNetwork() == Network::NET_UNROUTABLE);
|
|
}
|
|
(void)net_addr.IsRFC4380();
|
|
(void)net_addr.IsRFC4843();
|
|
(void)net_addr.IsRFC4862();
|
|
(void)net_addr.IsRFC5737();
|
|
(void)net_addr.IsRFC6052();
|
|
(void)net_addr.IsRFC6145();
|
|
(void)net_addr.IsRFC6598();
|
|
(void)net_addr.IsRFC7343();
|
|
if (!net_addr.IsRoutable()) {
|
|
assert(net_addr.GetNetwork() == Network::NET_UNROUTABLE || net_addr.GetNetwork() == Network::NET_INTERNAL);
|
|
}
|
|
if (net_addr.IsTor()) {
|
|
assert(net_addr.GetNetwork() == Network::NET_ONION);
|
|
}
|
|
(void)net_addr.IsValid();
|
|
(void)net_addr.ToString();
|
|
(void)net_addr.ToStringIP();
|
|
|
|
const CSubNet sub_net{net_addr, fuzzed_data_provider.ConsumeIntegral<uint8_t>()};
|
|
(void)sub_net.IsValid();
|
|
(void)sub_net.ToString();
|
|
|
|
const CService service{net_addr, fuzzed_data_provider.ConsumeIntegral<uint16_t>()};
|
|
(void)service.GetKey();
|
|
(void)service.GetPort();
|
|
(void)service.ToString();
|
|
(void)service.ToStringIPPort();
|
|
(void)service.ToStringPort();
|
|
|
|
const CNetAddr other_net_addr = ConsumeNetAddr(fuzzed_data_provider);
|
|
(void)net_addr.GetReachabilityFrom(&other_net_addr);
|
|
(void)sub_net.Match(other_net_addr);
|
|
|
|
const CService other_service{net_addr, fuzzed_data_provider.ConsumeIntegral<uint16_t>()};
|
|
assert((service == other_service) != (service != other_service));
|
|
(void)(service < other_service);
|
|
|
|
const CSubNet sub_net_copy_1{net_addr, other_net_addr};
|
|
const CSubNet sub_net_copy_2{net_addr};
|
|
|
|
CNetAddr mutable_net_addr;
|
|
mutable_net_addr.SetIP(net_addr);
|
|
assert(net_addr == mutable_net_addr);
|
|
}
|