mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-02-04 10:07:27 -05:00
5b2d8661c9
703b1e612aClose minor startup race between main and scheduler threads (Larry Ruane) Pull request description: This is a low-priority bug fix. The scheduler thread runs `CheckForStaleTipAndEvictPeers()` every 45 seconds (EXTRA_PEER_CHECK_INTERVAL). If its first run happens before the active chain is set up (`CChain::SetTip()`), `bitcoind` will assert: ``` (...) 2021-07-28T22:16:49Z init message: Loading block index… bitcoind: validation.cpp:4968: CChainState& ChainstateManager::ActiveChainstate() const: Assertion `m_active_chainstate' failed. Aborted (core dumped) ``` I ran into this while using the debugger to investigate an unrelated problem. Single-stepping through threads with a debugger can cause the relative thread execution timing to be very different than usual. I don't think any automated tests are needed for this PR. I'll give reproduction steps in the next PR comment. ACKs for top commit: MarcoFalke: cr ACK703b1e612atryphe: tested ACK703b1e612a0xB10C: ACK703b1e612aglozow: code review ACK703b1e612a- it makes sense to me to start peerman's background tasks here, after `chainstate->LoadChainTip()` and `node.connman->Start()` have been called. Tree-SHA512: 9316ad768cba3b171f62e2eb400e3790af66c47d1886d7965edb38d9710fc8c8f8e4fb38232811c9346732ce311d39f740c5c2aaf5f6ca390ddc48c51a8d633b
81 lines
3.2 KiB
C++
81 lines
3.2 KiB
C++
// Copyright (c) 2009-2010 Satoshi Nakamoto
|
|
// Copyright (c) 2009-2020 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#ifndef BITCOIN_NET_PROCESSING_H
|
|
#define BITCOIN_NET_PROCESSING_H
|
|
|
|
#include <net.h>
|
|
#include <validationinterface.h>
|
|
|
|
class CAddrMan;
|
|
class CChainParams;
|
|
class CTxMemPool;
|
|
class ChainstateManager;
|
|
|
|
/** Default for -maxorphantx, maximum number of orphan transactions kept in memory */
|
|
static const unsigned int DEFAULT_MAX_ORPHAN_TRANSACTIONS = 100;
|
|
/** Default number of orphan+recently-replaced txn to keep around for block reconstruction */
|
|
static const unsigned int DEFAULT_BLOCK_RECONSTRUCTION_EXTRA_TXN = 100;
|
|
static const bool DEFAULT_PEERBLOOMFILTERS = false;
|
|
static const bool DEFAULT_PEERBLOCKFILTERS = false;
|
|
/** Threshold for marking a node to be discouraged, e.g. disconnected and added to the discouragement filter. */
|
|
static const int DISCOURAGEMENT_THRESHOLD{100};
|
|
|
|
struct CNodeStateStats {
|
|
int nSyncHeight = -1;
|
|
int nCommonHeight = -1;
|
|
int m_starting_height = -1;
|
|
std::chrono::microseconds m_ping_wait;
|
|
std::vector<int> vHeightInFlight;
|
|
uint64_t m_addr_processed = 0;
|
|
uint64_t m_addr_rate_limited = 0;
|
|
bool m_addr_relay_enabled{false};
|
|
};
|
|
|
|
class PeerManager : public CValidationInterface, public NetEventsInterface
|
|
{
|
|
public:
|
|
static std::unique_ptr<PeerManager> make(const CChainParams& chainparams, CConnman& connman, CAddrMan& addrman,
|
|
BanMan* banman, ChainstateManager& chainman,
|
|
CTxMemPool& pool, bool ignore_incoming_txs);
|
|
virtual ~PeerManager() { }
|
|
|
|
/** Begin running background tasks, should only be called once */
|
|
virtual void StartScheduledTasks(CScheduler& scheduler) = 0;
|
|
|
|
/** Get statistics from node state */
|
|
virtual bool GetNodeStateStats(NodeId nodeid, CNodeStateStats& stats) const = 0;
|
|
|
|
/** Whether this node ignores txs received over p2p. */
|
|
virtual bool IgnoresIncomingTxs() = 0;
|
|
|
|
/** Relay transaction to all peers. */
|
|
virtual void RelayTransaction(const uint256& txid, const uint256& wtxid) = 0;
|
|
|
|
/** Send ping message to all peers */
|
|
virtual void SendPings() = 0;
|
|
|
|
/** Set the best height */
|
|
virtual void SetBestHeight(int height) = 0;
|
|
|
|
/**
|
|
* Increment peer's misbehavior score. If the new value >= DISCOURAGEMENT_THRESHOLD, mark the node
|
|
* to be discouraged, meaning the peer might be disconnected and added to the discouragement filter.
|
|
* Public for unit testing.
|
|
*/
|
|
virtual void Misbehaving(const NodeId pnode, const int howmuch, const std::string& message) = 0;
|
|
|
|
/**
|
|
* Evict extra outbound peers. If we think our tip may be stale, connect to an extra outbound.
|
|
* Public for unit testing.
|
|
*/
|
|
virtual void CheckForStaleTipAndEvictPeers() = 0;
|
|
|
|
/** Process a single message from a peer. Public for fuzz testing */
|
|
virtual void ProcessMessage(CNode& pfrom, const std::string& msg_type, CDataStream& vRecv,
|
|
const std::chrono::microseconds time_received, const std::atomic<bool>& interruptMsgProc) = 0;
|
|
};
|
|
|
|
#endif // BITCOIN_NET_PROCESSING_H
|