Wladimir J. van der Laan 3c40bc6726 Merge #15921: validation: Tidy up ValidationState interface ... 3004d5a12d [validation] Remove fMissingInputs from AcceptToMemoryPool() (John Newbery) c428622a5b [validation] Remove unused first_invalid parameter from ProcessNewBlockHeaders() (John Newbery) 7204c6434b [validation] Remove useless ret parameter from Invalid() (John Newbery) 1a37de4b31 [validation] Remove error() calls from Invalid() calls (John Newbery) 067981e492 [validation] Tidy Up ValidationResult class (John Newbery) a27a2957ed [validation] Add CValidationState subclasses (John Newbery) Pull request description: Carries out some remaining tidy-ups remaining after PR 15141: - split ValidationState into TxValidationState and BlockValidationState (commit from ajtowns) - various minor code style tidy-ups to the ValidationState class - remove the useless `ret` parameter from `ValidationState::Invalid()` - remove the now unused `first_invalid` parameter from `ProcessNewBlockHeaders()` - remove the `fMissingInputs` parameter from `AcceptToMemoryPool()`, and deal with missing inputs the same way as other errors by using the `TxValidationState` object. Tip for reviewers (thanks ryanofsky!): The first commit ("[validation] Add CValidationState subclasses" ) is huge and can be easier to start reviewing if you revert the rote, mechanical changes: Substitute the commit hash of commit "[validation] Add CValidationState subclasses" for <CommitHash> in the commands below. ```sh git checkout <CommitHash> git grep -l ValidationState | xargs sed -i 's/BlockValidationState\|TxValidationState/CValidationState/g' git grep -l ValidationResult | xargs sed -i 's/BlockValidationResult\|TxValidationResult/ValidationInvalidReason/g' git grep -l MaybePunish | xargs sed -i 's/MaybePunishNode\(ForBlock\|ForTx\)/MaybePunishNode/g' git diff HEAD^ ``` After that it's possible to easily see the mechanical changes with: ```sh git log -p -n1 -U0 --word-diff-regex=. <CommitHash> ``` ACKs for top commit: laanwj: ACK 3004d5a12d amitiuttarwar: code review ACK 3004d5a12d. Also built & ran tests locally. fjahr: Code review ACK 3004d5a12d . Only nit style change and pure virtual destructor added since my last review. ryanofsky: Code review ACK 3004d5a12d. Just whitespace change and pure virtual destructor added since last review. Tree-SHA512: 511de1fb380a18bec1944ea82b513b6192df632ee08bb16344a2df3c40811a88f3872f04df24bc93a41643c96c48f376a04551840fd804a961490d6c702c3d36		2019-10-30 15:37:34 +01:00
..
descriptor_parse.cpp	tests: Add Parse(...) (descriptor) fuzzing harness	2019-10-23 11:10:10 +00:00
deserialize.cpp	tests: Skip unnecessary fuzzer initialisation. Hold ECCVerifyHandle only when needed.	2019-10-24 08:06:38 +00:00
eval_script.cpp	tests: Add EvalScript(...) fuzzing harness	2019-10-12 16:42:21 +00:00
fuzz.cpp	tests: Remove Cygwin WinMain workaround	2019-10-24 08:07:59 +00:00
fuzz.h	tests: Allow for using non-default fuzzing initialization	2019-10-23 11:10:10 +00:00
FuzzedDataProvider.h	tests: Add FuzzedDataProvider fuzzing helper from the Chromium project	2019-10-10 21:13:33 +00:00
parse_iso8601.cpp	tests: Add fuzzing harness for ISO-8601 related functions	2019-10-30 13:32:29 +00:00
script.cpp	tests: Add fuzzing harness for various CScript related functions	2019-10-25 08:28:13 +00:00
script_flags.cpp	tests: Pass fuzzing inputs as constant references	2019-10-07 08:48:35 +00:00
spanparsing.cpp	tests: Add fuzzing harness for descriptor Span-parsing helpers	2019-10-15 22:47:08 +00:00
transaction.cpp	[validation] Add CValidationState subclasses	2019-10-29 15:46:45 -04:00