mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-02-24 12:41:41 -05:00

Removes dependency on unsafe and deprecated uint256S. This makes parsing more strict, by returning an error when the input contains non-hex characters, or when it contains more than 64 hex digits. Also make feature_assumevalid.py more robust by using CBlock.hash which is guaranteed to be 64 characters long, as opposed to the variable-length hex(CBlock.sha256)
78 lines
3.1 KiB
C++
78 lines
3.1 KiB
C++
// Copyright (c) 2022 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#include <node/chainstatemanager_args.h>
|
|
|
|
#include <arith_uint256.h>
|
|
#include <common/args.h>
|
|
#include <common/system.h>
|
|
#include <logging.h>
|
|
#include <node/coins_view_args.h>
|
|
#include <node/database_args.h>
|
|
#include <tinyformat.h>
|
|
#include <uint256.h>
|
|
#include <util/result.h>
|
|
#include <util/strencodings.h>
|
|
#include <util/translation.h>
|
|
#include <validation.h>
|
|
|
|
#include <algorithm>
|
|
#include <chrono>
|
|
#include <string>
|
|
|
|
namespace node {
|
|
util::Result<void> ApplyArgsManOptions(const ArgsManager& args, ChainstateManager::Options& opts)
|
|
{
|
|
if (auto value{args.GetIntArg("-checkblockindex")}) {
|
|
// Interpret bare -checkblockindex argument as 1 instead of 0.
|
|
opts.check_block_index = args.GetArg("-checkblockindex")->empty() ? 1 : *value;
|
|
}
|
|
|
|
if (auto value{args.GetBoolArg("-checkpoints")}) opts.checkpoints_enabled = *value;
|
|
|
|
if (auto value{args.GetArg("-minimumchainwork")}) {
|
|
if (auto min_work{uint256::FromUserHex(*value)}) {
|
|
opts.minimum_chain_work = UintToArith256(*min_work);
|
|
} else {
|
|
return util::Error{strprintf(Untranslated("Invalid minimum work specified (%s), must be up to %d hex digits"), *value, uint256::size() * 2)};
|
|
}
|
|
}
|
|
|
|
if (auto value{args.GetArg("-assumevalid")}) {
|
|
if (auto block_hash{uint256::FromUserHex(*value)}) {
|
|
opts.assumed_valid_block = *block_hash;
|
|
} else {
|
|
return util::Error{strprintf(Untranslated("Invalid assumevalid block hash specified (%s), must be up to %d hex digits (or 0 to disable)"), *value, uint256::size() * 2)};
|
|
}
|
|
}
|
|
|
|
if (auto value{args.GetIntArg("-maxtipage")}) opts.max_tip_age = std::chrono::seconds{*value};
|
|
|
|
ReadDatabaseArgs(args, opts.block_tree_db);
|
|
ReadDatabaseArgs(args, opts.coins_db);
|
|
ReadCoinsViewArgs(args, opts.coins_view);
|
|
|
|
int script_threads = args.GetIntArg("-par", DEFAULT_SCRIPTCHECK_THREADS);
|
|
if (script_threads <= 0) {
|
|
// -par=0 means autodetect (number of cores - 1 script threads)
|
|
// -par=-n means "leave n cores free" (number of cores - n - 1 script threads)
|
|
script_threads += GetNumCores();
|
|
}
|
|
// Subtract 1 because the main thread counts towards the par threads.
|
|
opts.worker_threads_num = std::clamp(script_threads - 1, 0, MAX_SCRIPTCHECK_THREADS);
|
|
LogPrintf("Script verification uses %d additional threads\n", opts.worker_threads_num);
|
|
|
|
if (auto max_size = args.GetIntArg("-maxsigcachesize")) {
|
|
// 1. When supplied with a max_size of 0, both the signature cache and
|
|
// script execution cache create the minimum possible cache (2
|
|
// elements). Therefore, we can use 0 as a floor here.
|
|
// 2. Multiply first, divide after to avoid integer truncation.
|
|
size_t clamped_size_each = std::max<int64_t>(*max_size, 0) * (1 << 20) / 2;
|
|
opts.script_execution_cache_bytes = clamped_size_each;
|
|
opts.signature_cache_bytes = clamped_size_each;
|
|
}
|
|
|
|
return {};
|
|
}
|
|
} // namespace node
|