0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-11 11:16:09 -05:00
bitcoin-bitcoin-core/src/test
Ava Chow 4ad5c71adb
Merge bitcoin/bitcoin#28051: Get rid of shutdown.cpp/shutdown.h, use SignalInterrupt directly
6db04be102 Get rid of shutdown.cpp/shutdown.h, use SignalInterrupt directly (Ryan Ofsky)
213542b625 refactor: Add InitContext function to initialize NodeContext with global pointers (Ryan Ofsky)
feeb7b816a refactor: Remove calls to StartShutdown from KernelNotifications (Ryan Ofsky)
6824eecaf1 refactor: Remove call to StartShutdown from stop RPC (Ryan Ofsky)
1d92d89edb util: Get rid of uncaught exceptions thrown by SignalInterrupt class (Ryan Ofsky)
ba93966368 refactor: Remove call to ShutdownRequested from IndexWaitSynced (Ryan Ofsky)
42e5829d97 refactor: Remove call to ShutdownRequested from HTTPRequest (Ryan Ofsky)
73133c36aa refactor: Add NodeContext::shutdown member (Ryan Ofsky)
f4a8bd6e2f refactor: Remove call to StartShutdown from qt (Ryan Ofsky)
f0c73c1336 refactor: Remove call to ShutdownRequested from rpc/mining (Ryan Ofsky)
263b23f008 refactor: Remove call to ShutdownRequested from chainstate init (Ryan Ofsky)

Pull request description:

  This change drops `shutdown.h` and `shutdown.cpp` files, replacing them with a `NodeContext::shutdown` member which is used to trigger shutdowns directly. This gets rid of an unnecessary layer of indirection, and allows getting rid of the `kernel::g_context` global.

  Additionally, this PR tries to improve error handling of `SignalInterrupt` code by marking relevant methods `[[nodiscard]]` to avoid the possibility of uncaught exceptions mentioned https://github.com/bitcoin/bitcoin/pull/27861#discussion_r1255496707.

  Behavior is changing In a few cases which are noted in individual commit messages. Particularly: GUI code more consistently interrupts RPCs when it is shutting down, shutdown state no longer persists between unit tests, the stop RPC now returns an RPC error if requesting shutdown fails instead of aborting, and other failed shutdown calls now log errors instead of aborting.

  This PR is a net reduction in lines of code, but in some cases the explicit error handling and lack of global shutdown functions do make it more verbose. The verbosity can be seen as good thing if it discourages more code from directly triggering shutdowns, and instead encourages code to return errors or send notifications that could be translated into shutdowns. Probably a number of existing shutdown calls could just be replaced by better error handling.

ACKs for top commit:
  achow101:
    ACK 6db04be102
  TheCharlatan:
    Re-ACK 6db04be102
  maflcko:
    ACK 6db04be102 👗
  stickies-v:
    re-ACK 6db04be102

Tree-SHA512: 7a34cb69085f37e813c43bdaded1a0cbf6c53bd95fdde96f0cb45346127fc934604c43bccd3328231ca2f1faf712a7418d047ceabd22ef2dca3c32ebb659e634
2023-12-14 15:14:00 -05:00
..
data
fuzz Merge bitcoin/bitcoin#28051: Get rid of shutdown.cpp/shutdown.h, use SignalInterrupt directly 2023-12-14 15:14:00 -05:00
util Merge bitcoin/bitcoin#28051: Get rid of shutdown.cpp/shutdown.h, use SignalInterrupt directly 2023-12-14 15:14:00 -05:00
addrman_tests.cpp Merge bitcoin/bitcoin#27581: net: Continuous ASMap health check 2023-12-06 11:22:42 -05:00
allocator_tests.cpp refactor: Move system from util to common library 2023-05-20 12:08:13 +02:00
amount_tests.cpp
argsman_tests.cpp refactor: Remove unused C-style casts 2023-07-24 15:32:00 +02:00
arith_uint256_tests.cpp refactor: Remove unused and fragile string interface from arith_uint256 2023-11-21 17:37:25 +01:00
banman_tests.cpp
base32_tests.cpp
base58_tests.cpp Remove unused raw-pointer read helper from univalue 2023-07-27 14:24:52 +02:00
base64_tests.cpp
bech32_tests.cpp
bip32_tests.cpp tidy: modernize-use-emplace 2023-10-12 11:27:19 +02:00
bip324_tests.cpp crypto: Spanify EllSwiftPubKey constructor 2023-09-07 08:53:45 -04:00
blockchain_tests.cpp refactor: rpc: Pass CBlockIndex by reference instead of pointer 2023-12-07 12:05:21 +01:00
blockencodings_tests.cpp scripted-diff: Use DataStream in most places 2023-11-28 12:42:37 +01:00
blockfilter_index_tests.cpp refactor: Remove call to ShutdownRequested from IndexWaitSynced 2023-12-04 15:39:15 -04:00
blockfilter_tests.cpp Remove unused includes from blockfilter.h 2023-08-17 18:28:15 +02:00
blockmanager_tests.cpp refactor: Remove calls to StartShutdown from KernelNotifications 2023-12-04 15:39:15 -04:00
bloom_tests.cpp Remove unused CDataStream 2023-11-30 11:27:54 +01:00
bswap_tests.cpp
checkqueue_tests.cpp refactor: Make CCheckQueue constructor start worker threads 2023-10-03 10:52:15 +01:00
coins_tests.cpp Use Txid in COutpoint 2023-11-21 13:15:44 +00:00
coinstatsindex_tests.cpp refactor: Remove call to ShutdownRequested from IndexWaitSynced 2023-12-04 15:39:15 -04:00
compilerbug_tests.cpp
compress_tests.cpp Clean up things that include script/standard.h 2023-08-14 17:38:27 -04:00
crypto_tests.cpp tests: miscellaneous hex / std::byte improvements 2023-08-17 15:31:56 -04:00
cuckoocache_tests.cpp Move random test util code from setup_common to random 2023-02-06 12:26:04 -08:00
dbwrapper_tests.cpp Merge bitcoin/bitcoin#26940: test: create random and coins utils, add amount helper, dedupe add_coin 2023-02-17 17:28:14 -05:00
denialofservice_tests.cpp scripted-diff: Rename connection limit variables 2023-10-03 13:55:57 -04:00
descriptor_tests.cpp test: Unit test for inferring scripts with hybrid and uncompressed keys 2023-10-09 14:07:37 -04:00
disconnected_transactions.cpp [test] DisconnectedBlockTransactions::DynamicMemoryUsage 2023-10-19 16:14:36 +01:00
flatfile_tests.cpp serialize: Drop useless version param from GetSerializeSize() 2023-11-16 11:14:13 +10:00
fs_tests.cpp Remove DirIsWritable, GetUniquePath 2023-10-26 10:32:56 +02:00
getarg_tests.cpp scripted-diff: move settings to common namespace 2023-05-30 17:26:51 +02:00
hash_tests.cpp Drop CHashWriter 2023-11-14 08:45:32 +10:00
headers_sync_chainwork_tests.cpp tidy: modernize-use-emplace 2023-10-12 11:27:19 +02:00
httpserver_tests.cpp bugfix: rest: avoid segfault for invalid URI 2023-04-17 10:13:34 -03:00
i2p_tests.cpp Merge bitcoin/bitcoin#28695: net: Sanity check private keys received from SAM proxy 2023-10-30 14:44:40 +01:00
interfaces_tests.cpp Rename script/standard.{cpp/h} to script/solver.{cpp/h} 2023-08-14 17:39:49 -04:00
key_io_tests.cpp Remove unused raw-pointer read helper from univalue 2023-07-27 14:24:52 +02:00
key_tests.cpp Unit test for ellswift creation/decoding roundtrip 2023-06-23 14:22:39 -04:00
logging_tests.cpp refactor: fix unterminated LogPrintf()s 2023-08-03 17:52:24 +01:00
main.cpp
Makefile
mempool_tests.cpp [refactor] remove access to mapTx.find in mempool_tests.cpp 2023-11-10 16:44:35 +01:00
merkle_tests.cpp Move random test util code from setup_common to random 2023-02-06 12:26:04 -08:00
merkleblock_tests.cpp refactor: Use Txid in CMerkleBlock 2023-11-28 17:49:41 +01:00
miner_tests.cpp Use Txid in COutpoint 2023-11-21 13:15:44 +00:00
miniminer_tests.cpp Use Txid in COutpoint 2023-11-21 13:15:44 +00:00
miniscript_tests.cpp serialize: Drop useless version param from GetSerializeSize() 2023-11-16 11:14:13 +10:00
minisketch_tests.cpp Move random test util code from setup_common to random 2023-02-06 12:26:04 -08:00
multisig_tests.cpp Merge bitcoin/bitcoin#24149: Signing support for Miniscript Descriptors 2023-02-16 10:01:33 +00:00
net_peer_connection_tests.cpp Rename version.h to node/protocol_version.h 2023-11-30 11:28:31 +01:00
net_peer_eviction_tests.cpp
net_tests.cpp Rename version.h to node/protocol_version.h 2023-11-30 11:28:31 +01:00
netbase_tests.cpp Remove unused version.h include 2023-11-30 11:28:19 +01:00
orphanage_tests.cpp fuzz: Improve fuzzing stability for txorphan harness 2023-12-08 13:14:46 +00:00
pmt_tests.cpp Remove unused version.h include 2023-11-30 11:28:19 +01:00
policy_fee_tests.cpp [net processing] FeeFilterRounder doesn't own a FastRandomContext 2023-10-04 13:16:52 +01:00
policyestimator_tests.cpp tx fees, policy: CBlockPolicyEstimator update from CValidationInterface notifications 2023-11-22 11:48:21 +01:00
pool_tests.cpp pool: change memusage_test to use int64_t, add allocation check 2023-11-20 17:10:34 +01:00
pow_tests.cpp refactor: Remove unused and fragile string interface from arith_uint256 2023-11-21 17:37:25 +01:00
prevector_tests.cpp Move random test util code from setup_common to random 2023-02-06 12:26:04 -08:00
raii_event_tests.cpp
random_tests.cpp test: move remaining random test util code from setup_common to random 2023-06-14 08:28:33 -06:00
rbf_tests.cpp tidy: modernize-use-emplace 2023-10-12 11:27:19 +02:00
README.md
rest_tests.cpp
result_tests.cpp
reverselock_tests.cpp
rpc_tests.cpp tidy: modernize-use-emplace 2023-10-12 11:27:19 +02:00
sanity_tests.cpp
scheduler_tests.cpp clang-tidy: Add performance-inefficient-vector-operation check 2023-03-26 20:17:55 +01:00
script_p2sh_tests.cpp clang-tidy: Add performance-inefficient-vector-operation check 2023-03-26 20:17:55 +01:00
script_parse_tests.cpp
script_segwit_tests.cpp
script_standard_tests.cpp Add PubKeyDestination for P2PK scripts 2023-09-12 12:14:31 -04:00
script_tests.cpp refactor: SpanReader without nVersion 2023-11-28 12:42:07 +01:00
scriptnum10.h
scriptnum_tests.cpp
serfloat_tests.cpp Move random test util code from setup_common to random 2023-02-06 12:26:04 -08:00
serialize_tests.cpp serialize: Drop useless version param from GetSerializeSize() 2023-11-16 11:14:13 +10:00
settings_tests.cpp tidy: modernize-use-emplace 2023-10-12 11:27:19 +02:00
sighash_tests.cpp Remove unused version.h include 2023-11-30 11:28:19 +01:00
sigopcount_tests.cpp tidy: modernize-use-emplace 2023-10-12 11:27:19 +02:00
skiplist_tests.cpp Move random test util code from setup_common to random 2023-02-06 12:26:04 -08:00
sock_tests.cpp test: improve sock_tests/move_assignment 2023-08-28 14:32:17 +02:00
span_tests.cpp span: Make Span template deduction guides work in SFINAE context 2023-10-20 10:30:16 -04:00
streams_tests.cpp refactor: SpanReader without nVersion 2023-11-28 12:42:07 +01:00
sync_tests.cpp
system_tests.cpp test: Fix test by checking the actual exception instance 2023-12-03 16:04:20 +00:00
timedata_tests.cpp
torcontrol_tests.cpp
transaction_tests.cpp Merge bitcoin/bitcoin#26762: bugfix: Make CCheckQueue RAII-styled (attempt 2) 2023-11-30 14:28:46 -05:00
translation_tests.cpp Extend bilingual_str support for tinyformat 2023-02-28 12:04:47 -05:00
txindex_tests.cpp refactor: Remove call to ShutdownRequested from IndexWaitSynced 2023-12-04 15:39:15 -04:00
txpackage_tests.cpp Use Txid in COutpoint 2023-11-21 13:15:44 +00:00
txreconciliation_tests.cpp
txrequest_tests.cpp clang-tidy: Add performance-inefficient-vector-operation check 2023-03-26 20:17:55 +01:00
txvalidation_tests.cpp Clean up things that include script/standard.h 2023-08-14 17:38:27 -04:00
txvalidationcache_tests.cpp [refactor] Add missing includes for next commit 2023-09-12 22:51:42 +02:00
uint256_tests.cpp Merge bitcoin/bitcoin#28924: refactor: Remove unused and fragile string interface from arith_uint256 2023-12-07 16:02:05 +00:00
util_tests.cpp Merge bitcoin/bitcoin#28075: util: Remove DirIsWritable, GetUniquePath 2023-12-13 10:06:16 +00:00
util_threadnames_tests.cpp tidy: modernize-use-emplace 2023-10-12 11:27:19 +02:00
validation_block_tests.cpp [refactor] remove access to mapTx in validation_block_tests 2023-11-10 16:44:47 +01:00
validation_chainstate_tests.cpp Tighten requirements for adding elements to setBlockIndexCandidates 2023-07-24 16:23:38 -04:00
validation_chainstatemanager_tests.cpp refactor: Remove calls to StartShutdown from KernelNotifications 2023-12-04 15:39:15 -04:00
validation_flush_tests.cpp Use PoolAllocator for CCoinsMap 2023-03-23 19:38:38 +01:00
validation_tests.cpp coinstats: Fix hash_serialized2 calculation 2023-10-20 22:53:05 +02:00
validationinterface_tests.cpp validation: pass ChainstateRole for validationinterface calls 2023-09-30 06:38:47 -04:00
versionbits_tests.cpp doc: fix typos 2023-11-07 10:21:51 +09:00
xoroshiro128plusplus_tests.cpp

Unit tests

The sources in this directory are unit test cases. Boost includes a unit testing framework, and since Bitcoin Core already uses Boost, it makes sense to simply use this framework rather than require developers to configure some other framework (we want as few impediments to creating unit tests as possible).

The build system is set up to compile an executable called test_bitcoin that runs all of the unit tests. The main source file for the test library is found in util/setup_common.cpp.

Compiling/running unit tests

Unit tests will be automatically compiled if dependencies were met in ./configure and tests weren't explicitly disabled.

After configuring, they can be run with make check.

To run the unit tests manually, launch src/test/test_bitcoin. To recompile after a test file was modified, run make and then run the test again. If you modify a non-test file, use make -C src/test to recompile only what's needed to run the unit tests.

To add more unit tests, add BOOST_AUTO_TEST_CASE functions to the existing .cpp files in the test/ directory or add new .cpp files that implement new BOOST_AUTO_TEST_SUITE sections.

To run the GUI unit tests manually, launch src/qt/test/test_bitcoin-qt

To add more GUI unit tests, add them to the src/qt/test/ directory and the src/qt/test/test_main.cpp file.

Running individual tests

test_bitcoin accepts the command line arguments from the boost framework. For example, to run just the getarg_tests suite of tests:

test_bitcoin --log_level=all --run_test=getarg_tests

log_level controls the verbosity of the test framework, which logs when a test case is entered, for example. test_bitcoin also accepts the command line arguments accepted by bitcoind. Use -- to separate both types of arguments:

test_bitcoin --log_level=all --run_test=getarg_tests -- -printtoconsole=1

The -printtoconsole=1 after the two dashes redirects the debug log, which would normally go to a file in the test datadir (BasicTestingSetup::m_path_root), to the standard terminal output.

... or to run just the doubledash test:

test_bitcoin --run_test=getarg_tests/doubledash

Run test_bitcoin --help for the full list.

Adding test cases

To add a new unit test file to our test suite you need to add the file to src/Makefile.test.include. The pattern is to create one test file for each class or source file for which you want to create unit tests. The file naming convention is <source_filename>_tests.cpp and such files should wrap their tests in a test suite called <source_filename>_tests. For an example of this pattern, see uint256_tests.cpp.

Logging and debugging in unit tests

make check will write to a log file foo_tests.cpp.log and display this file on failure. For running individual tests verbosely, refer to the section above.

To write to logs from unit tests you need to use specific message methods provided by Boost. The simplest is BOOST_TEST_MESSAGE.

For debugging you can launch the test_bitcoin executable with gdb or lldb and start debugging, just like you would with any other program:

gdb src/test/test_bitcoin

Segmentation faults

If you hit a segmentation fault during a test run, you can diagnose where the fault is happening by running gdb ./src/test/test_bitcoin and then using the bt command within gdb.

Another tool that can be used to resolve segmentation faults is valgrind.

If for whatever reason you want to produce a core dump file for this fault, you can do that as well. By default, the boost test runner will intercept system errors and not produce a core file. To bypass this, add --catch_system_errors=no to the test_bitcoin arguments and ensure that your ulimits are set properly (e.g. ulimit -c unlimited).

Running the tests and hitting a segmentation fault should now produce a file called core (on Linux platforms, the file name will likely depend on the contents of /proc/sys/kernel/core_pattern).

You can then explore the core dump using

gdb src/test/test_bitcoin core

(gbd) bt  # produce a backtrace for where a segfault occurred