0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-04 10:07:27 -05:00
bitcoin-bitcoin-core/src/util
Wladimir J. van der Laan 463eab5e14
Merge #17285: doc: Bip70 removal follow-up
3ed8e3d079 doc: Remove explicit network name references (Fabian Jahr)
d6e493f0c2 wallet: Remove left-over BIP70 comment (Fabian Jahr)

Pull request description:

  A small follow-up to #17165 which removed BIP70 support.

  1. Removes one leftover mention of BIP70 in a comment.
  2. Removes BIP70 reference in comments on network/chain name strings. These can be removed as they are not really helpful and also incorrect: BIP70 only defines "main" and "test" but not "regtest". If/When signet gets merged we will add another name to the list that is not defined in BIP70. Mostly there is also an exhaustive list of the options included in the comment anyway.

  If we would like to keep an identifier for this naming scheme, I would suggest switching to something more generic, like 'short chain name'. Happy to implement that if that is preferred. Alternatively, we could add a reference to `CBaseChainParams`. That would also mean we don't have to change these lines again for signet.

ACKs for top commit:
  MarcoFalke:
    ACK 3ed8e3d079

Tree-SHA512: 9a7c0b9cacbb67bd31a089ffdc6f1ebc7f336493e2c8266eb697da34dce2b505a431d5639a3e4fc34f9287361343e861b55dc2662e0a1d2095cc1046db77d6ee
2019-11-02 14:47:41 +01:00
..
bip32.cpp Add WriteHDKeypath function and move *HDKeypath to util/bip32.{h,cpp} 2019-02-14 14:00:28 -05:00
bip32.h Add WriteHDKeypath function and move *HDKeypath to util/bip32.{h,cpp} 2019-02-14 14:00:28 -05:00
bytevectorhash.cpp blockfilter: Use unordered_set instead of set in blockfilter. 2018-11-05 09:30:56 -08:00
bytevectorhash.h blockfilter: Use unordered_set instead of set in blockfilter. 2018-11-05 09:30:56 -08:00
check.h util: Add CHECK_NONFATAL and use it in src/rpc 2019-10-18 17:19:36 -04:00
error.cpp util: Make util/error bilingual_str (refactor) 2019-08-28 15:52:26 -04:00
error.h util: Make util/error bilingual_str (refactor) 2019-08-28 15:52:26 -04:00
fees.cpp [wallet] abort when attempting to fund a transaction above maxtxfee 2019-06-28 22:44:38 -04:00
fees.h [build] Add several util units 2019-04-09 17:53:08 -04:00
macros.h refactor: consolidate PASTE macros 2019-09-25 10:56:00 -04:00
memory.h scripted-diff: Move util files to separate directory. 2018-11-04 22:46:07 -08:00
moneystr.cpp Remove unused includes 2019-10-15 22:56:43 +00:00
moneystr.h Remove unused includes 2019-10-15 22:56:43 +00:00
rbf.cpp [build] Add several util units 2019-04-09 17:53:08 -04:00
rbf.h [build] Add several util units 2019-04-09 17:53:08 -04:00
spanparsing.cpp Abstract out some of the descriptor Span-parsing helpers 2019-09-18 12:12:13 -07:00
spanparsing.h Add documenting comments to spanparsing.h 2019-09-18 12:25:55 -07:00
strencodings.cpp Fix occurences of c_str() used with size() to data() 2019-10-28 13:41:45 +01:00
strencodings.h util: refactor upper/lowercase functions 2019-08-08 11:35:14 +09:00
string.cpp util: Add Join helper to join a list of strings 2019-08-20 16:51:41 -04:00
string.h Remove unused includes 2019-10-15 22:56:43 +00:00
system.cpp refactor: Remove redundant c_str() calls in formatting 2019-10-28 13:31:33 +01:00
system.h doc: Remove explicit network name references 2019-11-01 12:06:35 +01:00
threadnames.cpp Remove unused includes 2019-10-15 22:56:43 +00:00
threadnames.h Don't rename main thread at process level 2019-10-03 06:58:47 +02:00
time.cpp Rename DecodeDumpTime to ParseISO8601DateTime and move to time.cpp 2019-10-27 01:00:05 +03:00
time.h Rename DecodeDumpTime to ParseISO8601DateTime and move to time.cpp 2019-10-27 01:00:05 +03:00
translation.h MOVEONLY: Move key handling code out of wallet to keyman file 2019-10-25 19:20:24 -04:00
url.cpp [build] Add several util units 2019-04-09 17:53:08 -04:00
url.h [build] Add several util units 2019-04-09 17:53:08 -04:00
validation.cpp [validation] Add CValidationState subclasses 2019-10-29 15:46:45 -04:00
validation.h [validation] Add CValidationState subclasses 2019-10-29 15:46:45 -04:00
vector.h Add some general std::vector utility functions 2019-10-16 08:56:57 -07:00