glozow 4de84557d6 Merge bitcoin/bitcoin#29356: test: make v2transport arg in addconnection mandatory and few cleanups ... e7fd70f4b6 [test] make v2transport arg in addconnection mandatory and few cleanups (stratospher) Pull request description: - make `v2transport` argument in `addconnection` regression-testing only RPC mandatory. https://github.com/bitcoin/bitcoin/pull/24748#discussion_r1470738750 - previously it was an optional arg with default `false` value. - only place this RPC is used is in the [functional tests](11b436a66a/test/functional/test_framework/test_node.py (L742)) where we always pass the appropriate `v2transport` option to the RPC anyways. (and that too just for python dummy peer(`P2PInterface`) and bitcoind(`TestNode`) interactions) - rename `v2_handshake()` to `_on_data_v2_handshake()` https://github.com/bitcoin/bitcoin/pull/24748#discussion_r1466958424 - more compact return statement in `wait_for_reconnect()` https://github.com/bitcoin/bitcoin/pull/24748#discussion_r1466979708 - assertion to check that empty version packets are received from `TestNode`. ACKs for top commit: glozow: ACK e7fd70f4b6 theStack: Code-review ACK e7fd70f4b6 mzumsande: Code Review ACK e7fd70f4b6 Tree-SHA512: e66e29baccd91e1e4398b91f7d45c5fc7c2841d77d8a6178734586017bf2be63496721649da91848dec71da605ee31664352407d5bb896e624cc693767c61a1f		2024-02-06 11:02:36 +00:00
..
crypto	[test/crypto] Add FSChaCha20Poly1305 AEAD python implementation	2023-09-29 17:50:38 +05:30
__init__.py	Rename rpc-tests directory to functional	2017-03-20 10:40:31 -04:00
address.py	refactor: move address_to_scriptpubkey to address.py	2023-03-28 16:54:28 +01:00
authproxy.py	test: Rename EncodeDecimal to serialization_fallback	2023-06-29 19:51:43 +02:00
bdb.py	scripted-diff: Bump copyright headers	2021-11-10 11:10:24 +01:00
bip340_test_vectors.csv	tests: add BIP340 Schnorr signature support to test framework	2020-10-12 17:18:47 -07:00
blockfilter.py	Merge bitcoin/bitcoin#28605: Fix typos	2023-11-16 10:35:49 +00:00
blocktools.py	refactor: use address_to_scriptpubkey to retrieve addresses scriptpubkey	2023-03-28 16:58:16 +01:00
coverage.py	test: fix PEP484 no implicit optional argument types errors	2023-06-29 16:14:07 -06:00
descriptors.py	Output a descriptor in createmultisig and addmultisigaddress	2020-01-30 23:55:36 -05:00
key.py	Merge bitcoin/bitcoin#28374: test: python cryptography required for BIP 324 functional tests	2023-11-07 16:48:57 -05:00
messages.py	Merge bitcoin/bitcoin#29067: test: Treat msg_version.relay as unsigned, Remove struct packing in messages.py	2024-01-30 12:00:47 +00:00
netutil.py	test: add coverage to feature_addrman.py	2023-10-01 22:43:49 -05:00
p2p.py	Merge bitcoin/bitcoin#29356: test: make v2transport arg in addconnection mandatory and few cleanups	2024-02-06 11:02:36 +00:00
psbt.py	test: PSBT: eliminate magic numbers for global unsigned tx key (0)	2023-03-04 12:43:38 +01:00
script.py	Merge bitcoin/bitcoin#28725: test: refactor: use built-in collection types for type hints (Python 3.9 / PEP 585)	2023-11-17 11:19:17 +00:00
script_util.py	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
segwit_addr.py	Use Bech32m encoding for v1+ segwit addresses	2021-03-16 10:48:36 -07:00
socks5.py	test: add keep_alive option to socks5 proxy in test_framework	2023-07-10 10:07:45 -04:00
test_framework.py	test: Use blocks_path where possible	2024-01-17 16:48:47 +01:00
test_node.py	net: enable v2transport by default	2024-01-29 22:48:01 -05:00
test_shell.py	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
util.py	test: detect OS consistently using platform.system()	2023-12-08 18:16:24 +01:00
v2_p2p.py	[test] make v2transport arg in addconnection mandatory and few cleanups	2024-01-31 22:37:54 +05:30
wallet.py	test: use built-in collection types for type hints (Python 3.9 / PEP 585)	2023-10-25 01:10:21 +02:00
wallet_util.py	test: Add Wallet Unlock Context Manager	2023-10-10 18:12:31 +03:00