0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-09 10:43:19 -05:00
bitcoin-bitcoin-core/src/test
fanquake 4e1a38c6df
Merge bitcoin/bitcoin#28196: BIP324 connection support
db9888feec net: detect wrong-network V1 talking to V2Transport (Pieter Wuille)
91e1ef8684 test: add unit tests for V2Transport (Pieter Wuille)
297c888997 net: make V2Transport preallocate receive buffer space (Pieter Wuille)
3ffa5fb49e net: make V2Transport send uniformly random number garbage bytes (Pieter Wuille)
0be752d9f8 net: add short message encoding/decoding support to V2Transport (Pieter Wuille)
8da8642062 net: make V2Transport auto-detect incoming V1 and fall back to it (Pieter Wuille)
13a7f01557 net: add V2Transport class with subset of BIP324 functionality (Pieter Wuille)
dc2d7eb810 crypto: Spanify EllSwiftPubKey constructor (Pieter Wuille)
5f4b2c6d79 net: remove unused Transport::SetReceiveVersion (Pieter Wuille)
c3fad1f29d net: add have_next_message argument to Transport::GetBytesToSend() (Pieter Wuille)

Pull request description:

  This is part of #27634.

  This implements the BIP324 v2 transport (which implements all of what the BIP calls transport layer *and* application layer), though in a non-exposed way. It is tested through an extensive fuzz test, which verifies that v2 transports can talk to v2 transports, and v1 transports can talk to v2 transports, and a unit test that exercises a number of unusual scenarios. The transport is functionally complete, including:
  * Autodetection of incoming V1 connections.
  * Garbage, both sending and receiving.
  * Short message type IDs, both sending and receiving.
  * Ignore packets (receiving only, but tested in a unit test).
  * Session IDs are visible in `getpeerinfo` output (for manual comparison).

  Things that are not included, left for future PRs, are:
  * Actually using the v2 transport for connections.
  * Support for the `NODE_P2P_V2` service flag.
  * Retrying downgrade to V1 when attempted outbound V2 connections immediately fail.
  * P2P functional and unit tests

ACKs for top commit:
  naumenkogs:
    ACK db9888feec
  theStack:
    re-ACK db9888feec
  mzumsande:
    Code Review ACK db9888feec

Tree-SHA512: 8906ac1e733a99e1f31c9111055611f706d80bbfc2edf6a07fa6e47b21bb65baacd1ff17993cbbf588063b2f5ad30b3af674a50c7bc8e8ebf4671483a21bbfeb
2023-09-08 10:24:03 +01:00
..
data scripted-diff: Regenerate key_io data deterministically 2022-04-06 17:08:07 +02:00
fuzz Merge bitcoin/bitcoin#28196: BIP324 connection support 2023-09-08 10:24:03 +01:00
util net: add have_next_message argument to Transport::GetBytesToSend() 2023-09-07 08:53:45 -04:00
addrman_tests.cpp Use serialization parameters for CAddress serialization 2023-09-05 10:13:25 +02:00
allocator_tests.cpp refactor: Move system from util to common library 2023-05-20 12:08:13 +02:00
amount_tests.cpp
argsman_tests.cpp refactor: Remove unused C-style casts 2023-07-24 15:32:00 +02:00
arith_uint256_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
banman_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
base32_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
base58_tests.cpp Remove unused raw-pointer read helper from univalue 2023-07-27 14:24:52 +02:00
base64_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
bech32_tests.cpp
bip32_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
bip324_tests.cpp crypto: Spanify EllSwiftPubKey constructor 2023-09-07 08:53:45 -04:00
blockchain_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
blockencodings_tests.cpp Move random test util code from setup_common to random 2023-02-06 12:26:04 -08:00
blockfilter_index_tests.cpp Clean up things that include script/standard.h 2023-08-14 17:38:27 -04:00
blockfilter_tests.cpp Remove unused includes from blockfilter.h 2023-08-17 18:28:15 +02:00
blockmanager_tests.cpp Rename script/standard.{cpp/h} to script/solver.{cpp/h} 2023-08-14 17:39:49 -04:00
bloom_tests.cpp refactor: Move system from util to common library 2023-05-20 12:08:13 +02:00
bswap_tests.cpp
checkqueue_tests.cpp refactor: Replace string chain name constants with ChainTypes 2023-05-09 15:49:14 +02:00
coins_tests.cpp Clean up things that include script/standard.h 2023-08-14 17:38:27 -04:00
coinstatsindex_tests.cpp Move block-storage-related logic to ChainstateManager 2023-07-21 10:09:44 -04:00
compilerbug_tests.cpp
compress_tests.cpp Clean up things that include script/standard.h 2023-08-14 17:38:27 -04:00
crypto_tests.cpp tests: miscellaneous hex / std::byte improvements 2023-08-17 15:31:56 -04:00
cuckoocache_tests.cpp Move random test util code from setup_common to random 2023-02-06 12:26:04 -08:00
dbwrapper_tests.cpp Merge bitcoin/bitcoin#26940: test: create random and coins utils, add amount helper, dedupe add_coin 2023-02-17 17:28:14 -05:00
denialofservice_tests.cpp net: add have_next_message argument to Transport::GetBytesToSend() 2023-09-07 08:53:45 -04:00
descriptor_tests.cpp wallet: accurately account for the size of the witness stack 2023-08-25 12:40:12 +02:00
flatfile_tests.cpp move-only: Extract common/args and common/config.cpp from util/system 2023-04-19 10:48:30 +02:00
fs_tests.cpp refactor: Move fs.* to util/fs.* 2023-03-23 12:55:18 +01:00
getarg_tests.cpp scripted-diff: move settings to common namespace 2023-05-30 17:26:51 +02:00
hash_tests.cpp refactor: use Span for SipHash::Write 2023-07-17 13:27:46 +02:00
headers_sync_chainwork_tests.cpp Add unit test for HeadersSyncState 2022-08-29 08:10:35 -04:00
httpserver_tests.cpp bugfix: rest: avoid segfault for invalid URI 2023-04-17 10:13:34 -03:00
i2p_tests.cpp move-only: Extract common/args and common/config.cpp from util/system 2023-04-19 10:48:30 +02:00
interfaces_tests.cpp Rename script/standard.{cpp/h} to script/solver.{cpp/h} 2023-08-14 17:39:49 -04:00
key_io_tests.cpp Remove unused raw-pointer read helper from univalue 2023-07-27 14:24:52 +02:00
key_tests.cpp Unit test for ellswift creation/decoding roundtrip 2023-06-23 14:22:39 -04:00
logging_tests.cpp refactor: fix unterminated LogPrintf()s 2023-08-03 17:52:24 +01:00
main.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
Makefile
mempool_tests.cpp refactor: Move system from util to common library 2023-05-20 12:08:13 +02:00
merkle_tests.cpp Move random test util code from setup_common to random 2023-02-06 12:26:04 -08:00
merkleblock_tests.cpp
miner_tests.cpp Clean up things that include script/standard.h 2023-08-14 17:38:27 -04:00
miniminer_tests.cpp Remove unused includes from txmempool.h 2023-08-17 16:25:31 +02:00
miniscript_tests.cpp miniscript: introduce a helper to get the maximum witness size 2023-08-25 11:56:10 +02:00
minisketch_tests.cpp Move random test util code from setup_common to random 2023-02-06 12:26:04 -08:00
multisig_tests.cpp Merge bitcoin/bitcoin#24149: Signing support for Miniscript Descriptors 2023-02-16 10:01:33 +00:00
net_peer_eviction_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
net_tests.cpp net: detect wrong-network V1 talking to V2Transport 2023-09-07 09:04:55 -04:00
netbase_tests.cpp Use serialization parameters for CAddress serialization 2023-09-05 10:13:25 +02:00
orphanage_tests.cpp Clean up things that include script/standard.h 2023-08-14 17:38:27 -04:00
pmt_tests.cpp Move random test util code from setup_common to random 2023-02-06 12:26:04 -08:00
policy_fee_tests.cpp
policyestimator_tests.cpp clang-tidy: Add performance-inefficient-vector-operation check 2023-03-26 20:17:55 +01:00
pool_tests.cpp Calculate memory usage correctly for unordered_maps that use PoolAllocator 2023-03-23 19:38:38 +01:00
pow_tests.cpp refactor: Replace string chain name constants with ChainTypes 2023-05-09 15:49:14 +02:00
prevector_tests.cpp Move random test util code from setup_common to random 2023-02-06 12:26:04 -08:00
raii_event_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
random_tests.cpp test: move remaining random test util code from setup_common to random 2023-06-14 08:28:33 -06:00
rbf_tests.cpp refactor: Move system from util to common library 2023-05-20 12:08:13 +02:00
README.md
rest_tests.cpp Handle query string when parsing data format 2022-03-10 12:01:53 +01:00
result_tests.cpp refactor: Replace BResult with util::Result 2022-08-03 07:33:01 -04:00
reverselock_tests.cpp
rpc_tests.cpp Remove unused raw-pointer read helper from univalue 2023-07-27 14:24:52 +02:00
sanity_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
scheduler_tests.cpp clang-tidy: Add performance-inefficient-vector-operation check 2023-03-26 20:17:55 +01:00
script_p2sh_tests.cpp clang-tidy: Add performance-inefficient-vector-operation check 2023-03-26 20:17:55 +01:00
script_parse_tests.cpp
script_segwit_tests.cpp
script_standard_tests.cpp Rename script/standard.{cpp/h} to script/solver.{cpp/h} 2023-08-14 17:39:49 -04:00
script_tests.cpp Rename script/standard.{cpp/h} to script/solver.{cpp/h} 2023-08-14 17:39:49 -04:00
scriptnum10.h
scriptnum_tests.cpp
serfloat_tests.cpp Move random test util code from setup_common to random 2023-02-06 12:26:04 -08:00
serialize_tests.cpp test: add tests that exercise WithParams() 2023-09-05 10:13:41 +02:00
settings_tests.cpp scripted-diff: Following the C++ Standard rules for identifiers with _. 2023-06-20 10:23:08 +02:00
sighash_tests.cpp Remove unused raw-pointer read helper from univalue 2023-07-27 14:24:52 +02:00
sigopcount_tests.cpp Rename script/standard.{cpp/h} to script/solver.{cpp/h} 2023-08-14 17:39:49 -04:00
skiplist_tests.cpp Move random test util code from setup_common to random 2023-02-06 12:26:04 -08:00
sock_tests.cpp refactor: Move system from util to common library 2023-05-20 12:08:13 +02:00
streams_tests.cpp Remove unused legacy CHashVerifier 2023-09-05 10:13:50 +02:00
sync_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
system_tests.cpp refactor: remove in-code warning suppression 2023-06-29 14:41:33 +01:00
timedata_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
torcontrol_tests.cpp
transaction_tests.cpp Rename script/standard.{cpp/h} to script/solver.{cpp/h} 2023-08-14 17:39:49 -04:00
translation_tests.cpp Extend bilingual_str support for tinyformat 2023-02-28 12:04:47 -05:00
txindex_tests.cpp Clean up things that include script/standard.h 2023-08-14 17:38:27 -04:00
txpackage_tests.cpp Clean up things that include script/standard.h 2023-08-14 17:38:27 -04:00
txreconciliation_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
txrequest_tests.cpp clang-tidy: Add performance-inefficient-vector-operation check 2023-03-26 20:17:55 +01:00
txvalidation_tests.cpp Clean up things that include script/standard.h 2023-08-14 17:38:27 -04:00
txvalidationcache_tests.cpp Clean up things that include script/standard.h 2023-08-14 17:38:27 -04:00
uint256_tests.cpp Use DataStream where possible 2023-01-26 10:44:05 +01:00
util_tests.cpp refactor: Move system from util to common library 2023-05-20 12:08:13 +02:00
util_threadnames_tests.cpp clang-tidy: Add performance-inefficient-vector-operation check 2023-03-26 20:17:55 +01:00
validation_block_tests.cpp Clean up things that include script/standard.h 2023-08-14 17:38:27 -04:00
validation_chainstate_tests.cpp Tighten requirements for adding elements to setBlockIndexCandidates 2023-07-24 16:23:38 -04:00
validation_chainstatemanager_tests.cpp assumeutxo cleanup: Move IsInitialBlockDownload & NotifyHeaderTip to ChainstateManager 2023-08-18 12:52:30 -04:00
validation_flush_tests.cpp Use PoolAllocator for CCoinsMap 2023-03-23 19:38:38 +01:00
validation_tests.cpp refactor: Replace string chain name constants with ChainTypes 2023-05-09 15:49:14 +02:00
validationinterface_tests.cpp test: Avoid intermittent issues due to async events in validationinterface_tests 2023-07-25 17:32:16 +02:00
versionbits_tests.cpp refactor: Replace string chain name constants with ChainTypes 2023-05-09 15:49:14 +02:00
xoroshiro128plusplus_tests.cpp Add xoroshiro128++ PRNG 2023-01-30 18:12:21 -05:00

Unit tests

The sources in this directory are unit test cases. Boost includes a unit testing framework, and since Bitcoin Core already uses Boost, it makes sense to simply use this framework rather than require developers to configure some other framework (we want as few impediments to creating unit tests as possible).

The build system is set up to compile an executable called test_bitcoin that runs all of the unit tests. The main source file for the test library is found in util/setup_common.cpp.

Compiling/running unit tests

Unit tests will be automatically compiled if dependencies were met in ./configure and tests weren't explicitly disabled.

After configuring, they can be run with make check.

To run the unit tests manually, launch src/test/test_bitcoin. To recompile after a test file was modified, run make and then run the test again. If you modify a non-test file, use make -C src/test to recompile only what's needed to run the unit tests.

To add more unit tests, add BOOST_AUTO_TEST_CASE functions to the existing .cpp files in the test/ directory or add new .cpp files that implement new BOOST_AUTO_TEST_SUITE sections.

To run the GUI unit tests manually, launch src/qt/test/test_bitcoin-qt

To add more GUI unit tests, add them to the src/qt/test/ directory and the src/qt/test/test_main.cpp file.

Running individual tests

test_bitcoin accepts the command line arguments from the boost framework. For example, to run just the getarg_tests suite of tests:

test_bitcoin --log_level=all --run_test=getarg_tests

log_level controls the verbosity of the test framework, which logs when a test case is entered, for example. test_bitcoin also accepts the command line arguments accepted by bitcoind. Use -- to separate both types of arguments:

test_bitcoin --log_level=all --run_test=getarg_tests -- -printtoconsole=1

The -printtoconsole=1 after the two dashes redirects the debug log, which would normally go to a file in the test datadir (BasicTestingSetup::m_path_root), to the standard terminal output.

... or to run just the doubledash test:

test_bitcoin --run_test=getarg_tests/doubledash

Run test_bitcoin --help for the full list.

Adding test cases

To add a new unit test file to our test suite you need to add the file to src/Makefile.test.include. The pattern is to create one test file for each class or source file for which you want to create unit tests. The file naming convention is <source_filename>_tests.cpp and such files should wrap their tests in a test suite called <source_filename>_tests. For an example of this pattern, see uint256_tests.cpp.

Logging and debugging in unit tests

make check will write to a log file foo_tests.cpp.log and display this file on failure. For running individual tests verbosely, refer to the section above.

To write to logs from unit tests you need to use specific message methods provided by Boost. The simplest is BOOST_TEST_MESSAGE.

For debugging you can launch the test_bitcoin executable with gdb or lldb and start debugging, just like you would with any other program:

gdb src/test/test_bitcoin

Segmentation faults

If you hit a segmentation fault during a test run, you can diagnose where the fault is happening by running gdb ./src/test/test_bitcoin and then using the bt command within gdb.

Another tool that can be used to resolve segmentation faults is valgrind.

If for whatever reason you want to produce a core dump file for this fault, you can do that as well. By default, the boost test runner will intercept system errors and not produce a core file. To bypass this, add --catch_system_errors=no to the test_bitcoin arguments and ensure that your ulimits are set properly (e.g. ulimit -c unlimited).

Running the tests and hitting a segmentation fault should now produce a file called core (on Linux platforms, the file name will likely depend on the contents of /proc/sys/kernel/core_pattern).

You can then explore the core dump using

gdb src/test/test_bitcoin core

(gbd) bt  # produce a backtrace for where a segfault occurred