foster/bitcoin-bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-10 10:52:31 -05:00
Code Issues Activity
bitcoin-bitcoin-core/src/qt/forms
History
MarcoFalke 53bbbe5a20
Merge bitcoin-core/gui#171: Use layout manager for Create Wallet dialog 
d4feb6812a qt: Use layout manager for Create Wallet dialog (Hennadii Stepanov)

Pull request description:

  On master (e75f91eae3) not using layout manager causes problems with resizing:

  ![Screenshot from 2021-01-01 13-03-13](https://user-images.githubusercontent.com/32963518/103437728-ce1d4580-4c33-11eb-8915-1e9482775653.png)
  ![Screenshot from 2021-01-01 13-03-26](https://user-images.githubusercontent.com/32963518/103437730-d6758080-4c33-11eb-9e0f-87d0dd487fcb.png)

  Also text labels are not resized properly on some window managers (https://github.com/bitcoin/bitcoin/issues/20777), or if their lengths are changed (after translation).

  This PR introduces a standard layout manager for the "Create Wallet" dialog that fixes all layout issues (actually, the `createwalletdialog.ui` has been re-written from scratch):

  ![Screenshot from 2021-01-01 13-10-03](https://user-images.githubusercontent.com/32963518/103437822-d0cc6a80-4c34-11eb-84fd-fcb10a16d9ef.png)
  ![Screenshot from 2021-01-06 23-50-36](https://user-images.githubusercontent.com/32963518/103823090-0b416780-507a-11eb-89dd-3f48a358e168.png)

  Additional visual changes:
  - advanced options are grouped in `QGroupBox` (https://github.com/bitcoin-core/gui/pull/96#issuecomment-726337165)
  - enabled the [size grip](https://doc.qt.io/qt-5/qsizegrip.html#details)

  Fix https://github.com/bitcoin/bitcoin/issues/20777

ACKs for top commit:
  jarolrod:
    ACK d4feb6812a
  Sjors:
    re-tACK d4feb6812a
  promag:
    Tested ACK d4feb6812a on macos.

Tree-SHA512: 4c055962e49f88624900b880b33a866976d224628784593428b712d2e94563d77ddefddea3397134d20e72f738a8cf9aa885c1272fd9ffc90213c104435fb9f4
2021-01-21 18:51:17 +01:00
..
addressbookpage.ui [qt] Add support to search the address book 2018-01-03 16:15:15 +00:00
askpassphrasedialog.ui gui: fix passphrase labels/tooltip in createwalletdialog/askpassphrasedialog 2019-09-09 10:57:38 +02:00
coincontroldialog.ui gui: move coin control OK to the right 2019-05-28 11:16:39 -04:00
createwalletdialog.ui qt: Use layout manager for Create Wallet dialog 2021-01-06 23:35:24 +02:00
debugwindow.ui gui: improve connection type tooltip 2021-01-09 13:49:51 +01:00
editaddressdialog.ui qt: refactor: Use absolute include paths in .ui files 2017-11-16 08:23:02 +13:00
helpmessagedialog.ui Unify package name to as few places as possible without major changes 2015-12-14 02:11:10 +00:00
intro.ui [gui] intro: add prune preference 2019-08-24 22:41:32 +02:00
modaloverlay.ui gui: Shortcut to close ModalOverlay 2020-01-24 20:27:49 +01:00
openuridialog.ui gui: Move static placeholder texts to forms 2019-12-09 11:12:20 +01:00
optionsdialog.ui gui: Add NAT-PMP network option 2021-01-07 18:07:10 +02:00
overviewpage.ui qt: Add privacy feature to Overview page 2020-05-27 11:55:44 +03:00
psbtoperationsdialog.ui [gui] PSBT Operations Dialog (sign & broadcast) 2020-06-19 02:20:04 -07:00
receivecoinsdialog.ui qt: Make "Create new receiving address" default unconditionally 2020-07-21 21:24:28 +03:00
receiverequestdialog.ui qt: Overhaul ReceiveRequestDialog 2020-05-05 05:56:50 +03:00
sendcoinsdialog.ui [gui] send: show watch-only balance in send screen 2019-11-26 11:43:53 +01:00
sendcoinsentry.ui qt: Normalize placeholder to avoid using "address book" in sendcoinsentry 2019-12-09 12:28:55 +01:00
signverifymessagedialog.ui gui: Move static placeholder texts to forms 2019-12-09 11:12:20 +01:00
transactiondescdialog.ui qt: Add transaction hash to details window title 2016-04-26 16:05:10 +02:00