fanquake 3b88c85025 Merge bitcoin/bitcoin#26612: refactor: RPC: pass named argument value as string_view ... 545ff924ab refactor: use string_view for RPC named argument values (stickies-v) 7727603e44 refactor: reduce unnecessary complexity in ParseNonRFCJSONValue (stickies-v) 1d02e59901 test: add cases to JSON parsing (stickies-v) Pull request description: Inspired by MarcoFalke's [comment](https://github.com/bitcoin/bitcoin/pull/26506#discussion_r1036149426). Main purpose of this PR is to minimize copying (potentially large) RPC named arguments when calling `.substr()` by using `std::string_view` instead of `std::string`. Furthermore, cleans up the code by removing unnecessary complexity in `ParseNonRFCJSONValue()` (done first to avoid refactoring required to concatenate `string` and `string_view`), updates some naming and adds a few test cases. Should not introduce any behaviour change. ## Questions - ~Was there actually any merit to `ParseNonRFCJSONValue()` surrounding the value with brackets and then parsing it as an array? I don't see it, and the new approach doesn't fail any tests. Still a bit suspicious about it though.~ - Cleared up by https://github.com/bitcoin/bitcoin/pull/26506#pullrequestreview-1211984059 - If there are no objections to 7727603e44, I think we should follow up with a PR to rename `ParseNonRFCJSONValue()` to a local `Parse()` helper function (that throws if invalid), remove it from `client.h` and merge the test coverage we currently have on `ParseNonRFCJSONValue()` with the coverage we have on `UniValue::read()`. ACKs for top commit: ryanofsky: Code review ACK 545ff924ab MarcoFalke: review ACK 545ff924ab 📻 Tree-SHA512: b1c89fb010ac9c3054b023cac1acbba2a539a09cf39a7baffbd7f7571ee268d5a6d98701c7ac10d68a814526e8fd0fe96ac1d1fb072f272033e415b753f64a5c		2023-03-03 15:23:43 +01:00
..
include	Merge bitcoin/bitcoin#26612: refactor: RPC: pass named argument value as string_view	2023-03-03 15:23:43 +01:00
lib	univalue: Remove confusing getBool method	2022-12-09 10:03:26 -05:00
test	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
.gitignore	Merge commit '982709199f1b4e9e35211c419a81938f9f1dd4ed' into bitcoin	2015-12-02 12:28:48 +01:00
sources.mk	refactor: integrate no_nul into univalue unitester	2022-07-18 09:15:18 +01:00