Wladimir J. van der Laan c799976c86 Merge #16128: Delete error-prone CScript constructor only used with FindAndDelete ... e1a55690e6 Delete error-prone CScript constructor (Gregory Sanders) Pull request description: The behavior of this constructor is not the expected behavior compared to the other constructors which directly interpret the vector as a CScript, rather than serialize it into a new CScript. It has only four uses in the entire codebase. Delete this constructor and replace its four uses with the more clear serialization construction. ACKs for top commit: Empact: ACK e1a55690e6 sipa: Concept and code review ACK e1a55690e6, but I'd like to make sure we have tests covering the FindAndDelete usage. Tree-SHA512: b6721e343c867ca401a80ec87c25939d7f1fc798f3bf7e5feb0ea6f8280eecb6bd65afc8286912c76ff8119ccea50ad7726b1a4137cae70c9d4fed7d960e10d3		2019-07-08 20:45:12 +02:00
..
bitcoinconsensus.cpp	Drop unused GetType() from CSizeComputer	2018-09-11 00:58:05 -04:00
bitcoinconsensus.h	Update copyright headers to 2018	2018-07-27 07:15:02 -04:00
descriptor.cpp	Add private key derivation functions to descriptors	2019-06-06 22:03:55 +12:00
descriptor.h	Add private key derivation functions to descriptors	2019-06-06 22:03:55 +12:00
interpreter.cpp	Delete error-prone CScript constructor	2019-06-13 09:27:14 -04:00
interpreter.h	Update copyright headers to 2018	2018-07-27 07:15:02 -04:00
script.cpp	Make reasoning about dependencies easier by not including unused dependencies	2019-06-02 17:15:23 +02:00
script.h	Delete error-prone CScript constructor	2019-06-13 09:27:14 -04:00
script_error.cpp	Update copyright headers to 2018	2018-07-27 07:15:02 -04:00
script_error.h	Update copyright headers to 2018	2018-07-27 07:15:02 -04:00
sigcache.cpp	Make reasoning about dependencies easier by not including unused dependencies	2019-06-02 17:15:23 +02:00
sigcache.h	Update copyright headers to 2018	2018-07-27 07:15:02 -04:00
sign.cpp	Abstract out IsSegWitOutput from utxoupdatepsbt	2019-05-10 14:22:33 -07:00
sign.h	Abstract out IsSegWitOutput from utxoupdatepsbt	2019-05-10 14:22:33 -07:00
standard.cpp	Make reasoning about dependencies easier by not including unused dependencies	2019-06-02 17:15:23 +02:00
standard.h	Replace CScriptID and CKeyID in CTxDestination with dedicated types	2019-04-29 10:15:23 -04:00