0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-04 10:07:27 -05:00
bitcoin-bitcoin-core/src/rpc
fanquake 7799f53542
Merge bitcoin/bitcoin#26039: refactor: Run type check against RPCArgs (1/2)
fa9f6d7bcd rpc: Run type check against RPCArgs (MarcoFalke)
faf96721a6 test: Fix wrong types passed to RPCs (MarcoFalke)

Pull request description:

  It seems brittle to require `RPCTypeCheck` being called inside the code logic. Without compile-time enforcement this will lead to places where it is forgotten and thus to inconsistencies and bugs. Fix this by removing the calls to `RPCTypeCheck` and doing the check internally.

  The changes should be reviewed as refactoring changes. However, if they change behavior, it will be a bugfix. For example the changes here happen to also detect/fix bugs like the one fixed in commit 3b5fb6e77a.

ACKs for top commit:
  ajtowns:
    ACK fa9f6d7bcd

Tree-SHA512: fb2c0981fe6e24da3ca7dbc06898730779ea4e02ea485458505a281cf421015e44dad0221a04023fc547ea2c660d94657909843fc85d92b847611ec097532439
2023-01-17 09:39:26 +00:00
..
blockchain.cpp Merge bitcoin/bitcoin#26039: refactor: Run type check against RPCArgs (1/2) 2023-01-17 09:39:26 +00:00
blockchain.h refactor: add kernel/cs_main.* 2023-01-05 09:05:14 +00:00
client.cpp rpc: Return accurate results for scanblocks 2023-01-06 12:01:22 +01:00
client.h
external_signer.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
fees.cpp rpc: Run type check against RPCArgs 2023-01-11 17:42:09 +01:00
mempool.cpp rpc: Run type check against RPCArgs 2023-01-11 17:42:09 +01:00
mempool.h rpc: Move mempool RPCs to new file 2022-03-11 17:46:58 +01:00
mining.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
mining.h rpc: create rpc/mining.h, hoist default max tries values to constant 2020-06-01 15:08:36 +02:00
net.cpp rpc: Run type check against RPCArgs 2023-01-11 17:42:09 +01:00
node.cpp Merge bitcoin/bitcoin#26039: refactor: Run type check against RPCArgs (1/2) 2023-01-17 09:39:26 +00:00
output_script.cpp rpc: Run type check against RPCArgs 2023-01-11 17:42:09 +01:00
protocol.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
rawtransaction.cpp rpc: Run type check against RPCArgs 2023-01-11 17:42:09 +01:00
rawtransaction_util.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
rawtransaction_util.h scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
register.h scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
request.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
request.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
server.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
server.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
server_util.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
server_util.h scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
signmessage.cpp rpc: Move signmessage RPC util to new file 2022-04-28 11:19:29 +02:00
txoutproof.cpp rpc: reduce LOCK(cs_main) scope in gettxoutproof 2022-12-06 15:07:04 -05:00
util.cpp rpc: Run type check against RPCArgs 2023-01-11 17:42:09 +01:00
util.h rpc: Run type check against RPCArgs 2023-01-11 17:42:09 +01:00