Samuel Dobson aabec94541 Merge #17719: Document better -keypool as a look-ahead safety mechanism ... f41d589669 Document better -keypool as a look-ahead safety mechanism (Antoine Riard) Pull request description: If after a backup, an address is issued beyond the initial keypool range and none of the addresses in this range is seen onchain, if a wallet is restored from backup, even in case of rescan, funds may be loss due to the look-ahead buffer not being incremented and so restored wallet not detecting onchain out-of-range address as derived from its seed. This scenario is theoretically unavoidable due to the requirement of the keypool to have a max size. However, given the default keypool size, this is unlikely. Document better keypool size implications to avoid user setting a too low value. While reviewing #17681, it took me a while to figure out the safety implications of keypool, I find it would be better to document this a bit farther to avoid users shooting themselves in the foot. For further context & discussion, see https://github.com/bitcoin/bitcoin/pull/17681#issuecomment-563613452 ACKs for top commit: ryanofsky: Code review ACK f41d589669. Just "Warning:" prefix added since the last review jonatack: ACK f41d589669 code review and build/test. The added `Warning:` since last review is a good addition. Tree-SHA512: d3d0ee88fcdfc5c8841a2bd4bada0e4eeb412a0dce5054e5fb023643c2fa57206a0f3efb06890c245528dc4431413ed2fd5645b9319d26245d044c490b7f0db0		2020-01-30 09:10:15 +13:00
..
bench	Fix benchmarks filters	2020-01-28 17:10:15 +02:00
compat	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
config
consensus	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
crypto	Merge #17691: doc: Add missed copyright headers	2020-01-16 15:58:35 -05:00
index	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
interfaces	scripted-diff: Bump copyright of files changed in 2020	2020-01-15 02:18:00 +07:00
leveldb
logging	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
node	Merge #17156: psbt: check that various indexes and amounts are within bounds	2020-01-29 19:39:50 +08:00
policy	scripted-diff: Bump copyright of files changed in 2020	2020-01-15 02:18:00 +07:00
primitives	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
qt	Merge #17453: gui: Fix intro dialog labels when the prune button is toggled	2020-01-27 18:15:45 +01:00
rpc	Merge #16702: p2p: supplying and using asmap to improve IP bucketing in addrman	2020-01-29 13:55:43 +01:00
script	Fix doxygen errors	2020-01-16 18:25:11 -08:00
secp256k1
support	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
test	Merge #17957: Serialization improvements step 3 (compression.h)	2020-01-29 15:10:59 +01:00
univalue	Update univalue subtree	2019-10-30 16:24:02 -04:00
util	Merge #16702: p2p: supplying and using asmap to improve IP bucketing in addrman	2020-01-29 13:55:43 +01:00
wallet	Merge #17719: Document better -keypool as a look-ahead safety mechanism	2020-01-30 09:10:15 +13:00
zmq	scripted-diff: Bump copyright of files changed in 2020	2020-01-15 02:18:00 +07:00
.clang-format	util: Add AllowShortCaseLabelsOnASingleLine option	2019-10-14 13:24:54 +03:00
addrdb.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
addrdb.h	Convert addrdb/addrman to new serialization	2020-01-02 11:05:36 -08:00
addrman.cpp	Merge #16702: p2p: supplying and using asmap to improve IP bucketing in addrman	2020-01-29 13:55:43 +01:00
addrman.h	Merge #16702: p2p: supplying and using asmap to improve IP bucketing in addrman	2020-01-29 13:55:43 +01:00
amount.h
arith_uint256.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
arith_uint256.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
attributes.h
banman.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
banman.h	scripted-diff: Bump copyright of files changed in 2020	2020-01-15 02:18:00 +07:00
base58.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
base58.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
bech32.cpp	Add some general std::vector utility functions	2019-10-16 08:56:57 -07:00
bech32.h	Assert that the HRP is lowercase in Bech32::Encode	2019-09-05 13:25:11 +12:00
bitcoin-cli-res.rc
bitcoin-cli.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
bitcoin-tx-res.rc
bitcoin-tx.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
bitcoin-wallet-res.rc
bitcoin-wallet.cpp	bitcoin-wallet: Use PACKAGE_NAME in usage help	2020-01-14 18:19:00 +00:00
bitcoind-res.rc
bitcoind.cpp	Merge #16839: Replace Connman and BanMan globals with NodeContext local	2019-10-30 12:35:41 +01:00
blockencodings.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
blockencodings.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
blockfilter.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
blockfilter.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
bloom.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
bloom.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
chain.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
chain.h	Convert chain to new serialization	2020-01-13 08:24:44 -08:00
chainparams.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
chainparams.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
chainparamsbase.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
chainparamsbase.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
chainparamsseeds.h	contrib: Remove invalid nodes from seeds list	2019-10-02 08:51:12 +02:00
checkqueue.h	refactor: Remove redundant conditional	2020-01-21 14:07:42 +00:00
clientversion.cpp
clientversion.h
coins.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
coins.h	Convert compression.h to new serialization framework	2020-01-21 20:29:11 -08:00
compat.h
compressor.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
compressor.h	Convert compression.h to new serialization framework	2020-01-21 20:29:11 -08:00
core_io.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
core_memusage.h
core_read.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
core_write.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
cuckoocache.h	Use correct C++11 header for std::swap()	2019-11-29 21:23:25 +02:00
dbwrapper.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
dbwrapper.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
dummywallet.cpp	scripted-diff: Bump copyright of files changed in 2020	2020-01-15 02:18:00 +07:00
flatfile.cpp
flatfile.h
fs.cpp	scripted-diff: Add missed copyright headers	2020-01-04 20:18:28 +02:00
fs.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
hash.cpp
hash.h
httprpc.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
httprpc.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
httpserver.cpp	net: Avoid using C-style NUL-terminated strings as arguments in the netbase interface	2020-01-08 12:35:59 +00:00
httpserver.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
indirectmap.h
init.cpp	Merge #16702: p2p: supplying and using asmap to improve IP bucketing in addrman	2020-01-29 13:55:43 +01:00
init.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
key.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
key.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
key_io.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
key_io.h
limitedmap.h
logging.cpp	scripted-diff: Bump copyright of files changed in 2020	2020-01-15 02:18:00 +07:00
logging.h	scripted-diff: Bump copyright of files changed in 2020	2020-01-15 02:18:00 +07:00
Makefile.am	Merge #16702: p2p: supplying and using asmap to improve IP bucketing in addrman	2020-01-29 13:55:43 +01:00
Makefile.bench.include	[test] move wallet helper functions into test library	2019-11-25 16:40:09 +01:00
Makefile.leveldb.include
Makefile.qt.include	Merge #17513: refactor, qt: Nuke some circular dependencies	2019-11-21 19:38:39 +01:00
Makefile.qt_locale.include	Restore English translation option	2020-01-06 22:58:47 -05:00
Makefile.qttest.include	build: Create test utility library from src/test/util/	2019-11-21 21:13:08 +01:00
Makefile.test.include	Merge #16702: p2p: supplying and using asmap to improve IP bucketing in addrman	2020-01-29 13:55:43 +01:00
Makefile.test_util.include	[test] move wallet helper functions into test library	2019-11-25 16:40:09 +01:00
memusage.h
merkleblock.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
merkleblock.h
miner.cpp	rpc: Remove mempool global from miner	2019-12-23 06:12:10 +07:00
miner.h	rpc: Remove mempool global from miner	2019-12-23 06:12:10 +07:00
net.cpp	Merge #16702: p2p: supplying and using asmap to improve IP bucketing in addrman	2020-01-29 13:55:43 +01:00
net.h	Merge #16702: p2p: supplying and using asmap to improve IP bucketing in addrman	2020-01-29 13:55:43 +01:00
net_permissions.cpp	net: Avoid using C-style NUL-terminated strings as arguments in the netbase interface	2020-01-08 12:35:59 +00:00
net_permissions.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
net_processing.cpp	Fix doxygen errors	2020-01-16 18:25:11 -08:00
net_processing.h	scripted-diff: Bump copyright of files changed in 2020	2020-01-15 02:18:00 +07:00
net_types.h	refactor: Remove addrdb.h dependency from node.h	2019-10-29 11:30:12 +02:00
netaddress.cpp	Merge #16702: p2p: supplying and using asmap to improve IP bucketing in addrman	2020-01-29 13:55:43 +01:00
netaddress.h	Merge #16702: p2p: supplying and using asmap to improve IP bucketing in addrman	2020-01-29 13:55:43 +01:00
netbase.cpp	Merge #17754: net: Don't allow resolving of std::string with embedded NUL characters. Add tests.	2020-01-22 20:20:45 +01:00
netbase.h	net: Avoid using C-style NUL-terminated strings as arguments in the netbase interface	2020-01-08 12:35:59 +00:00
netmessagemaker.h
noui.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
noui.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
optional.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
outputtype.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
outputtype.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
pow.cpp
pow.h
prevector.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
protocol.cpp	p2p: Remove BIP61 reject messages	2019-10-02 10:39:14 -04:00
protocol.h	Merge #17474: Bugfix: GUI: Recognise NETWORK_LIMITED in formatServicesStr	2019-12-11 17:00:27 -05:00
psbt.cpp	Merge #17156: psbt: check that various indexes and amounts are within bounds	2020-01-29 19:39:50 +08:00
psbt.h	Fix doxygen errors	2020-01-16 18:25:11 -08:00
pubkey.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
pubkey.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
random.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
random.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
randomenv.cpp	Put bounds on the number of CPUID leaves explored	2019-11-20 10:54:08 -08:00
randomenv.h	[MOVEONLY] Move perfmon data gathering to new randomenv module	2019-11-12 14:50:44 -08:00
rest.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
reverse_iterator.h
reverselock.h
scheduler.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
scheduler.h	scripted-diff: Bump copyright of files changed in 2020	2020-01-15 02:18:00 +07:00
serialize.h	Add FORMATTER_METHODS, similar to SERIALIZE_METHODS, but for formatters	2020-01-18 07:43:22 -08:00
shutdown.cpp
shutdown.h
span.h
streams.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
sync.cpp	scripted-diff: Bump copyright of files changed in 2020	2020-01-15 02:18:00 +07:00
sync.h	scripted-diff: Bump copyright of files changed in 2020	2020-01-15 02:18:00 +07:00
threadinterrupt.cpp
threadinterrupt.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
threadsafety.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
timedata.cpp	scripted-diff: Bump copyright of files changed in 2020	2020-01-15 02:18:00 +07:00
timedata.h
tinyformat.h	util: Update tinyformat to upstream	2019-12-06 10:02:08 +01:00
torcontrol.cpp	net: Avoid using C-style NUL-terminated strings as arguments in the netbase interface	2020-01-08 12:35:59 +00:00
torcontrol.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
txdb.cpp	Convert compression.h to new serialization framework	2020-01-21 20:29:11 -08:00
txdb.h	scripted-diff: Bump copyright of files changed in 2020	2020-01-15 02:18:00 +07:00
txmempool.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
txmempool.h	scripted-diff: Bump copyright of files changed in 2020	2020-01-15 02:18:00 +07:00
ui_interface.cpp	scripted-diff: Bump copyright of files changed in 2020	2020-01-15 02:18:00 +07:00
ui_interface.h	scripted-diff: Bump copyright of files changed in 2020	2020-01-15 02:18:00 +07:00
uint256.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
uint256.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
undo.h	Convert compression.h to new serialization framework	2020-01-21 20:29:11 -08:00
validation.cpp	scripted-diff: Bump copyright of files changed in 2020	2020-01-15 02:18:00 +07:00
validation.h	scripted-diff: Bump copyright of files changed in 2020	2020-01-15 02:18:00 +07:00
validationinterface.cpp	scripted-diff: Bump copyright of files changed in 2020	2020-01-15 02:18:00 +07:00
validationinterface.h	scripted-diff: Bump copyright of files changed in 2020	2020-01-15 02:18:00 +07:00
version.h
versionbits.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
versionbits.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
versionbitsinfo.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
versionbitsinfo.h
walletinitinterface.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
warnings.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
warnings.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00