foster/bitcoin-bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-10 10:52:31 -05:00
Code Issues Activity
bitcoin-bitcoin-core/src/interfaces
History
Wladimir J. van der Laan f2c416bcf5
Merge #16995: Fix gcc 9 warnings 
ff9c671b11 refactor: Work around GCC 9 `-Wredundant-move` warning (Russell Yanofsky)
b837b334db net: Fail instead of truncate command name in CMessageHeader (Wladimir J. van der Laan)

Pull request description:

  Fixes all 3 from #16992 (see commits)

  - net: Fail instead of truncate command name in CMessageHeader
  - refactor: Use std::move workaround for unique_ptr upcast only when necessary

ACKs for top commit:
  practicalswift:
    ACK ff9c671b11 -- patch looks correct
  sipa:
    utACK ff9c671b11
  ryanofsky:
    Code review ACK ff9c671b11. Looks good and seems to pass travis, modulo a timeout on one build
  hebasto:
    ACK ff9c671b11, tested on Fedora 31:

Tree-SHA512: 52d8c13aaf0d56f9bc546a98d7f853eae21f7e325b202fdeb2286b19a9a0ee308634c644b039f60ad8043421e382381cbf1bce58d9f807547f928621c7d245d0
2020-03-27 20:04:46 +01:00
..
chain.cpp Merge #16995: Fix gcc 9 warnings 2020-03-27 20:04:46 +01:00
chain.h refactor: Change Chain::broadcastTransaction param order 2020-03-19 15:26:04 -05:00
handler.cpp scripted-diff: Bump copyright of files changed in 2020 2020-01-15 02:18:00 +07:00
handler.h scripted-diff: Bump copyright of files changed in 2020 2020-01-15 02:18:00 +07:00
node.cpp refactor: Change createWallet, fillPSBT argument order 2020-03-19 15:26:04 -05:00
node.h refactor: Change createWallet, fillPSBT argument order 2020-03-19 15:26:04 -05:00
README.md Suggested interfaces::Chain cleanups from #15288 2019-03-04 15:57:58 -05:00
wallet.cpp Merge #18312: wallet: remove deprecated fee bumping by totalFee 2020-03-26 18:34:49 +01:00
wallet.h Merge #18312: wallet: remove deprecated fee bumping by totalFee 2020-03-26 18:34:49 +01:00

README.md

Internal c++ interfaces

The following interfaces are defined here:

  • Chain — used by wallet to access blockchain and mempool state. Added in #14437, #14711, #15288, and #10973.

  • ChainClient — used by node to start & stop Chain clients. Added in #14437.

  • Node — used by GUI to start & stop bitcoin node. Added in #10244.

  • Wallet — used by GUI to access wallets. Added in #10244.

  • Handler — returned by handleEvent methods on interfaces above and used to manage lifetimes of event handlers.

  • Init — used by multiprocess code to access interfaces above on startup. Added in #10102.

The interfaces above define boundaries between major components of bitcoin code (node, wallet, and gui), making it possible for them to run in different processes, and be tested, developed, and understood independently. These interfaces are not currently designed to be stable or to be used externally.