mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-02-10 10:52:31 -05:00
8efd03ad04
fa09451f8eAdd lint check for bitcoin-config.h include IWYU pragma (MarcoFalke)dddd40ba82scripted-diff: Add IWYU pragma keep to bitcoin-config.h includes (MarcoFalke) Pull request description: The `bitcoin-config.h` includes have issues: * The header is incompatible with iwyu, because symbols may be defined or not defined. So the `IWYU pragma: keep` is needed to keep the include when a symbol is not defined on a platform. Compare the previous discussion in https://github.com/bitcoin/bitcoin/pull/29408#issuecomment-1948959711 * Guarding the includes by `HAVE_CONFIG_H` is verbose and brittle. Now that all build config dependencies have been removed from low level headers, the benefits are questionable, and the guard can be removed. The linter could also be tricked by guarding the include by `#if defined(HAVE_C0NFIG_H)` (`O` replaced by `0`). Compare the previous discussion in https://github.com/bitcoin/bitcoin/pull/29404#discussion_r1483189853 . ACKs for top commit: achow101: ACKfa09451f8eTheCharlatan: ACKfa09451f8ehebasto: re-ACKfa09451f8e, only rebased since my recent [review](https://github.com/bitcoin/bitcoin/pull/29494#pullrequestreview-2028864535) (`timedata.cpp` removed in https://github.com/bitcoin/bitcoin/pull/29623). Tree-SHA512: 47cb973f7f24bc625acc4e78683371863675d186780236d55d886cf4130e05a78bb04f1d731aae7088313b8e963a9677cc77cf518187dbd99d776f6421ca9b52
65 lines
1.8 KiB
C++
65 lines
1.8 KiB
C++
// Copyright (c) 2009-2010 Satoshi Nakamoto
|
|
// Copyright (c) 2009-2022 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#include <config/bitcoin-config.h> // IWYU pragma: keep
|
|
|
|
#include <warnings.h>
|
|
|
|
#include <common/system.h>
|
|
#include <sync.h>
|
|
#include <util/translation.h>
|
|
|
|
#include <optional>
|
|
#include <vector>
|
|
|
|
static GlobalMutex g_warnings_mutex;
|
|
static bilingual_str g_misc_warnings GUARDED_BY(g_warnings_mutex);
|
|
static bool fLargeWorkInvalidChainFound GUARDED_BY(g_warnings_mutex) = false;
|
|
static std::optional<bilingual_str> g_timeoffset_warning GUARDED_BY(g_warnings_mutex){};
|
|
|
|
void SetMiscWarning(const bilingual_str& warning)
|
|
{
|
|
LOCK(g_warnings_mutex);
|
|
g_misc_warnings = warning;
|
|
}
|
|
|
|
void SetfLargeWorkInvalidChainFound(bool flag)
|
|
{
|
|
LOCK(g_warnings_mutex);
|
|
fLargeWorkInvalidChainFound = flag;
|
|
}
|
|
|
|
void SetMedianTimeOffsetWarning(std::optional<bilingual_str> warning)
|
|
{
|
|
LOCK(g_warnings_mutex);
|
|
g_timeoffset_warning = warning;
|
|
}
|
|
|
|
std::vector<bilingual_str> GetWarnings()
|
|
{
|
|
std::vector<bilingual_str> warnings;
|
|
|
|
LOCK(g_warnings_mutex);
|
|
|
|
// Pre-release build warning
|
|
if (!CLIENT_VERSION_IS_RELEASE) {
|
|
warnings.emplace_back(_("This is a pre-release test build - use at your own risk - do not use for mining or merchant applications"));
|
|
}
|
|
|
|
// Misc warnings like out of disk space and clock is wrong
|
|
if (!g_misc_warnings.empty()) {
|
|
warnings.emplace_back(g_misc_warnings);
|
|
}
|
|
|
|
if (fLargeWorkInvalidChainFound) {
|
|
warnings.emplace_back(_("Warning: We do not appear to fully agree with our peers! You may need to upgrade, or other nodes may need to upgrade."));
|
|
}
|
|
|
|
if (g_timeoffset_warning) {
|
|
warnings.emplace_back(g_timeoffset_warning.value());
|
|
}
|
|
|
|
return warnings;
|
|
}
|