0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-09 10:43:19 -05:00
bitcoin-bitcoin-core/src/test
Andrew Chow 80fc1af096
Merge bitcoin/bitcoin#26289: Use util::Result in for calculating mempool ancestors
47c4b1f52a mempool: log/halt when CalculateMemPoolAncestors fails unexpectedly (stickies-v)
5481f65849 mempool: add AssumeCalculateMemPoolAncestors helper function (stickies-v)
f911bdfff9 mempool: use util::Result for CalculateMemPoolAncestors (stickies-v)
66e028f739 mempool: use util::Result for CalculateAncestorsAndCheckLimits (stickies-v)

Pull request description:

  Upon reviewing the documentation for `CTxMemPool::CalculateMemPoolAncestors`, I noticed `setAncestors` was meant to be an `out` parameter but actually is an `in,out` parameter, as can be observed by adding `assert(setAncestors.empty());` as the first line in the function and running `make check`. This PR fixes this unexpected behaviour and introduces refactoring improvements to make intents and effects of the code more clear.

  ## Unexpected behaviour
  This behaviour occurs only in the package acceptance path, currently only triggered by `testmempoolaccept` and `submitpackage` RPCs.

  In `MemPoolAccept::AcceptMultipleTransactions()`, we first call `PreChecks()` and then `SubmitPackage()` with the same `Workspace ws` reference. `PreChecks` leaves `ws.m_ancestors` in a potentially non-empty state, before it is passed on to `MemPoolAccept::SubmitPackage`. `SubmitPackage` is the only place where `setAncestors` isn't guaranteed to be empty before calling `CalculateMemPoolAncestors`. The most straightforward fix is to just forcefully clear `setAncestors` at the beginning of CalculateMemPoolAncestors, which is done in the first bugfix commit.

  ## Improvements
  ### Return value instead of out-parameters
  This PR updates the function signatures for `CTxMemPool::CalculateMemPoolAncestors` and `CTxMemPool::CalculateAncestorsAndCheckLimits` to use a `util::Result` return type and eliminate both the `setAncestors` `in,out`-parameter as well as the error string. It simplifies the code and makes the intent and effects more explicit.

  ### Observability
  There are 7 instances where we currently call `CalculateMemPoolAncestors` without actually checking if the function succeeded because we assume that it can't fail, such as in [miner.cpp](69b10212ea/src/node/miner.cpp (L399)). This PR adds a new wrapper `AssumeCalculateMemPoolAncestors` function that logs such unexpected failures, or in case of debug builds even halts the program. It's not crucial to the objective, more of an observability improvement that seems sensible to add on here.

ACKs for top commit:
  achow101:
    ACK 47c4b1f52a
  w0xlt:
    ACK 47c4b1f52a
  glozow:
    ACK 47c4b1f52a
  furszy:
    light code review ACK 47c4b1f5
  aureleoules:
    ACK 47c4b1f52a

Tree-SHA512: d908dad00d1a5645eb865c4877cc0bae74b9cd3332a3641eb4a285431aef119f9fc78172d38b55c592168a73dae83242e6af3348815f7b37cbe2d448a3a58648
2023-01-03 16:30:55 -05:00
..
data scripted-diff: Regenerate key_io data deterministically 2022-04-06 17:08:07 +02:00
fuzz scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
util scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
addrman_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
allocator_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
amount_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
argsman_tests.cpp test: Split overly large util_tests.cpp file 2022-11-14 14:22:43 +01:00
arith_uint256_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
banman_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
base32_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
base58_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
base64_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
bech32_tests.cpp Make Bech32 LocateErrors return error list rather than using out-arg 2021-12-06 14:17:41 +13:00
bip32_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
blockchain_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
blockencodings_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
blockfilter_index_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
blockfilter_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
blockmanager_tests.cpp reindex, log, test: fixes #21379 2022-05-07 07:11:29 -04:00
bloom_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
bswap_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
checkqueue_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
coins_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
coinstatsindex_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
compilerbug_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
compress_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
crypto_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
cuckoocache_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
dbwrapper_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
denialofservice_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
descriptor_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
flatfile_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
fs_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
getarg_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
hash_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
headers_sync_chainwork_tests.cpp Add unit test for HeadersSyncState 2022-08-29 08:10:35 -04:00
httpserver_tests.cpp Add GetQueryParameter helper function 2022-03-10 12:01:54 +01:00
i2p_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
interfaces_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
key_io_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
key_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
logging_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
main.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
Makefile
mempool_tests.cpp Merge bitcoin/bitcoin#26289: Use util::Result in for calculating mempool ancestors 2023-01-03 16:30:55 -05:00
merkle_tests.cpp
merkleblock_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
miner_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
miniscript_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
minisketch_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
multisig_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
net_peer_eviction_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
net_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
netbase_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
orphanage_tests.cpp scripted-diff: rename and de-globalise g_cs_orphans 2022-10-11 23:35:37 +10:00
pmt_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
policy_fee_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
policyestimator_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
pow_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
prevector_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
raii_event_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
random_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
rbf_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
README.md test: parse the command line arguments in unit tests 2022-01-11 11:53:30 +01:00
rest_tests.cpp Handle query string when parsing data format 2022-03-10 12:01:53 +01:00
result_tests.cpp refactor: Replace BResult with util::Result 2022-08-03 07:33:01 -04:00
reverselock_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
rpc_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
sanity_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
scheduler_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
script_p2sh_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
script_parse_tests.cpp
script_segwit_tests.cpp
script_standard_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
script_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
scriptnum10.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
scriptnum_tests.cpp
serfloat_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
serialize_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
settings_tests.cpp settings: Add update/getPersistent/isIgnored methods 2022-05-19 11:32:56 -04:00
sighash_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
sigopcount_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
skiplist_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
sock_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
streams_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
sync_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
system_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
timedata_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
torcontrol_tests.cpp
transaction_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
txindex_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
txpackage_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
txreconciliation_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
txrequest_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
txvalidation_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
txvalidationcache_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
uint256_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
util_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
util_threadnames_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
validation_block_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
validation_chainstate_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
validation_chainstatemanager_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
validation_flush_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
validation_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
validationinterface_tests.cpp
versionbits_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00

Unit tests

The sources in this directory are unit test cases. Boost includes a unit testing framework, and since Bitcoin Core already uses Boost, it makes sense to simply use this framework rather than require developers to configure some other framework (we want as few impediments to creating unit tests as possible).

The build system is set up to compile an executable called test_bitcoin that runs all of the unit tests. The main source file for the test library is found in util/setup_common.cpp.

Compiling/running unit tests

Unit tests will be automatically compiled if dependencies were met in ./configure and tests weren't explicitly disabled.

After configuring, they can be run with make check.

To run the unit tests manually, launch src/test/test_bitcoin. To recompile after a test file was modified, run make and then run the test again. If you modify a non-test file, use make -C src/test to recompile only what's needed to run the unit tests.

To add more unit tests, add BOOST_AUTO_TEST_CASE functions to the existing .cpp files in the test/ directory or add new .cpp files that implement new BOOST_AUTO_TEST_SUITE sections.

To run the GUI unit tests manually, launch src/qt/test/test_bitcoin-qt

To add more GUI unit tests, add them to the src/qt/test/ directory and the src/qt/test/test_main.cpp file.

Running individual tests

test_bitcoin accepts the command line arguments from the boost framework. For example, to run just the getarg_tests suite of tests:

test_bitcoin --log_level=all --run_test=getarg_tests

log_level controls the verbosity of the test framework, which logs when a test case is entered, for example. test_bitcoin also accepts the command line arguments accepted by bitcoind. Use -- to separate both types of arguments:

test_bitcoin --log_level=all --run_test=getarg_tests -- -printtoconsole=1

The -printtoconsole=1 after the two dashes redirects the debug log, which would normally go to a file in the test datadir (BasicTestingSetup::m_path_root), to the standard terminal output.

... or to run just the doubledash test:

test_bitcoin --run_test=getarg_tests/doubledash

Run test_bitcoin --help for the full list.

Adding test cases

To add a new unit test file to our test suite you need to add the file to src/Makefile.test.include. The pattern is to create one test file for each class or source file for which you want to create unit tests. The file naming convention is <source_filename>_tests.cpp and such files should wrap their tests in a test suite called <source_filename>_tests. For an example of this pattern, see uint256_tests.cpp.

Logging and debugging in unit tests

make check will write to a log file foo_tests.cpp.log and display this file on failure. For running individual tests verbosely, refer to the section above.

To write to logs from unit tests you need to use specific message methods provided by Boost. The simplest is BOOST_TEST_MESSAGE.

For debugging you can launch the test_bitcoin executable with gdb or lldb and start debugging, just like you would with any other program:

gdb src/test/test_bitcoin

Segmentation faults

If you hit a segmentation fault during a test run, you can diagnose where the fault is happening by running gdb ./src/test/test_bitcoin and then using the bt command within gdb.

Another tool that can be used to resolve segmentation faults is valgrind.

If for whatever reason you want to produce a core dump file for this fault, you can do that as well. By default, the boost test runner will intercept system errors and not produce a core file. To bypass this, add --catch_system_errors=no to the test_bitcoin arguments and ensure that your ulimits are set properly (e.g. ulimit -c unlimited).

Running the tests and hitting a segmentation fault should now produce a file called core (on Linux platforms, the file name will likely depend on the contents of /proc/sys/kernel/core_pattern).

You can then explore the core dump using

gdb src/test/test_bitcoin core

(gbd) bt  # produce a backtrace for where a segfault occurred