0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-11 11:16:09 -05:00
bitcoin-bitcoin-core/src/wallet/rpc
Andrew Chow 887796a5ff
Merge bitcoin/bitcoin#23341: RPC: Better safety with newkeypool command and wallet backups
a2a92317ad rpc: Add warning to user about newkeypool command (Samuel Dobson)

Pull request description:

  This PR prevents `newkeypool` from being run on non-HD wallets, because this would require a new backup every time, so it isn't very safe.

  David Harding also suggested [here](https://github.com/bitcoin/bitcoin/pull/23093#issuecomment-945350003) that the RPC help text should include a warning to the users about the interaction between newkeypool.

ACKs for top commit:
  achow101:
    ACK a2a92317ad

Tree-SHA512: 0aa497900f1d179764bce13ffce0bb081ba2ca354492bf2e04b21d0212e960b3ed13a386fbf65602b6b50461f4056a0285752ef707d312da28e82449cd8ea048
2021-12-20 14:51:39 -05:00
..
addresses.cpp Merge bitcoin/bitcoin#23341: RPC: Better safety with newkeypool command and wallet backups 2021-12-20 14:51:39 -05:00
backup.cpp Merge bitcoin/bitcoin#23750: rpcwallet: mention labels are disabled for ranged descriptors 2021-12-16 08:46:09 +01:00
coins.cpp scripted-diff: Use named args in RPC docs 2021-12-08 11:54:12 +01:00
encrypt.cpp MOVEONLY: Move wallet encryption RPCs to encrypt.cpp 2021-12-03 12:34:01 +13:00
signmessage.cpp MOVEONLY: Move utility functions from rpcwallet to wallet/rpc/util 2021-12-01 19:22:38 +13:00
spend.cpp Merge bitcoin/bitcoin#22514: psbt: Actually use SIGHASH_DEFAULT for PSBT signing 2021-12-10 10:17:36 +01:00
transactions.cpp scripted-diff: Use named args in RPC docs 2021-12-08 11:54:12 +01:00
util.cpp refactor: Move restorewallet() RPC logic to the wallet section 2021-12-15 18:41:40 -03:00
util.h refactor: Move restorewallet() RPC logic to the wallet section 2021-12-15 18:41:40 -03:00
wallet.cpp Merge bitcoin/bitcoin#23721: wallet, refactor: Move restorewallet() logic to the wallet section 2021-12-16 08:42:44 +01:00
wallet.h Remove unused imports from rpc/wallet and reorder RPCs 2021-12-08 11:45:21 +13:00