foster/bitcoin-bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-09 10:43:19 -05:00
Code Issues Activity
bitcoin-bitcoin-core/src/interfaces
History
Samuel Dobson e9d6eb1b80
Merge bitcoin/bitcoin#22217: refactor: Avoid wallet code writing node settings file 
49ee2a0ad8 Avoid wallet code writing node settings file (Russell Yanofsky)

Pull request description:

  Change wallet loading code to access settings through the Chain interface instead of writing settings.json directly. This is for running wallet and node in separate processes, since multiprocess code wouldn't easily work with different processes updating the same file.

  ---

  This PR is part of the [process separation project](https://github.com/bitcoin/bitcoin/projects/10). The commit was first part of larger PR #10102.

ACKs for top commit:
  jamesob:
    ACK 49ee2a0ad8 ([`jamesob/ackr/22217.1.ryanofsky.refactor_avoid_wallet_co`](https://github.com/jamesob/bitcoin/tree/ackr/22217.1.ryanofsky.refactor_avoid_wallet_co))
  ryanofsky:
    > ACK [49ee2a0](49ee2a0ad8) ([`jamesob/ackr/22217.1.ryanofsky.refactor_avoid_wallet_co`](https://github.com/jamesob/bitcoin/tree/ackr/22217.1.ryanofsky.refactor_avoid_wallet_co))
  Zero-1729:
    crACK 49ee2a0ad8
  meshcollider:
    Code review ACK 49ee2a0ad8

Tree-SHA512: a81c63b87816f739e02e3992808f314294d6c7213babaafdaaf3c4650ebc97ee4f98f9a4684ce4ff87372df59989b8ad5929159c5686293a7cce04e97e2fabba
2021-08-19 10:44:25 +12:00
..
chain.h Merge bitcoin/bitcoin#22217: refactor: Avoid wallet code writing node settings file 2021-08-19 10:44:25 +12:00
echo.cpp multiprocess: Add echoipc RPC method and test 2021-04-23 03:02:50 -05:00
echo.h multiprocess: Add echoipc RPC method and test 2021-04-23 03:02:50 -05:00
handler.cpp scripted-diff: remove MakeUnique<T>() 2021-03-11 13:45:14 +08:00
handler.h scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
init.cpp multiprocess: Add echoipc RPC method and test 2021-04-23 03:02:50 -05:00
init.h multiprocess: Add echoipc RPC method and test 2021-04-23 03:02:50 -05:00
ipc.h Add ipc::Context and ipc::capnp::Context structs 2021-06-10 09:58:45 -05:00
node.h refactor: reduce #ifdef ENABLE_EXTERNAL_SIGNER usage 2021-06-16 10:48:58 +02:00
README.md multiprocess: Add comments and documentation 2021-04-23 03:02:50 -05:00
wallet.h refactor: remove ::vpwallets and related global variables 2021-08-17 04:05:15 -04:00

README.md

Internal c++ interfaces

The following interfaces are defined here:

  • Chain — used by wallet to access blockchain and mempool state. Added in #14437, #14711, #15288, and #10973.

  • ChainClient — used by node to start & stop Chain clients. Added in #14437.

  • Node — used by GUI to start & stop bitcoin node. Added in #10244.

  • Wallet — used by GUI to access wallets. Added in #10244.

  • Handler — returned by handleEvent methods on interfaces above and used to manage lifetimes of event handlers.

  • Init — used by multiprocess code to access interfaces above on startup. Added in #19160.

  • Ipc — used by multiprocess code to access Init interface across processes. Added in #19160.

The interfaces above define boundaries between major components of bitcoin code (node, wallet, and gui), making it possible for them to run in different processes, and be tested, developed, and understood independently. These interfaces are not currently designed to be stable or to be used externally.