0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-06 10:18:44 -05:00
bitcoin-bitcoin-core/src/qt/forms
Samuel Dobson abb30de63f
Merge #17587: gui: show watch-only balance in send screen
4a96e459d7 [gui] send: show watch-only balance in send screen (Sjors Provoost)
2689c8fd71 [test] qt: add send screen balance test (Sjors Provoost)

Pull request description:

  Now that we can create a PSBT from a watch-only wallet (#16944), we should also display the watch-only balance on the send screen.

  Before:
  <img width="1008" alt="before" src="https://user-images.githubusercontent.com/10217/69533384-030e9180-0f78-11ea-9748-c32c957e822e.png">

  After:
  <img width="1009" alt="Schermafbeelding 2019-11-26 om 11 44 17" src="https://user-images.githubusercontent.com/10217/69622879-19811f80-1042-11ea-8279-091012f39b38.png">

  I added a test to check the balance on the send screen, but it only covers regular wallets. A better would add a watch-only only wallet.

ACKs for top commit:
  meshcollider:
    utACK 4a96e459d7
  jb55:
    utACK 4a96e459d7
  promag:
    reACK 4a96e45, rebased and label change since last review.
  instagibbs:
    code review and light test ACK 4a96e459d7

Tree-SHA512: 4213549888bd309f72bdbba1453218f4a2b07e809100d786a3791897c75468f9092b06fe4b971942b1c228aa75ee7c04971f262ca9a478b42756e056eb534620
2019-11-29 23:16:08 +13:00
..
addressbookpage.ui [qt] Add support to search the address book 2018-01-03 16:15:15 +00:00
askpassphrasedialog.ui gui: fix passphrase labels/tooltip in createwalletdialog/askpassphrasedialog 2019-09-09 10:57:38 +02:00
coincontroldialog.ui gui: move coin control OK to the right 2019-05-28 11:16:39 -04:00
createwalletdialog.ui gui: fix passphrase labels/tooltip in createwalletdialog/askpassphrasedialog 2019-09-09 10:57:38 +02:00
debugwindow.ui Merge #14879: qt: Add warning messages to the debug window 2019-08-28 16:03:09 -04:00
editaddressdialog.ui qt: refactor: Use absolute include paths in .ui files 2017-11-16 08:23:02 +13:00
helpmessagedialog.ui Unify package name to as few places as possible without major changes 2015-12-14 02:11:10 +00:00
intro.ui [gui] intro: add prune preference 2019-08-24 22:41:32 +02:00
modaloverlay.ui qt: Fix class name of Ui::ModalOverlay 2019-11-26 02:22:29 +02:00
openuridialog.ui gui: remove payment request file handling from OpenURI dialog 2019-10-24 16:01:43 -04:00
optionsdialog.ui Correct units for "-dbcache" and "-prune" 2019-01-30 07:17:22 +02:00
overviewpage.ui Merge #8972: [Qt] make warnings label selectable (jonasschnelli) 2016-10-19 11:27:21 +02:00
receivecoinsdialog.ui qt: Use proper class for Ui::ReceiveCoinsDialog 2019-11-26 02:31:28 +02:00
receiverequestdialog.ui GUI: Move QRImageWidget to its own file-pair 2019-05-02 12:18:18 +00:00
sendcoinsdialog.ui [gui] send: show watch-only balance in send screen 2019-11-26 11:43:53 +01:00
sendcoinsentry.ui gui: Fix payAmount tooltip in SendCoinsEntry 2019-10-23 11:38:30 +01:00
signverifymessagedialog.ui gui: Add placeholder text to the sign message field 2019-10-18 12:21:42 +01:00
transactiondescdialog.ui qt: Add transaction hash to details window title 2016-04-26 16:05:10 +02:00