foster/bitcoin-bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-04 10:07:27 -05:00
Code Issues Activity
bitcoin-bitcoin-core/src/wallet
History
MarcoFalke 9beded5860
Merge #12719: tests: Add note about test suite naming convention in developer-notes.md 
db983beba6 tests: Add lint-tests.sh which checks the test suite naming convention (practicalswift)
5fd864fe8a tests: Rename test suits not following the test suite naming convention (practicalswift)
7b4a296a71 tests: Add note about test suite naming convention (practicalswift)

Pull request description:

  Changes:
  * Add note about test suite naming convention
  * Fix exceptions
  * Add regression test

  Rationale:
  * Consistent naming of test suites makes programmatic test running of specific tests/subsets of tests easier
  * Explicit is better than implicit

  Before this commit:

  ```
  $ contrib/devtools/lint-tests.sh
  The test suite in file src/test/foo_tests.cpp should be named
  "foo_tests". Please make sure the following test suites follow
  that convention:

  src/test/blockchain_tests.cpp:BOOST_FIXTURE_TEST_SUITE(blockchain_difficulty_tests, BasicTestingSetup)
  src/test/prevector_tests.cpp:BOOST_FIXTURE_TEST_SUITE(PrevectorTests, TestingSetup)
  src/wallet/test/coinselector_tests.cpp:BOOST_FIXTURE_TEST_SUITE(coin_selection_tests, WalletTestingSetup)
  src/wallet/test/crypto_tests.cpp:BOOST_FIXTURE_TEST_SUITE(wallet_crypto, BasicTestingSetup)
  $
  ```

  After this commit:

  ```
  $ contrib/devtools/lint-tests.sh
  $
  ```

Tree-SHA512: 7258ab9a6b9b8fc1939efadc619e2f2f02cfce8034c7f2e5dc5ecc769aa12e17f6fb8e363817feaf15c026c5b958b2574525b8d2d3f6be69658679bf8ceea9e9
2018-04-01 18:28:22 -04:00
..
test Merge #12719: tests: Add note about test suite naming convention in developer-notes.md 2018-04-01 18:28:22 -04:00
coincontrol.h wallet: Change output type globals to members 2018-03-17 16:10:01 -04:00
coinselection.cpp Move current coin selection algorithm to coinselection.{cpp,h} 2018-03-13 12:39:26 -04:00
coinselection.h Move current coin selection algorithm to coinselection.{cpp,h} 2018-03-13 12:39:26 -04:00
crypter.cpp Merge #11403: SegWit wallet support 2018-01-10 20:55:41 -10:00
crypter.h tests: Rename test suits not following the test suite naming convention 2018-03-19 08:54:07 +01:00
db.cpp scripted-diff: Convert 11 enums into scoped enums (C++11) 2018-03-09 15:03:40 +01:00
db.h scripted-diff: Convert 11 enums into scoped enums (C++11) 2018-03-09 15:03:40 +01:00
feebumper.cpp Merge #10637: Coin Selection with Murch's algorithm 2018-03-14 18:01:36 +01:00
feebumper.h feebumper: Use PreconditionChecks to determine bump eligibility 2018-01-29 18:31:33 -05:00
fees.cpp Add a GetMinimumFeeRate function which is wrapped by GetMinimumFee 2018-03-13 12:39:26 -04:00
fees.h Add a GetMinimumFeeRate function which is wrapped by GetMinimumFee 2018-03-13 12:39:26 -04:00
init.cpp Merge #10762: [wallet] Remove Wallet dependencies from init.cpp 2018-03-29 17:03:22 +02:00
init.h [wallet] Use global g_wallet_init_interface to init/destroy the wallet. 2018-03-27 14:48:48 -04:00
rpcdump.cpp Merge #10742: scripted-diff: Use scoped enumerations (C++11, "enum class") 2018-03-27 16:38:14 +02:00
rpcwallet.cpp Merge #10742: scripted-diff: Use scoped enumerations (C++11, "enum class") 2018-03-27 16:38:14 +02:00
rpcwallet.h Split signrawtransaction into wallet and non-wallet 2018-02-17 11:42:00 -05:00
wallet.cpp Merge #10742: scripted-diff: Use scoped enumerations (C++11, "enum class") 2018-03-27 16:38:14 +02:00
wallet.h Merge #11536: Rename account to label where appropriate 2018-03-22 21:27:53 +01:00
walletdb.cpp Merge #10742: scripted-diff: Use scoped enumerations (C++11, "enum class") 2018-03-27 16:38:14 +02:00
walletdb.h scripted-diff: Convert 11 enums into scoped enums (C++11) 2018-03-09 15:03:40 +01:00
walletutil.cpp Don't allow relative -walletdir paths 2018-01-18 15:09:27 -05:00
walletutil.h Cleanups for walletdir PR 2017-12-13 23:36:43 +13:00