mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-02-13 11:25:02 -05:00
a23cca56c0
Rename `BResult` class to `util::Result` and update the class interface to be more compatible with `std::optional` and with a full-featured result class implemented in https://github.com/bitcoin/bitcoin/pull/25665. Motivation for this change is to update existing `BResult` usages now so they don't have to change later when more features are added in #25665. This change makes the following improvements originally implemented in #25665: - More explicit API. Drops potentially misleading `BResult` constructor that treats any bilingual string argument as an error. Adds `util::Error` constructor so it is never ambiguous when a result is being assigned an error or non-error value. - Better type compatibility. Supports `util::Result<bilingual_str>` return values to hold translated messages which are not errors. - More standard and consistent API. `util::Result` supports most of the same operators and methods as `std::optional`. `BResult` had a less familiar interface with `HasRes`/`GetObj`/`ReleaseObj` methods. The Result/Res/Obj naming was also not internally consistent. - Better code organization. Puts `src/util/` code in the `util::` namespace so naming reflects code organization and it is obvious where the class is coming from. Drops "B" from name because it is undocumented what it stands for (bilingual?) - Has unit tests. |
||
|---|---|---|
| .. | ||
| rpc | ||
| test | ||
| bdb.cpp | ||
| bdb.h | ||
| coincontrol.cpp | ||
| coincontrol.h | ||
| coinselection.cpp | ||
| coinselection.h | ||
| context.cpp | ||
| context.h | ||
| crypter.cpp | ||
| crypter.h | ||
| db.cpp | ||
| db.h | ||
| dump.cpp | ||
| dump.h | ||
| external_signer_scriptpubkeyman.cpp | ||
| external_signer_scriptpubkeyman.h | ||
| feebumper.cpp | ||
| feebumper.h | ||
| fees.cpp | ||
| fees.h | ||
| init.cpp | ||
| interfaces.cpp | ||
| ismine.h | ||
| load.cpp | ||
| load.h | ||
| receive.cpp | ||
| receive.h | ||
| salvage.cpp | ||
| salvage.h | ||
| scriptpubkeyman.cpp | ||
| scriptpubkeyman.h | ||
| spend.cpp | ||
| spend.h | ||
| sqlite.cpp | ||
| sqlite.h | ||
| transaction.cpp | ||
| transaction.h | ||
| wallet.cpp | ||
| wallet.h | ||
| walletdb.cpp | ||
| walletdb.h | ||
| wallettool.cpp | ||
| wallettool.h | ||
| walletutil.cpp | ||
| walletutil.h | ||