foster/bitcoin-bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-06 10:18:44 -05:00
Code Issues Activity
bitcoin-bitcoin-core/src/qt
History
MarcoFalke dbd7a91fdf
Merge #19310: wallet: BerkeleyDatabase make BerkeleyDatabase::Create, CreateMock, and CreateDummy non-static functions 
da7a83c5ee Remove WalletDatabase::Create, CreateMock, and CreateDummy (Andrew Chow)
d6045d0ac6 scripted-diff: Replace WalletDatabase::Create* with CreateWalletDatabase (Andrew Chow)
45c08f8a7b Add Create*WalletDatabase functions (Andrew Chow)

Pull request description:

  Instead of having `Create`, `CreateMock`, and `CreateDummy` being static functions in `BerkeleyDatabase`, move these to standalone functions in `walletdb.cpp`. This prepares us for having different `WalletDatabase` classes.

  Part of #18971. This was originally one commit but has been split into 3 to make it (hopefully) easier to review.

ACKs for top commit:
  MarcoFalke:
    ACK da7a83c5ee 🎂
  ryanofsky:
    Code review ACK da7a83c5ee. Easy review, nice scripted-diff

Tree-SHA512: 1feb7cb3889168c555154bf3701a49095fd6b8cab911d44b7f7efbf6fcee2280ccb3d4afec8a83755b39a592ecd13b90a318faa655c321f87bdabdf1e2312327
2020-06-18 16:29:21 -04:00
..
forms Merge #17597: qt: Fix height of QR-less ReceiveRequestDialog 2020-05-29 10:02:26 +02:00
locale qt: Translations update pre-branch 2020-04-01 12:49:15 +02:00
res qt: Make bitcoin.ico non-executable 2020-04-15 10:59:10 +00:00
test Merge #19310: wallet: BerkeleyDatabase make BerkeleyDatabase::Create, CreateMock, and CreateDummy non-static functions 2020-06-18 16:29:21 -04:00
addressbookpage.cpp Merge #17918: qt: Hide non PKHash-Addresses in signing address book 2020-05-29 10:23:08 +02:00
addressbookpage.h refactor: Use override for non-final overriders 2020-05-08 10:36:58 +03:00
addresstablemodel.cpp Merge #17918: qt: Hide non PKHash-Addresses in signing address book 2020-05-29 10:23:08 +02:00
addresstablemodel.h Merge #17918: qt: Hide non PKHash-Addresses in signing address book 2020-05-29 10:23:08 +02:00
askpassphrasedialog.cpp gui: Add close window shortcut 2020-02-05 07:13:01 +01:00
askpassphrasedialog.h refactor: Use override for non-final overriders 2020-05-08 10:36:58 +03:00
bantablemodel.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
bantablemodel.h refactor: Use override for non-final overriders 2020-05-08 10:36:58 +03:00
bitcoin.cpp Make GetWarnings() return bilingual_str 2020-06-10 15:01:20 +03:00
bitcoin.h scripted-diff: Bump copyright of files changed in 2020 2020-01-15 02:18:00 +07:00
bitcoin.qrc qt: Remove menu icons 2019-08-15 13:05:10 +02:00
bitcoin_locale.qrc qt: Translations update pre-branch 2020-04-01 12:49:15 +02:00
bitcoinaddressvalidator.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
bitcoinaddressvalidator.h refactor: Use override for non-final overriders 2020-05-08 10:36:58 +03:00
bitcoinamountfield.cpp scripted-diff: Make SeparatorStyle a scoped enum 2020-06-18 15:30:15 +03:00
bitcoinamountfield.h refactor: Use override for non-final overriders 2020-05-08 10:36:58 +03:00
bitcoingui.cpp Merge #18927: Pass bilingual_str argument to AbortNode() 2020-06-16 08:53:02 -04:00
bitcoingui.h gui: Add Close All Wallets action 2020-06-01 00:58:09 +01:00
bitcoinstrings.cpp qt: Periodical translations update 2020-03-16 10:51:11 +01:00
bitcoinunits.cpp scripted-diff: Make SeparatorStyle a scoped enum 2020-06-18 15:30:15 +03:00
bitcoinunits.h scripted-diff: Make SeparatorStyle a scoped enum 2020-06-18 15:30:15 +03:00
clientmodel.cpp Make GetWarnings() return bilingual_str 2020-06-10 15:01:20 +03:00
clientmodel.h BlockTip struct created and connected to notifyHeaderTip and notifyBlockTip signals. 2020-05-23 20:02:10 -03:00
coincontroldialog.cpp Remove unused variables 2020-06-16 15:14:55 -04:00
coincontroldialog.h Merge #18894: gui: Fix manual coin control with multiple wallets loaded 2020-05-13 10:15:32 +02:00
coincontroltreewidget.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
coincontroltreewidget.h refactor: Use override for non-final overriders 2020-05-08 10:36:58 +03:00
createwalletdialog.cpp Be able to create new wallets with DescriptorScriptPubKeyMans as backing 2020-04-23 13:59:48 -04:00
createwalletdialog.h Be able to create new wallets with DescriptorScriptPubKeyMans as backing 2020-04-23 13:59:48 -04:00
csvmodelwriter.cpp Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
csvmodelwriter.h scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
editaddressdialog.cpp gui: Add close window shortcut 2020-02-05 07:13:01 +01:00
editaddressdialog.h refactor: Use override for non-final overriders 2020-05-08 10:36:58 +03:00
guiconstants.h scripted-diff: Bump copyright of files changed in 2020 2020-01-15 02:18:00 +07:00
guiutil.cpp scripted-diff: Make SeparatorStyle a scoped enum 2020-06-18 15:30:15 +03:00
guiutil.h Merge #17956: gui: Disable unavailable context menu items in transactions tab 2020-05-29 10:29:14 +02:00
intro.cpp Merge #17453: gui: Fix intro dialog labels when the prune button is toggled 2020-01-27 18:15:45 +01:00
intro.h gui: Make Intro consistent with prune checkbox 2020-01-14 19:14:14 +02:00
macdockiconhandler.h Remove obj_c for macOS Dock icon menu 2018-11-04 02:42:18 +02:00
macdockiconhandler.mm qt: Replace objc_msgSend with native syntax 2019-08-31 12:25:34 +03:00
macnotificationhandler.h convert C-style (void) parameter lists to C++ style () 2018-09-13 10:36:41 -07:00
macnotificationhandler.mm scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
macos_appnap.h macOS: disable AppNap during sync 2018-11-01 18:22:06 +03:00
macos_appnap.mm macOS: disable AppNap during sync 2018-11-01 18:22:06 +03:00
main.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
Makefile
modaloverlay.cpp Merge #17968: qt: Ensure that ModalOverlay is resized properly 2020-05-29 10:30:36 +02:00
modaloverlay.h Merge #17968: qt: Ensure that ModalOverlay is resized properly 2020-05-29 10:30:36 +02:00
networkstyle.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
networkstyle.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
notificator.cpp Remove misplaced Q_UNUSED and others enhancements 2018-12-20 01:06:37 +02:00
notificator.h Remove misplaced Q_UNUSED and others enhancements 2018-12-20 01:06:37 +02:00
openuridialog.cpp gui: Add close window shortcut 2020-02-05 07:13:01 +01:00
openuridialog.h refactor: Use override for non-final overriders 2020-05-08 10:36:58 +03:00
optionsdialog.cpp gui: Add close window shortcut 2020-02-05 07:13:01 +01:00
optionsdialog.h refactor: Use override for non-final overriders 2020-05-08 10:36:58 +03:00
optionsmodel.cpp Replace std::to_string with locale-independent alternative 2020-03-14 12:23:01 -07:00
optionsmodel.h refactor: Use override for non-final overriders 2020-05-08 10:36:58 +03:00
overviewpage.cpp scripted-diff: Make SeparatorStyle a scoped enum 2020-06-18 15:30:15 +03:00
overviewpage.h qt: Add privacy feature to Overview page 2020-05-27 11:55:44 +03:00
paymentserver.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
paymentserver.h refactor: Use override for non-final overriders 2020-05-08 10:36:58 +03:00
peertablemodel.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
peertablemodel.h refactor: Use override for non-final overriders 2020-05-08 10:36:58 +03:00
platformstyle.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
platformstyle.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
qrimagewidget.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
qrimagewidget.h refactor: Use override for non-final overriders 2020-05-08 10:36:58 +03:00
qvalidatedlineedit.cpp Replace remaining 0 with nullptr in Qt code 2019-01-13 03:25:14 -08:00
qvalidatedlineedit.h refactor: Use override for non-final overriders 2020-05-08 10:36:58 +03:00
qvaluecombobox.cpp qt: Use new Qt5 connect syntax 2018-08-21 09:43:54 +01:00
qvaluecombobox.h scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
README.md Remove BIP70 Support 2019-10-24 16:01:43 -04:00
receivecoinsdialog.cpp Return error when no ScriptPubKeyMan is available for specified type 2020-04-23 13:59:48 -04:00
receivecoinsdialog.h refactor: Use override for non-final overriders 2020-05-08 10:36:58 +03:00
receiverequestdialog.cpp qt: Rename slot to updateDisplayUnit() 2020-05-05 05:57:08 +03:00
receiverequestdialog.h qt: Rename slot to updateDisplayUnit() 2020-05-05 05:57:08 +03:00
recentrequeststablemodel.cpp scripted-diff: Make SeparatorStyle a scoped enum 2020-06-18 15:30:15 +03:00
recentrequeststablemodel.h Convert Qt to new serialization 2020-05-20 10:16:41 -07:00
rpcconsole.cpp walletdb: Move BDB specific things into bdb.{cpp/h} 2020-06-15 20:41:05 -04:00
rpcconsole.h refactor: Use override for non-final overriders 2020-05-08 10:36:58 +03:00
sendcoinsdialog.cpp gui: Fix manual coin control with multiple wallets loaded 2020-05-05 23:56:21 +01:00
sendcoinsdialog.h Merge #18894: gui: Fix manual coin control with multiple wallets loaded 2020-05-13 10:15:32 +02:00
sendcoinsentry.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
sendcoinsentry.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
sendcoinsrecipient.h Convert Qt to new serialization 2020-05-20 10:16:41 -07:00
signverifymessagedialog.cpp Merge #17918: qt: Hide non PKHash-Addresses in signing address book 2020-05-29 10:23:08 +02:00
signverifymessagedialog.h refactor: Use override for non-final overriders 2020-05-08 10:36:58 +03:00
splashscreen.cpp Merge #15768: gui: Add close window shortcut 2020-05-04 11:53:34 +02:00
splashscreen.h refactor: Use override for non-final overriders 2020-05-08 10:36:58 +03:00
trafficgraphwidget.cpp Add missing QPainterPath include 2020-05-28 14:56:47 -04:00
trafficgraphwidget.h refactor: Use override for non-final overriders 2020-05-08 10:36:58 +03:00
transactiondesc.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
transactiondesc.h Remove unused adjustedTime parameter 2018-10-28 09:04:10 +02:00
transactiondescdialog.cpp gui: Add close window shortcut 2020-02-05 07:13:01 +01:00
transactiondescdialog.h scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
transactionfilterproxy.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
transactionfilterproxy.h refactor: Use override for non-final overriders 2020-05-08 10:36:58 +03:00
transactionrecord.cpp Remove unused variables 2020-06-16 15:14:55 -04:00
transactionrecord.h Added best block hash to the NotifyHeaderTip and NotifyBlockTip signals. 2020-05-23 20:02:04 -03:00
transactiontablemodel.cpp scripted-diff: Make SeparatorStyle a scoped enum 2020-06-18 15:30:15 +03:00
transactiontablemodel.h scripted-diff: Make SeparatorStyle a scoped enum 2020-06-18 15:30:15 +03:00
transactionview.cpp Merge #17956: gui: Disable unavailable context menu items in transactions tab 2020-05-29 10:29:14 +02:00
transactionview.h Merge #17956: gui: Disable unavailable context menu items in transactions tab 2020-05-29 10:29:14 +02:00
utilitydialog.cpp Merge #15768: gui: Add close window shortcut 2020-05-04 11:53:34 +02:00
utilitydialog.h refactor: Use override for non-final overriders 2020-05-08 10:36:58 +03:00
walletcontroller.cpp Merge #18927: Pass bilingual_str argument to AbortNode() 2020-06-16 08:53:02 -04:00
walletcontroller.h gui: Add closeAllWallets to WalletController 2020-06-01 00:54:00 +01:00
walletframe.cpp qt: Add privacy feature to Overview page 2020-05-27 11:55:44 +03:00
walletframe.h [gui] load PSBT 2020-03-27 14:59:19 +01:00
walletmodel.cpp Merge #17993: gui: Balance/TxStatus polling update based on last block hash. 2020-05-29 11:01:09 +02:00
walletmodel.h Merge #17993: gui: Balance/TxStatus polling update based on last block hash. 2020-05-29 11:01:09 +02:00
walletmodeltransaction.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
walletmodeltransaction.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
walletview.cpp Merge #19072: doc: Expand section on Getting Started 2020-06-01 15:38:57 +08:00
walletview.h qt: Add privacy feature to Overview page 2020-05-27 11:55:44 +03:00
winshutdownmonitor.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
winshutdownmonitor.h Update copyright headers to 2018 2018-07-27 07:15:02 -04:00

README.md

This directory contains the BitcoinQT graphical user interface (GUI). It uses the cross-platform framework Qt.

The current precise version for Qt 5 is specified in qt.mk.

Compile and run

See build instructions (macOS, Windows, Unix, etc).

To run:

./src/qt/bitcoin-qt

Files and directories

forms

Contains Designer UI files. They are created with Qt Creator, but can be edited using any text editor.

locale

Contains translations. They are periodically updated. The process is described here.

res

Resources such as the icon.

test

Tests.

bitcoingui.(h/cpp)

Represents the main window of the Bitcoin UI.

*model.(h/cpp)

The model. When it has a corresponding controller, it generally inherits from QAbstractTableModel. Models that are used by controllers as helpers inherit from other Qt classes like QValidator.

ClientModel is used by the main application bitcoingui and several models like peertablemodel.

*page.(h/cpp)

A controller. :NAMEpage.cpp generally includes :NAMEmodel.h and forms/:NAME.page.ui with a similar :NAME.

*dialog.(h/cpp)

Various dialogs, e.g. to open a URL. Inherit from QDialog.

paymentserver.(h/cpp)

Used to process BIP21 payment URI requests. Also handles URI based application switching (e.g. when following a bitcoin:... link from a browser).

walletview.(h/cpp)

Represents the view to a single wallet.

Other .h/cpp files

  • UI elements like BitcoinAmountField, which inherit from QWidget.
  • bitcoinstrings.cpp: automatically generated
  • bitcoinunits.(h/cpp): BTC / mBTC / etc handling
  • callback.h
  • guiconstants.h: UI colors, app name, etc
  • guiutil.h: several helper functions
  • macdockiconhandler.(h/mm): macOS dock icon handler
  • macnotificationhandler.(h/mm): display notifications in macOS

Contribute

See CONTRIBUTING.md for general guidelines. Specifically for Qt:

Using Qt Creator as IDE

You can use Qt Creator as an IDE. This is especially useful if you want to change the UI layout.

Download and install the community edition of Qt Creator. Uncheck everything except Qt Creator during the installation process.

Instructions for macOS:

  1. Make sure you installed everything through Homebrew mentioned in the macOS build instructions
  2. Use ./configure with the --enable-debug flag
  3. In Qt Creator do "New Project" -> Import Project -> Import Existing Project
  4. Enter "bitcoin-qt" as project name, enter src/qt as location
  5. Leave the file selection as it is
  6. Confirm the "summary page"
  7. In the "Projects" tab select "Manage Kits..."
  8. Select the default "Desktop" kit and select "Clang (x86 64bit in /usr/bin)" as compiler
  9. Select LLDB as debugger (you might need to set the path to your installation)
  10. Start debugging with Qt Creator (you might need to the executable to "bitcoin-qt" under "Run", which is where you can also add command line arguments)