0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-04 10:07:27 -05:00
bitcoin-bitcoin-core/src/test
Pieter Wuille abdfd2d0e3
Merge #19219: Replace automatic bans with discouragement filter
2ad58381ff Clean up separated ban/discourage interface (Pieter Wuille)
b691f2df5f Replace automatic bans with discouragement filter (Pieter Wuille)

Pull request description:

  This patch improves performance and resource usage around IP addresses that are banned for misbehavior. They're already not actually banned since #14929, as connections from them are still allowed, but they are preferred for eviction if the inbound connection slots are full.

  Stop treating these like manually banned IP ranges, and instead just keep them in a rolling Bloom filter of misbehaving nodes, which isn't persisted to disk or exposed through the ban framework. The effect remains the same: preferred for eviction, avoided for outgoing connections, and not relayed to other peers.

  Also change the name of this mechanism to "discouraged" to better reflect reality.

ACKs for top commit:
  naumenkogs:
    utACK 2ad58381ff
  amitiuttarwar:
    code review ACK 2ad58381ff
  jonatack:
    ACK 2ad5838 per changes since last review `git range-diff 3276c14 1f7e0ca 2ad5838`
  jnewbery:
    Code review ACK 2ad58381ff

Tree-SHA512: 5dedef401d9cbfa026812651303e6286223563dbeed7a10766ed536ac9e3f29ed4bd0df29cc6deadceeb35cbe9f066346add14ef0833958ca9f93d123fe7aab5
2020-07-07 11:20:34 -07:00
..
data Limit decimal range of numbers ParseScript accepts 2020-03-27 15:51:05 +09:00
fuzz Merge #19219: Replace automatic bans with discouragement filter 2020-07-07 11:20:34 -07:00
util Merge #19277: util: Add Assert identity function 2020-07-04 08:44:45 -04:00
addrman_tests.cpp test: Move boost/stdlib includes last 2020-04-17 06:36:04 -04:00
allocator_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
amount_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
arith_uint256_tests.cpp test: Move boost/stdlib includes last 2020-04-17 06:36:04 -04:00
base32_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
base58_tests.cpp tests: Add tests for base58-decoding of std::string:s containing non-base58 characters 2019-12-12 11:01:56 +00:00
base64_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
bech32_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
bip32_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
blockchain_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
blockencodings_tests.cpp Convert blockencodings_tests to new serialization 2020-03-30 16:10:30 -07:00
blockfilter_index_tests.cpp scripted-diff: Replace EnsureChainman with Assert in unit tests 2020-06-15 07:39:26 -04:00
blockfilter_tests.cpp test: Fix outstanding -Wsign-compare errors 2020-05-08 11:18:43 -07:00
bloom_tests.cpp test: Fix outstanding -Wsign-compare errors 2020-05-08 11:18:43 -07:00
bswap_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
checkqueue_tests.cpp refactor: Specify boost/thread/thread.hpp explicitly 2020-06-04 10:05:54 -04:00
coins_tests.cpp refactor: Replace HexStr(o.begin(), o.end()) with HexStr(o) 2020-06-24 18:41:45 +02:00
compilerbug_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
compress_tests.cpp test: Fix outstanding -Wsign-compare errors 2020-05-08 11:18:43 -07:00
crypto_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
cuckoocache_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
dbwrapper_tests.cpp Merge #18317: Serialization improvements step 6 (all except wallet/gui) 2020-05-20 07:30:29 -04:00
denialofservice_tests.cpp Clean up separated ban/discourage interface 2020-07-03 20:43:55 -07:00
descriptor_tests.cpp refactor: Replace HexStr(o.begin(), o.end()) with HexStr(o) 2020-06-24 18:41:45 +02:00
flatfile_tests.cpp test: Fix outstanding -Wsign-compare errors 2020-05-08 11:18:43 -07:00
fs_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
getarg_tests.cpp scripted-diff: replace gArgs with argsman 2020-05-28 06:22:19 -07:00
hash_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
interfaces_tests.cpp test: Verify findCommonAncestor always initializes outputs 2020-04-15 17:07:44 -04:00
key_io_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
key_tests.cpp Add tests for CPubKey serialization/unserialization 2020-06-17 14:59:36 +03:00
limitedmap_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
logging_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
main.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
Makefile
mempool_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
merkle_tests.cpp fix Typo: "merkelRoot" -> "merkleRoot" 2019-11-12 00:56:05 +08:00
merkleblock_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
miner_tests.cpp scripted-diff: Replace EnsureChainman with Assert in unit tests 2020-06-15 07:39:26 -04:00
multisig_tests.cpp scripted-diff: TxoutType C++11 scoped enum class 2020-06-21 06:41:55 -04:00
net_tests.cpp test: Move boost/stdlib includes last 2020-04-17 06:36:04 -04:00
netbase_tests.cpp test: add two edge case tests for CSubNet 2020-06-22 15:30:31 +02:00
pmt_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
policy_fee_tests.cpp test: Add FeeFilterRounder test 2020-06-19 09:26:59 -04:00
policyestimator_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
pow_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
prevector_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
raii_event_tests.cpp Merge #16564: test: Always define the raii_event_tests test suite 2020-05-31 17:55:55 -04:00
random_tests.cpp Merge #18781: Add templated GetRandDuration<> 2020-05-15 08:58:49 -04:00
README.md doc: Explain new test logging 2020-03-31 17:11:47 -04:00
ref_tests.cpp Add util::Ref class as temporary alternative for c++17 std::any 2020-05-13 16:20:13 -04:00
reverselock_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
rpc_tests.cpp refactor: Pass NodeContext to RPC and REST methods through util::Ref 2020-05-13 16:20:13 -04:00
sanity_tests.cpp test: fix message for ECC_InitSanityCheck test 2020-04-30 16:57:46 +08:00
scheduler_tests.cpp Merge #19090: refactor: Misc scheduler cleanups 2020-06-25 09:24:58 -04:00
script_p2sh_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
script_standard_tests.cpp scripted-diff: TxoutType C++11 scoped enum class 2020-06-21 06:41:55 -04:00
script_tests.cpp refactor: Replace const char* to std::string 2020-05-22 01:40:31 +09:00
scriptnum10.h scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
scriptnum_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
serialize_tests.cpp Merge #18317: Serialization improvements step 6 (all except wallet/gui) 2020-05-20 07:30:29 -04:00
settings_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
sighash_tests.cpp refactor: Replace HexStr(o.begin(), o.end()) with HexStr(o) 2020-06-24 18:41:45 +02:00
sigopcount_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
skiplist_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
streams_tests.cpp test: Fix outstanding -Wsign-compare errors 2020-05-08 11:18:43 -07:00
sync_tests.cpp scripted-diff: Bump copyright of files changed in 2020 2020-01-15 02:18:00 +07:00
timedata_tests.cpp Make GetWarnings() return bilingual_str 2020-06-10 15:01:20 +03:00
torcontrol_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
transaction_tests.cpp scripted-diff: TxoutType C++11 scoped enum class 2020-06-21 06:41:55 -04:00
txindex_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
txvalidation_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
txvalidationcache_tests.cpp Merge #18675: tests: Don't initialize PrecomputedTransactionData in txvalidationcache tests 2020-04-19 06:18:21 -04:00
uint256_tests.cpp test: Move boost/stdlib includes last 2020-04-17 06:36:04 -04:00
util_tests.cpp Simplify usage of Span in several places 2020-05-12 14:19:40 -07:00
util_threadnames_tests.cpp test: Set -logthreadnames in unit tests 2020-05-21 08:13:23 -04:00
validation_block_tests.cpp scripted-diff: Replace EnsureChainman with Assert in unit tests 2020-06-15 07:39:26 -04:00
validation_chainstatemanager_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
validation_flush_tests.cpp test: Fix outstanding -Wsign-compare errors 2020-05-08 11:18:43 -07:00
validation_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
validationinterface_tests.cpp test: Remove const to work around compiler error on xenial 2020-05-14 18:40:57 +02:00
versionbits_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00

Unit tests

The sources in this directory are unit test cases. Boost includes a unit testing framework, and since Bitcoin Core already uses Boost, it makes sense to simply use this framework rather than require developers to configure some other framework (we want as few impediments to creating unit tests as possible).

The build system is set up to compile an executable called test_bitcoin that runs all of the unit tests. The main source file for the test library is found in util/setup_common.cpp.

Compiling/running unit tests

Unit tests will be automatically compiled if dependencies were met in ./configure and tests weren't explicitly disabled.

After configuring, they can be run with make check.

To run the unit tests manually, launch src/test/test_bitcoin. To recompile after a test file was modified, run make and then run the test again. If you modify a non-test file, use make -C src/test to recompile only what's needed to run the unit tests.

To add more unit tests, add BOOST_AUTO_TEST_CASE functions to the existing .cpp files in the test/ directory or add new .cpp files that implement new BOOST_AUTO_TEST_SUITE sections.

To run the GUI unit tests manually, launch src/qt/test/test_bitcoin-qt

To add more GUI unit tests, add them to the src/qt/test/ directory and the src/qt/test/test_main.cpp file.

Running individual tests

test_bitcoin has some built-in command-line arguments; for example, to run just the getarg_tests verbosely:

test_bitcoin --log_level=all --run_test=getarg_tests -- DEBUG_LOG_OUT

log_level controls the verbosity of the test framework, which logs when a test case is entered, for example. The DEBUG_LOG_OUT after the two dashes redirects the debug log, which would normally go to a file in the test datadir (BasicTestingSetup::m_path_root), to the standard terminal output.

... or to run just the doubledash test:

test_bitcoin --run_test=getarg_tests/doubledash

Run test_bitcoin --help for the full list.

Adding test cases

To add a new unit test file to our test suite you need to add the file to src/Makefile.test.include. The pattern is to create one test file for each class or source file for which you want to create unit tests. The file naming convention is <source_filename>_tests.cpp and such files should wrap their tests in a test suite called <source_filename>_tests. For an example of this pattern, see uint256_tests.cpp.

Logging and debugging in unit tests

make check will write to a log file foo_tests.cpp.log and display this file on failure. For running individual tests verbosely, refer to the section above.

To write to logs from unit tests you need to use specific message methods provided by Boost. The simplest is BOOST_TEST_MESSAGE.

For debugging you can launch the test_bitcoin executable with gdbor lldb and start debugging, just like you would with any other program:

gdb src/test/test_bitcoin