MarcoFalke dbdc83ae01 Merge bitcoin/bitcoin#24909: refactor: Move and rename pindexBestHeader, fHavePruned ... f0a2fb3c5d scripted-diff: Rename pindexBestHeader, fHavePruned (Carl Dong) a401402125 Clear fHavePruned in BlockManager::Unload() (Carl Dong) 3308ecd3fc move-mostly: Make fHavePruned a BlockMan member (Carl Dong) c96524113c Clear pindexBestHeader in ChainstateManager::Unload() (Carl Dong) 73eedaaacc style-only: Miscellaneous whitespace changes (Carl Dong) 0d567daf23 move-mostly: Make pindexBestHeader a ChainMan member (Carl Dong) 5d670173a3 validation: Load pindexBestHeader in ChainMan (Carl Dong) Pull request description: Split off from #22564 per Marco's suggestion: https://github.com/bitcoin/bitcoin/pull/22564#issuecomment-1100011503 This is basically the move-mostly parts of #22564. The overall intent is to move mutable globals manually reset by `::UnloadBlockIndex` into appropriate structs such that they are cleared at the appropriate times. Please read #22564's description for more rationale. In summary , this PR moves: 1. `pindexBestHeader` -> `ChainstateManager::m_best_header` 2. `fHavePruned` -> `BlockManager::m_have_pruned` ACKs for top commit: ajtowns: ACK f0a2fb3c5d -- code review only MarcoFalke: kirby ACK f0a2fb3c5d 😋 Tree-SHA512: 8d161701af81af1ff42da1b22a6bef2f8626e8642146bc9c3b27f3a7cd24f4d691910a2392b188ae058fec0611a17304dd73f60da695f53832d327f73d2fc963		2022-04-20 12:13:25 +02:00
..
data	Add deserialize + CheckBlock benchmarks, and a full block hex	2016-11-09 11:27:59 -08:00
.gitignore	Ignore bench_bitcoin binary.	2015-10-06 17:46:12 +02:00
addrman.cpp	refactor: fix clang-tidy named args usage	2022-04-04 09:01:19 +01:00
base58.cpp	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
bech32.cpp	scripted-diff: Bump copyright headers	2021-12-30 19:36:57 +02:00
bench.cpp	bench: Represents paths with fs::path instead of std::string	2022-02-04 09:33:41 -05:00
bench.h	bench: Represents paths with fs::path instead of std::string	2022-02-04 09:33:41 -05:00
bench_bitcoin.cpp	Use GetPathArg where possible	2022-03-02 12:09:27 +01:00
block_assemble.cpp	scripted-diff: Bump copyright headers	2021-12-30 19:36:57 +02:00
ccoins_caching.cpp	scripted-diff: Bump copyright headers	2021-12-30 19:36:57 +02:00
chacha20.cpp	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
chacha_poly_aead.cpp	Do not run functions with necessary side-effects in assert()	2020-12-06 00:48:09 +00:00
checkblock.cpp	Use spans of std::byte in serialize	2022-01-02 11:40:31 +01:00
checkqueue.cpp	bench: Use CCheckQueue local thread pool	2020-09-24 06:55:34 +03:00
coin_selection.cpp	bench: fix incorrect named args in coin_selection bench	2022-03-25 21:27:39 +00:00
crypto_hash.cpp	scripted-diff: Bump copyright headers	2021-12-30 19:36:57 +02:00
data.cpp	scripted-diff: Bump copyright headers	2021-12-30 19:36:57 +02:00
data.h	bench: Move generated data to a dedicated translation unit	2019-07-02 18:11:15 +01:00
duplicate_inputs.cpp	scripted-diff: Bump copyright headers	2021-12-30 19:36:57 +02:00
examples.cpp	bench: Avoid deprecated use of volatile +=	2022-02-17 17:25:57 +01:00
gcs_filter.cpp	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
hashpadding.cpp	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
lockedpool.cpp	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
logging.cpp	bench: Add logging benchmark	2021-12-15 14:33:59 +01:00
mempool_eviction.cpp	scripted-diff: Bump copyright headers	2021-12-30 19:36:57 +02:00
mempool_stress.cpp	refactor: fix clang-tidy named args usage	2022-04-04 09:01:19 +01:00
merkle_root.cpp	Replace current benchmarking framework with nanobench	2020-06-13 12:24:18 +02:00
nanobench.cpp	Replace current benchmarking framework with nanobench	2020-06-13 12:24:18 +02:00
nanobench.h	bench: update nanobench from 4.3.4 to 4.3.6	2021-09-21 11:46:01 +02:00
peer_eviction.cpp	scripted-diff: Rename touched member variables	2021-12-13 13:32:08 +01:00
poly1305.cpp	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
prevector.cpp	scripted-diff: Bump copyright headers	2021-12-30 19:36:57 +02:00
rollingbloom.cpp	refactor: Remove deduplication of data in rollingbloom bench	2022-04-06 13:57:31 +01:00
rpc_blockchain.cpp	move-mostly: Make fHavePruned a BlockMan member	2022-04-19 14:34:56 -04:00
rpc_mempool.cpp	refactor: fix clang-tidy named args usage	2022-04-04 09:01:19 +01:00
util_time.cpp	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
verify_script.cpp	scripted-diff: Bump copyright headers	2021-12-30 19:36:57 +02:00
wallet_balance.cpp	refactor: fix clang-tidy named args usage	2022-04-04 09:01:19 +01:00
wallet_loading.cpp	bench: Add a benchmark for wallet loading	2022-04-18 17:02:57 -04:00