mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-02-06 10:18:44 -05:00
8bb40d5f56
fa13e1b0c5build: Add option --enable-danger-fuzz-link-all (MarcoFalke)44444ba759fuzz: Link all targets once (MarcoFalke) Pull request description: Currently the linker is invoked more than 150 times when compiling with `--enable-fuzz`. This is problematic for several reasons: * It wastes disk space north of 20 GB, as all libraries and sanitizers are linked more than 150 times * It wastes CPU time, as the link step can practically not be cached (similar to ccache for object files) * It makes it a blocker to compile the fuzz tests by default for non-fuzz builds #19388, for the aforementioned reasons * The build file is several thousand lines of code, without doing anything meaningful except listing each fuzz target in a highly verbose manner * It makes writing new fuzz tests unnecessarily hard, as build system knowledge is required; Compare that to boost unit tests, which can be added by simply editing an existing cpp file * It encourages fuzz tests that re-use the `buffer` or assume the `buffer` to be concatenations of seeds, which increases complexity of seeds and complexity for the fuzz engine to explore; Thus reducing the effectiveness of the affected fuzz targets Fixes #20088 ACKs for top commit: practicalswift: Tested ACKfa13e1b0c5sipa: ACKfa13e1b0c5. Reviewed the code changes, and tested the 3 different test_runner.py modes (run once, merge, generate). I also tested building with the new --enable-danger-fuzz-link-all Tree-SHA512: 962ab33269ebd51810924c51266ecc62edd6ddf2fcd9a8c359ed906766f58c3f73c223f8d3cc49f2c60f0053f65e8bdd86ce9c19e673f8c2b3cd676e913f2642
48 lines
1.6 KiB
C++
48 lines
1.6 KiB
C++
// Copyright (c) 2020 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#include <policy/rbf.h>
|
|
#include <primitives/transaction.h>
|
|
#include <sync.h>
|
|
#include <test/fuzz/FuzzedDataProvider.h>
|
|
#include <test/fuzz/fuzz.h>
|
|
#include <test/fuzz/util.h>
|
|
#include <txmempool.h>
|
|
|
|
#include <cstdint>
|
|
#include <optional>
|
|
#include <string>
|
|
#include <vector>
|
|
|
|
FUZZ_TARGET(rbf)
|
|
{
|
|
FuzzedDataProvider fuzzed_data_provider(buffer.data(), buffer.size());
|
|
SetMockTime(ConsumeTime(fuzzed_data_provider));
|
|
std::optional<CMutableTransaction> mtx = ConsumeDeserializable<CMutableTransaction>(fuzzed_data_provider);
|
|
if (!mtx) {
|
|
return;
|
|
}
|
|
CTxMemPool pool;
|
|
while (fuzzed_data_provider.ConsumeBool()) {
|
|
const std::optional<CMutableTransaction> another_mtx = ConsumeDeserializable<CMutableTransaction>(fuzzed_data_provider);
|
|
if (!another_mtx) {
|
|
break;
|
|
}
|
|
const CTransaction another_tx{*another_mtx};
|
|
if (fuzzed_data_provider.ConsumeBool() && !mtx->vin.empty()) {
|
|
mtx->vin[0].prevout = COutPoint{another_tx.GetHash(), 0};
|
|
}
|
|
LOCK2(cs_main, pool.cs);
|
|
pool.addUnchecked(ConsumeTxMemPoolEntry(fuzzed_data_provider, another_tx));
|
|
}
|
|
const CTransaction tx{*mtx};
|
|
if (fuzzed_data_provider.ConsumeBool()) {
|
|
LOCK2(cs_main, pool.cs);
|
|
pool.addUnchecked(ConsumeTxMemPoolEntry(fuzzed_data_provider, tx));
|
|
}
|
|
{
|
|
LOCK(pool.cs);
|
|
(void)IsRBFOptIn(tx, pool);
|
|
}
|
|
}
|