Andrew Chow b7702bd546 Merge bitcoin/bitcoin#25943: rpc: Add a parameter to sendrawtransaction which sets a maximum value for unspendable outputs. ... 7013da07fb Add release note for PR#25943 (David Gumberg) 04f270b435 Add test for unspendable transactions and parameter 'maxburnamount' to sendrawtransaction. (David Gumberg) Pull request description: This PR adds a user configurable, zero by default parameter — `maxburnamount` — to `sendrawtransaction`. This PR makes bitcoin core reject transactions that contain unspendable outputs which exceed `maxburnamount`. closes #25899. As a result of this PR, `sendrawtransaction` will by default block 3 kinds of transactions: 1. Those that begin with `OP_RETURN` - (datacarriers) 2. Those whose lengths exceed the script limit. 3. Those that contain invalid opcodes. The user is able to configure a `maxburnamount` that will override this check and allow a user to send a potentially unspendable output into the mempool. I see two legitimate use cases for this override: 1. Users that deliberately use `OP_RETURN` for datacarrier transactions that embed data into the blockchain. 2. Users that refuse to update, or are unable to update their bitcoin core client would be able to make use of new opcodes that their client doesn't know about. ACKs for top commit: glozow: reACK 7013da07fb achow101: re-ACK 7013da07fb Tree-SHA512: f786a796fb71a587d30313c96717fdf47e1106ab4ee0c16d713695e6c31ed6f6732dff6cbc91ca9841d66232166eb058f96028028e75c1507324426309ee4525		2023-02-23 13:57:38 -05:00
..
bench	Merge bitcoin/bitcoin#26889: refactor: wallet, remove global 'ArgsManager' dependency	2023-02-17 12:47:52 -05:00
common	Use DataStream where possible	2023-01-26 10:44:05 +01:00
compat	compat: use STDIN_FILENO over 0	2023-01-04 12:00:25 +00:00
config
consensus	Merge bitcoin/bitcoin#26345: refactor: modernize the implementation of uint256.*	2023-02-06 13:56:51 -05:00
crc32c	Update crc32c subtree to latest upstream master	2022-08-13 13:55:38 +01:00
crypto	Merge bitcoin/bitcoin#26153: Reduce wasted pseudorandom bytes in ChaCha20 + various improvements	2023-02-15 14:58:47 +00:00
index	refactor, dbwrapper: Add DBParams and DBOptions structs	2023-02-10 04:39:11 -04:00
init	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
interfaces	Remove reindex special case from the progress bar label	2023-02-07 11:02:01 +01:00
ipc	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
kernel	kernel: add missing include	2023-02-22 15:46:21 +00:00
leveldb	Update leveldb-subtree subtree to latest upstream	2022-09-29 16:43:30 +01:00
logging	Use steady clock for logging timer	2023-01-31 18:48:50 +01:00
minisketch	Update minisketch subtree to latest upstream	2022-10-23 15:03:04 +01:00
node	Merge bitcoin/bitcoin#25574: validation: Improve error handling when VerifyDB dosn't finish successfully	2023-02-22 14:19:44 -05:00
policy	clang-tidy: Fix modernize-use-default-member-init in headers	2023-01-31 11:50:10 +00:00
primitives	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
qt	Detailed error message for passphrases with null chars	2023-02-21 14:53:54 -05:00
rpc	Merge bitcoin/bitcoin#25943: rpc: Add a parameter to sendrawtransaction which sets a maximum value for unspendable outputs.	2023-02-23 13:57:38 -05:00
script	BIP341 txdata cannot be precomputed without spent outputs	2023-02-17 16:29:49 -05:00
secp256k1	Update secp256k1 subtree to upstream libsecp256k1 version 0.2.0	2022-12-12 23:40:36 -05:00
support	Pass all characters to SecureString including nulls	2023-02-21 14:40:59 -05:00
test	Merge bitcoin/bitcoin#25574: validation: Improve error handling when VerifyDB dosn't finish successfully	2023-02-22 14:19:44 -05:00
univalue	clang-tidy: Fix modernize-use-default-member-init in headers	2023-01-31 11:50:10 +00:00
util	Merge bitcoin/bitcoin#25943: rpc: Add a parameter to sendrawtransaction which sets a maximum value for unspendable outputs.	2023-02-23 13:57:38 -05:00
wallet	Merge bitcoin/bitcoin#27068: wallet: SecureString to allow null characters	2023-02-22 13:02:16 -05:00
zmq	clang-tidy: Fix modernize-use-default-member-init in headers	2023-01-31 11:50:10 +00:00
.bear-tidy-config
.clang-format
.clang-tidy	Fix clang-tidy readability-const-return-type violations	2023-02-01 11:33:35 +01:00
addrdb.cpp	Merge bitcoin/bitcoin#26847: p2p: track AddrMan totals by network and table, improve precision of adding fixed seeds	2023-01-31 16:08:44 -05:00
addrdb.h
addrman.cpp	Merge bitcoin/bitcoin#25619: net: avoid overriding non-virtual ToString() in CService and use better naming	2023-02-17 13:34:40 -05:00
addrman.h	addrman: Use std::nullopt instead of {}	2023-02-01 10:18:08 -05:00
addrman_impl.h	addrman, refactor: combine two size functions	2023-01-26 18:11:13 -05:00
arith_uint256.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
arith_uint256.h	Fix clang-tidy readability-const-return-type violations	2023-02-01 11:33:35 +01:00
attributes.h
banman.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
banman.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
base58.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
base58.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
bech32.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
bech32.h
bitcoin-chainstate.cpp	refactor, validation: Add ChainstateManagerOpts db options	2023-02-10 04:39:11 -04:00
bitcoin-cli-res.rc
bitcoin-cli.cpp	cli: include local ("unreachable") peers in -netinfo table	2023-02-02 13:14:48 -05:00
bitcoin-tx-res.rc
bitcoin-tx.cpp	Merge bitcoin/bitcoin#26691: Update secp256k1 subtree to libsecp256k1 version 0.2.0	2023-01-13 09:40:57 +00:00
bitcoin-util-res.rc
bitcoin-util.cpp	Use DataStream where possible	2023-01-26 10:44:05 +01:00
bitcoin-wallet-res.rc
bitcoin-wallet.cpp	Merge bitcoin/bitcoin#26691: Update secp256k1 subtree to libsecp256k1 version 0.2.0	2023-01-13 09:40:57 +00:00
bitcoind-res.rc
bitcoind.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
blockencodings.cpp	Use DataStream where possible	2023-01-26 10:44:05 +01:00
blockencodings.h	script: remove out-of-date snprintf TODO	2023-02-15 14:42:28 -08:00
blockfilter.cpp	refactor: use Hash helper for double-SHA256 calculations	2023-01-31 19:34:35 +01:00
blockfilter.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
chain.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
chain.h	refactor: add kernel/cs_main.*	2023-01-05 09:05:14 +00:00
chainparams.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
chainparams.h
chainparamsbase.cpp
chainparamsbase.h
chainparamsseeds.h	Merge bitcoin/bitcoin#25853: net: update testnet torv3 hardcoded seeds for 24.x	2022-09-09 10:07:39 +02:00
checkqueue.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
clientversion.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
clientversion.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
coins.cpp	Add deterministic mode to CCoinsViewCache	2023-02-02 09:00:15 -05:00
coins.h	Add deterministic mode to CCoinsViewCache	2023-02-02 09:00:15 -05:00
compressor.cpp
compressor.h
core_io.h	rpc: decode Miniscript descriptor when possible in decodescript	2023-02-03 18:15:42 +01:00
core_memusage.h
core_read.cpp	Use DataStream where possible	2023-01-26 10:44:05 +01:00
core_write.cpp	rpc: decode Miniscript descriptor when possible in decodescript	2023-02-03 18:15:42 +01:00
cuckoocache.h	clang-tidy: Fix modernize-use-default-member-init in headers	2023-01-31 11:50:10 +00:00
dbwrapper.cpp	refactor, dbwrapper: Add DBParams and DBOptions structs	2023-02-10 04:39:11 -04:00
dbwrapper.h	refactor, dbwrapper: Add DBParams and DBOptions structs	2023-02-10 04:39:11 -04:00
deploymentinfo.cpp
deploymentinfo.h
deploymentstatus.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
deploymentstatus.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
dummywallet.cpp
external_signer.cpp	Fix clang-tidy readability-const-return-type violations	2023-02-01 11:33:35 +01:00
external_signer.h	Fix clang-tidy readability-const-return-type violations	2023-02-01 11:33:35 +01:00
flatfile.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
flatfile.h
fs.cpp	Merge bitcoin/bitcoin#25898: util: remove WSL 1 workaround in fs	2023-02-16 12:33:26 +00:00
fs.h	clang-tidy: Fix performance-move-const-arg in headers	2023-01-18 15:47:06 +00:00
hash.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
hash.h	Merge bitcoin/bitcoin#26649: refactor: Use AutoFile and HashVerifier (without ser-type and ser-version) where possible	2023-01-30 15:57:12 +00:00
headerssync.cpp	Move headerssync logging to BCLog::NET	2022-08-30 12:09:04 -04:00
headerssync.h	Track headers presync progress and log it	2022-08-29 08:10:35 -04:00
httprpc.cpp	Merge bitcoin/bitcoin#25619: net: avoid overriding non-virtual ToString() in CService and use better naming	2023-02-17 13:34:40 -05:00
httprpc.h
httpserver.cpp	Merge bitcoin/bitcoin#25619: net: avoid overriding non-virtual ToString() in CService and use better naming	2023-02-17 13:34:40 -05:00
httpserver.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
i2p.cpp	Merge bitcoin/bitcoin#26837: I2P network optimizations	2023-02-22 17:58:41 +00:00
i2p.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
indirectmap.h
init.cpp	Merge bitcoin/bitcoin#25574: validation: Improve error handling when VerifyDB dosn't finish successfully	2023-02-22 14:19:44 -05:00
init.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
key.cpp	refactor: use Hash helper for double-SHA256 calculations	2023-01-31 19:34:35 +01:00
key.h	clang-tidy: Fix modernize-use-default-member-init in headers	2023-01-31 11:50:10 +00:00
key_io.cpp
key_io.h
logging.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
logging.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
Makefile.am	refactor, txdb: Add CoinsViewOptions struct	2023-02-10 04:39:11 -04:00
Makefile.bench.include	Merge bitcoin/bitcoin#16981: Improve runtime performance of --reindex	2022-11-15 19:23:39 -05:00
Makefile.crc32c.include
Makefile.leveldb.include
Makefile.minisketch.include	build: Build minisketch test in make check, not in make	2022-07-21 10:42:09 +01:00
Makefile.qt.include	build: extract $(BOOST_CPPFLAGS) from $(BITCOIN_INCLUDES)	2022-09-13 17:15:17 +01:00
Makefile.qt_locale.include
Makefile.qttest.include	build: extract $(BOOST_CPPFLAGS) from $(BITCOIN_INCLUDES)	2022-09-13 17:15:17 +01:00
Makefile.test.include	Merge bitcoin/bitcoin#26153: Reduce wasted pseudorandom bytes in ChaCha20 + various improvements	2023-02-15 14:58:47 +00:00
Makefile.test_fuzz.include	[fuzz] Move ConsumeNetAddr to fuzz/util/net.h	2022-11-17 14:52:45 +00:00
Makefile.test_util.include	Merge bitcoin/bitcoin#26940: test: create random and coins utils, add amount helper, dedupe add_coin	2023-02-17 17:28:14 -05:00
Makefile.univalue.include
mapport.cpp	Merge bitcoin/bitcoin#25619: net: avoid overriding non-virtual ToString() in CService and use better naming	2023-02-17 13:34:40 -05:00
mapport.h	Remove configure-time setting of DEFAULT_UPNP	2023-01-28 15:24:13 +00:00
memusage.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
merkleblock.cpp
merkleblock.h
net.cpp	Merge bitcoin/bitcoin#26837: I2P network optimizations	2023-02-22 17:58:41 +00:00
net.h	Merge bitcoin/bitcoin#26837: I2P network optimizations	2023-02-22 17:58:41 +00:00
net_permissions.cpp
net_permissions.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
net_processing.cpp	Merge bitcoin/bitcoin#25619: net: avoid overriding non-virtual ToString() in CService and use better naming	2023-02-17 13:34:40 -05:00
net_processing.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
net_types.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
net_types.h
netaddress.cpp	Merge bitcoin/bitcoin#25619: net: avoid overriding non-virtual ToString() in CService and use better naming	2023-02-17 13:34:40 -05:00
netaddress.h	Merge bitcoin/bitcoin#25619: net: avoid overriding non-virtual ToString() in CService and use better naming	2023-02-17 13:34:40 -05:00
netbase.cpp	Merge bitcoin/bitcoin#25619: net: avoid overriding non-virtual ToString() in CService and use better naming	2023-02-17 13:34:40 -05:00
netbase.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
netgroup.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
netgroup.h
netmessagemaker.h
noui.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
noui.h
outputtype.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
outputtype.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
pow.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
pow.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
prevector.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
protocol.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
protocol.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
psbt.cpp	Merge bitcoin/bitcoin#24149: Signing support for Miniscript Descriptors	2023-02-16 10:01:33 +00:00
psbt.h	Merge bitcoin/bitcoin#26997: psbt: s/transcation/transaction/	2023-02-16 09:39:50 +00:00
pubkey.cpp	Merge bitcoin/bitcoin#26691: Update secp256k1 subtree to libsecp256k1 version 0.2.0	2023-01-13 09:40:57 +00:00
pubkey.h	Merge bitcoin/bitcoin#26691: Update secp256k1 subtree to libsecp256k1 version 0.2.0	2023-01-13 09:40:57 +00:00
random.cpp	random: consolidate WIN32 #ifdefs	2023-02-17 15:01:50 +00:00
random.h	Merge bitcoin/bitcoin#26153: Reduce wasted pseudorandom bytes in ChaCha20 + various improvements	2023-02-15 14:58:47 +00:00
randomenv.cpp	Merge bitcoin/bitcoin#26826: refactor: remove windows-only compat.h usage in randomenv	2023-01-23 16:36:27 +01:00
randomenv.h
rest.cpp	Use DataStream where possible	2023-01-26 10:44:05 +01:00
rest.h
reverse_iterator.h	doc: remove usages of C++11	2023-01-12 13:42:44 +00:00
scheduler.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
scheduler.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
serialize.h	clang-tidy: Fix modernize-use-default-member-init in headers	2023-01-31 11:50:10 +00:00
shutdown.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
shutdown.h
signet.cpp
signet.h
span.h	clang-tidy: Fix modernize-use-default-member-init in headers	2023-01-31 11:50:10 +00:00
streams.h	Merge bitcoin/bitcoin#26992: refactor: Remove unused CDataStream SerializeMany constructor	2023-02-02 10:47:37 +00:00
sync.cpp
sync.h	doc: Export threadsafety.h from sync.h	2023-01-25 09:33:26 +01:00
threadsafety.h
timedata.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
timedata.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
tinyformat.h	clang-tidy: Fix modernize-use-default-member-init in headers	2023-01-31 11:50:10 +00:00
torcontrol.cpp	Merge bitcoin/bitcoin#25619: net: avoid overriding non-virtual ToString() in CService and use better naming	2023-02-17 13:34:40 -05:00
torcontrol.h	clang-tidy: Fix modernize-use-default-member-init in headers	2023-01-31 11:50:10 +00:00
txdb.cpp	refactor, txdb: Use DBParams struct in CBlockTreeDB	2023-02-10 04:39:11 -04:00
txdb.h	refactor, txdb: Use DBParams struct in CBlockTreeDB	2023-02-10 04:39:11 -04:00
txmempool.cpp	Fix clang-tidy readability-const-return-type violations	2023-02-01 11:33:35 +01:00
txmempool.h	Fix clang-tidy readability-const-return-type violations	2023-02-01 11:33:35 +01:00
txorphanage.cpp	Merge bitcoin/bitcoin#26551: p2p: Track orphans by who provided them	2023-01-26 10:36:18 +00:00
txorphanage.h	Merge bitcoin/bitcoin#26551: p2p: Track orphans by who provided them	2023-01-26 10:36:18 +00:00
txrequest.cpp
txrequest.h
uint256.cpp	refactor: modernize the implementation of uint256.*	2022-12-10 14:34:44 -06:00
uint256.h	Merge bitcoin/bitcoin#26345: refactor: modernize the implementation of uint256.*	2023-02-06 13:56:51 -05:00
undo.h
validation.cpp	Merge bitcoin/bitcoin#25574: validation: Improve error handling when VerifyDB dosn't finish successfully	2023-02-22 14:19:44 -05:00
validation.h	Merge bitcoin/bitcoin#25574: validation: Improve error handling when VerifyDB dosn't finish successfully	2023-02-22 14:19:44 -05:00
validationinterface.cpp	Fix clang-tidy readability-const-return-type violations	2023-02-01 11:33:35 +01:00
validationinterface.h	refactor: add kernel/cs_main.*	2023-01-05 09:05:14 +00:00
version.h
versionbits.cpp	refactor: use braced init for integer constants instead of c style casts	2023-01-03 19:31:29 -06:00
versionbits.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
walletinitinterface.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
warnings.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
warnings.h