0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-05 10:17:30 -05:00
bitcoin-bitcoin-core/src/test
laanwj d492dc1cda
Merge bitcoin/bitcoin#24147: Miniscript integration
2da94a4c6f fuzz: add a fuzz target for Miniscript decoding from Script (Antoine Poinsot)
f8369996e7 Miniscript: ops limit and stack size computation (Pieter Wuille)
2e55e88f86 Miniscript: conversion from script (Pieter Wuille)
1ddaa66eae Miniscript: type system, script creation, text notation, tests (Pieter Wuille)
4fe29368c0 script: expose getter for CScriptNum, add a BuildScript helper (Antoine Poinsot)
f4e289f384 script: move CheckMinimalPush from interpreter to script.h (Antoine Poinsot)
31ec6ae92a script: make IsPushdataOp non-static (Antoine Poinsot)

Pull request description:

  Miniscript is a language for writing (a subset of) Bitcoin Scripts in a structured way.

  Miniscript permits:
  - To safely extend the Output Descriptor language to many more scripting features thanks to the typing system (composition).
  - Statical analysis of spending conditions, maximum spending cost of each branch, security properties, third-party malleability.
  - General satisfaction of any correctly typed ("valid" [0]) Miniscript. The satisfaction itself is also analyzable.
  - To extend the possibilities of external signers, because of all of the above and since it carries enough metadata.

  Miniscript guarantees:
  - That for any statically-analyzed as "safe" [0] Script, a witness can be constructed in the bounds of the consensus and standardness rules (standardness complete).
  - That unless the conditions of the Miniscript are met, no witness can be created for the Script (consensus sound).
  - Third-party malleability protection for the satisfaction of a sane Miniscript, which is too complex to summarize here.

  For more details around Miniscript (including the specifications), please refer to the [website](https://bitcoin.sipa.be/miniscript/).

  Miniscript was designed by Pieter Wuille, Andrew Poelstra and Sanket Kanjalkar.
  This PR is an updated and rebased version of #16800. See [the commit history of the Miniscript repository](https://github.com/sipa/miniscript/commits/master) for details about the changes made since September 2019 (TL;DR: bugfixes, introduction of timelock conflicts in the type system, `pk()` and `pkh()` aliases, `thresh_m` renamed to `multi`, all recursive algorithms were made non-recursive).

  This PR is also the first in a series of 3:
  - The first one (here) integrates the backbone of Miniscript.
  - The second one (#24148) introduces support for Miniscript in Output Descriptors, allowing for watch-only support of Miniscript Descriptors in the wallet.
  - The third one (#24149) implements signing for these Miniscript Descriptors, using Miniscript's satisfaction algorithm.

  Note to reviewers:
  - Miniscript is currently defined only for P2WSH. No Taproot yet.
  - Miniscript is different from the policy language (a high-level logical representation of a spending policy). A policy->Miniscript compiler is not included here.
  - The fuzz target included here is more interestingly extended in the 3rd PR to check a script's satisfaction against `VerifyScript`. I think it could be further improved by having custom mutators as we now have for multisig (see https://github.com/bitcoin/bitcoin/issues/23105). A minified corpus of Miniscript Scripts is available at https://github.com/bitcoin-core/qa-assets/pull/85.

  [0] We call "valid" any correctly-typed Miniscript. And "safe" any sane Miniscript, ie one whose satisfaction isn't malleable, which requires a key for any spending path, etc..

ACKs for top commit:
  jb55:
    ACK 2da94a4c6f
  laanwj:
    Light code review ACK 2da94a4c6f (mostly reviewed the changes to the existing code and build system)

Tree-SHA512: d3ef558436cfcc699a50ad13caf1e776f7d0addddb433ee28ef38f66ea5c3e581382d8c748ccac9b51768e4b95712ed7a6112b0e3281a6551e0f325331de9167
2022-04-05 13:22:09 +02:00
..
data Test that OP_1-OP_16 (but not lower/higher) start witness programs 2022-02-10 08:51:48 +00:00
fuzz Merge bitcoin/bitcoin#24147: Miniscript integration 2022-04-05 13:22:09 +02:00
util scripted-diff: rename TxRelay members 2022-03-18 11:35:58 +00:00
addrman_tests.cpp test: addrman unit tests: override-able check ratio 2022-01-11 12:08:42 +01:00
allocator_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
amount_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
arith_uint256_tests.cpp refactor tests to fix ubsan suppressions 2022-01-20 15:25:23 +01:00
banman_tests.cpp net: Drop only invalid entries when reading banlist.json 2021-12-14 18:58:45 +01:00
base32_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
base58_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
base64_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
bech32_tests.cpp Make Bech32 LocateErrors return error list rather than using out-arg 2021-12-06 14:17:41 +13:00
bip32_tests.cpp refactor: Take Span in SetSeed 2021-11-01 14:20:56 +01:00
blockchain_tests.cpp
blockencodings_tests.cpp scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
blockfilter_index_tests.cpp Add src/node/* code to node:: namespace 2022-01-06 22:14:16 -05:00
blockfilter_tests.cpp scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
bloom_tests.cpp Use spans of std::byte in serialize 2022-01-02 11:40:31 +01:00
bswap_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
checkqueue_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
coins_tests.cpp test: Avoid testing negative block heights 2022-02-02 15:32:06 +01:00
coinstatsindex_tests.cpp Add coinstatsindex_unclean_shutdown test 2022-02-25 16:06:27 -05:00
compilerbug_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
compress_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
crypto_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
cuckoocache_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
dbwrapper_tests.cpp util: Work around libstdc++ create_directories issue 2022-02-17 12:30:11 +01:00
denialofservice_tests.cpp test: Limit scope of id global which is shared between subtests 2022-03-21 16:27:44 +01:00
descriptor_tests.cpp refactor: fix clang-tidy named args usage 2022-04-04 09:01:19 +01:00
flatfile_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
fs_tests.cpp test: Correctly decode UTF-8 literal string paths 2022-03-03 14:12:07 -05:00
getarg_tests.cpp qt: Avoid crash on startup if int specified in settings.json 2022-03-07 13:29:46 -05:00
hash_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
i2p_tests.cpp scripted-diff: Replace GetDataDir() calls with gArgs.GetDataDirNet() calls 2021-05-24 10:29:58 +02:00
interfaces_tests.cpp Guard CBlockIndex::nStatus/nFile/nDataPos/nUndoPos by cs_main 2022-01-25 20:46:52 +01:00
key_io_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
key_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
logging_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
main.cpp build: use header-only Boost unit test 2022-02-13 20:59:02 +00:00
Makefile
mempool_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
merkle_tests.cpp scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
merkleblock_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
miner_tests.cpp Merge bitcoin/bitcoin#24080: policy: Remove unused locktime flags 2022-03-14 16:32:23 +01:00
miniscript_tests.cpp Miniscript: ops limit and stack size computation 2022-03-17 14:09:08 +01:00
minisketch_tests.cpp Add src/node/* code to node:: namespace 2022-01-06 22:14:16 -05:00
multisig_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
net_peer_eviction_tests.cpp scripted-diff: rename TxRelay members 2022-03-18 11:35:58 +00:00
net_tests.cpp Merge bitcoin/bitcoin#24205: init, test: improve network reachability test coverage and safety 2022-03-24 21:17:46 +01:00
netbase_tests.cpp net: open p2p connections to nodes that listen on non-default ports 2022-02-11 15:21:49 +01:00
pmt_tests.cpp
policy_fee_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
policyestimator_tests.cpp
pow_tests.cpp refactor tests to fix ubsan suppressions 2022-01-20 15:25:23 +01:00
prevector_tests.cpp refactor tests to fix ubsan suppressions 2022-01-20 15:25:23 +01:00
raii_event_tests.cpp scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
random_tests.cpp
README.md test: parse the command line arguments in unit tests 2022-01-11 11:53:30 +01:00
reverselock_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
rpc_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
sanity_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
scheduler_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
script_p2sh_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
script_parse_tests.cpp bitcoin-tx: Avoid treating overflow as OP_0 2021-10-11 09:17:28 +02:00
script_segwit_tests.cpp Unit tests for IsWitnessProgram and IsP2WSH. 2021-10-15 06:46:25 +02:00
script_standard_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
script_tests.cpp refactor: replace boost::filesystem with std::filesystem 2022-02-03 18:35:52 +08:00
scriptnum10.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
scriptnum_tests.cpp refactor: replace sizeof(a)/sizeof(a[0]) by std::size (C++17) 2021-01-31 17:35:16 +01:00
serfloat_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
serialize_tests.cpp test: Fix Wambiguous-reversed-operator compiler warnings 2022-02-21 16:36:59 +01:00
settings_tests.cpp refactor: replace boost::filesystem with std::filesystem 2022-02-03 18:35:52 +08:00
sighash_tests.cpp refactor tests to fix ubsan suppressions 2022-01-20 15:25:23 +01:00
sigopcount_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
skiplist_tests.cpp refactor tests to fix ubsan suppressions 2022-01-20 15:25:23 +01:00
sock_tests.cpp net: flag relevant Sock methods with [[nodiscard]] 2021-04-13 17:26:20 +02:00
streams_tests.cpp test: Create fresh CDataStream each time 2022-02-03 20:16:41 +01:00
sync_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
system_tests.cpp build: Fix Boost.Process test for Boost 1.78 2022-03-21 16:52:27 +00:00
timedata_tests.cpp timedata: make it possible to reset the state 2022-03-02 15:40:30 +01:00
torcontrol_tests.cpp test: remove BasicTestingSetup from torcontrol unit tests 2021-05-28 19:14:09 +08:00
transaction_tests.cpp refactor tests to fix ubsan suppressions 2022-01-20 15:25:23 +01:00
txindex_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
txpackage_tests.cpp test: fix incorrect named args in txpackage tests 2022-03-31 16:34:33 +01:00
txrequest_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
txvalidation_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
txvalidationcache_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
uint256_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
util_tests.cpp util/check: stop using lambda for Assert/Assume 2022-03-30 23:09:13 +10:00
util_threadnames_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
validation_block_tests.cpp Add src/node/* code to node:: namespace 2022-01-06 22:14:16 -05:00
validation_chainstate_tests.cpp tests: Remove now-unnecessary manual Unload's 2022-02-22 11:56:49 -05:00
validation_chainstatemanager_tests.cpp tests: Remove now-unnecessary manual Unload's 2022-02-22 11:56:49 -05:00
validation_flush_tests.cpp Add src/node/* code to node:: namespace 2022-01-06 22:14:16 -05:00
validation_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
validationinterface_tests.cpp
versionbits_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00

Unit tests

The sources in this directory are unit test cases. Boost includes a unit testing framework, and since Bitcoin Core already uses Boost, it makes sense to simply use this framework rather than require developers to configure some other framework (we want as few impediments to creating unit tests as possible).

The build system is set up to compile an executable called test_bitcoin that runs all of the unit tests. The main source file for the test library is found in util/setup_common.cpp.

Compiling/running unit tests

Unit tests will be automatically compiled if dependencies were met in ./configure and tests weren't explicitly disabled.

After configuring, they can be run with make check.

To run the unit tests manually, launch src/test/test_bitcoin. To recompile after a test file was modified, run make and then run the test again. If you modify a non-test file, use make -C src/test to recompile only what's needed to run the unit tests.

To add more unit tests, add BOOST_AUTO_TEST_CASE functions to the existing .cpp files in the test/ directory or add new .cpp files that implement new BOOST_AUTO_TEST_SUITE sections.

To run the GUI unit tests manually, launch src/qt/test/test_bitcoin-qt

To add more GUI unit tests, add them to the src/qt/test/ directory and the src/qt/test/test_main.cpp file.

Running individual tests

test_bitcoin accepts the command line arguments from the boost framework. For example, to run just the getarg_tests suite of tests:

test_bitcoin --log_level=all --run_test=getarg_tests

log_level controls the verbosity of the test framework, which logs when a test case is entered, for example. test_bitcoin also accepts the command line arguments accepted by bitcoind. Use -- to separate both types of arguments:

test_bitcoin --log_level=all --run_test=getarg_tests -- -printtoconsole=1

The -printtoconsole=1 after the two dashes redirects the debug log, which would normally go to a file in the test datadir (BasicTestingSetup::m_path_root), to the standard terminal output.

... or to run just the doubledash test:

test_bitcoin --run_test=getarg_tests/doubledash

Run test_bitcoin --help for the full list.

Adding test cases

To add a new unit test file to our test suite you need to add the file to src/Makefile.test.include. The pattern is to create one test file for each class or source file for which you want to create unit tests. The file naming convention is <source_filename>_tests.cpp and such files should wrap their tests in a test suite called <source_filename>_tests. For an example of this pattern, see uint256_tests.cpp.

Logging and debugging in unit tests

make check will write to a log file foo_tests.cpp.log and display this file on failure. For running individual tests verbosely, refer to the section above.

To write to logs from unit tests you need to use specific message methods provided by Boost. The simplest is BOOST_TEST_MESSAGE.

For debugging you can launch the test_bitcoin executable with gdb or lldb and start debugging, just like you would with any other program:

gdb src/test/test_bitcoin

Segmentation faults

If you hit a segmentation fault during a test run, you can diagnose where the fault is happening by running gdb ./src/test/test_bitcoin and then using the bt command within gdb.

Another tool that can be used to resolve segmentation faults is valgrind.

If for whatever reason you want to produce a core dump file for this fault, you can do that as well. By default, the boost test runner will intercept system errors and not produce a core file. To bypass this, add --catch_system_errors=no to the test_bitcoin arguments and ensure that your ulimits are set properly (e.g. ulimit -c unlimited).

Running the tests and hitting a segmentation fault should now produce a file called core (on Linux platforms, the file name will likely depend on the contents of /proc/sys/kernel/core_pattern).

You can then explore the core dump using

gdb src/test/test_bitcoin core

(gbd) bt  # produce a backtrace for where a segfault occurred