foster/bitcoin-bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-24 12:41:41 -05:00
Code Issues Activity
bitcoin-bitcoin-core/src/bench
History
merge-script d4cc0c6845
Merge bitcoin/bitcoin#30750: scripted-diff: LogPrint -> LogDebug 
fa09cb41f5 refactor: Remove unused LogPrint (MarcoFalke)
3333415890 scripted-diff: LogPrint -> LogDebug (MarcoFalke)

Pull request description:

  `LogPrint` has many issues:

  * It seems to indicate that something is being "printed", however config options such as `-printtoconsole` actually control what and where something is logged.
  * It does not mention the log severity (debug).
  * It is a deprecated alias for `LogDebug`, according to the dev notes.
  * It wastes review cycles, because reviewers sometimes point out that it is deprecated.
  * It makes the code inconsistent, when both are used, possibly even in lines right next to each other (like in `InitHTTPServer`)

  Fix all issues by removing the deprecated alias.

  I checked all conflicting pull requests and at the time of writing there are no conflicts, except in pull requests that are marked as draft, are yet unreviewed, or are blocked on feedback for other reasons. So I think it is fine to do now.

ACKs for top commit:
  stickies-v:
    ACK fa09cb41f5
  danielabrozzoni:
    utACK fa09cb41f5
  TheCharlatan:
    ACK fa09cb41f5

Tree-SHA512: 14270f4cfa3906025a0b994cbb5b2e3c8c2427c0beb19c717a505a2ccbfb1fd1ecf2fd03f6c52d22cde69a8d057e50d2207119fab2c2bc8228db3f10d4288d0f
2024-09-02 11:59:56 +01:00
..
data Add deserialize + CheckBlock benchmarks, and a full block hex 2016-11-09 11:27:59 -08:00
addrman.cpp bench: [refactor] iwyu 2024-08-27 07:33:59 +02:00
base58.cpp bench: [refactor] iwyu 2024-08-27 07:33:59 +02:00
bech32.cpp refactor: Hand-replace some ParseHex -> ""_hex 2024-08-28 19:11:59 +02:00
bench.cpp bench: [refactor] iwyu 2024-08-27 07:33:59 +02:00
bench.h bench: [refactor] iwyu 2024-08-27 07:33:59 +02:00
bench_bitcoin.cpp bench: [refactor] iwyu 2024-08-27 07:33:59 +02:00
bip324_ecdh.cpp bench: [refactor] iwyu 2024-08-27 07:33:59 +02:00
block_assemble.cpp bench: [refactor] iwyu 2024-08-27 07:33:59 +02:00
ccoins_caching.cpp bench: [refactor] iwyu 2024-08-27 07:33:59 +02:00
chacha20.cpp bench: [refactor] iwyu 2024-08-27 07:33:59 +02:00
checkblock.cpp bench: [refactor] iwyu 2024-08-27 07:33:59 +02:00
checkblockindex.cpp bench: [refactor] iwyu 2024-08-27 07:33:59 +02:00
checkqueue.cpp bench: [refactor] iwyu 2024-08-27 07:33:59 +02:00
cluster_linearize.cpp bench: [refactor] iwyu 2024-08-27 07:33:59 +02:00
CMakeLists.txt cmake: Implement install build target 2024-08-16 21:19:11 +01:00
coin_selection.cpp bench: [refactor] iwyu 2024-08-27 07:33:59 +02:00
crypto_hash.cpp bench: [refactor] iwyu 2024-08-27 07:33:59 +02:00
data.cpp bench: [refactor] iwyu 2024-08-27 07:33:59 +02:00
data.h bench: Move generated data to a dedicated translation unit 2019-07-02 18:11:15 +01:00
descriptors.cpp Merge bitcoin/bitcoin#22838: descriptors: Be able to specify change and receiving in a single descriptor string 2024-08-28 15:56:15 +01:00
disconnected_transactions.cpp bench: [refactor] iwyu 2024-08-27 07:33:59 +02:00
duplicate_inputs.cpp bench: [refactor] iwyu 2024-08-27 07:33:59 +02:00
ellswift.cpp bench: [refactor] iwyu 2024-08-27 07:33:59 +02:00
examples.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
gcs_filter.cpp bench: [refactor] iwyu 2024-08-27 07:33:59 +02:00
hashpadding.cpp bench: [refactor] iwyu 2024-08-27 07:33:59 +02:00
index_blockfilter.cpp scripted-diff: Replace ParseHex[<std::byte>]("str") -> "str"_hex[_u8] 2024-08-28 19:11:59 +02:00
load_external.cpp bench: [refactor] iwyu 2024-08-27 07:33:59 +02:00
lockedpool.cpp bench: [refactor] iwyu 2024-08-27 07:33:59 +02:00
logging.cpp refactor: Remove unused LogPrint 2024-08-29 15:58:27 +02:00
mempool_eviction.cpp bench: [refactor] iwyu 2024-08-27 07:33:59 +02:00
mempool_stress.cpp bench: [refactor] iwyu 2024-08-27 07:33:59 +02:00
merkle_root.cpp bench: [refactor] iwyu 2024-08-27 07:33:59 +02:00
nanobench.cpp Replace current benchmarking framework with nanobench 2020-06-13 12:24:18 +02:00
nanobench.h bench: Update nanobench to 4.3.11 2023-11-14 20:22:12 +01:00
parse_hex.cpp Add benchmark for TryParseHex 2024-02-28 17:23:54 +00:00
peer_eviction.cpp bench: [refactor] iwyu 2024-08-27 07:33:59 +02:00
poly1305.cpp bench: [refactor] iwyu 2024-08-27 07:33:59 +02:00
pool.cpp bench: [refactor] iwyu 2024-08-27 07:33:59 +02:00
prevector.cpp bench: [refactor] iwyu 2024-08-27 07:33:59 +02:00
random.cpp bench: [refactor] iwyu 2024-08-27 07:33:59 +02:00
readblock.cpp bench: [refactor] iwyu 2024-08-27 07:33:59 +02:00
rollingbloom.cpp bench: [refactor] iwyu 2024-08-27 07:33:59 +02:00
rpc_blockchain.cpp bench: [refactor] iwyu 2024-08-27 07:33:59 +02:00
rpc_mempool.cpp bench: [refactor] iwyu 2024-08-27 07:33:59 +02:00
sign_transaction.cpp Merge bitcoin/bitcoin#30571: test: [refactor] Use m_rng directly 2024-08-28 16:56:32 +01:00
streams_findbyte.cpp refactor: switch from CAutoFile to AutoFile 2023-11-18 03:01:41 +10:00
strencodings.cpp bench: [refactor] iwyu 2024-08-27 07:33:59 +02:00
util_time.cpp refactor: Remove unused GetTimeMillis 2023-05-08 12:40:48 +02:00
verify_script.cpp bench: [refactor] iwyu 2024-08-27 07:33:59 +02:00
wallet_balance.cpp bench: [refactor] iwyu 2024-08-27 07:33:59 +02:00
wallet_create.cpp bench: [refactor] iwyu 2024-08-27 07:33:59 +02:00
wallet_create_tx.cpp bench: [refactor] iwyu 2024-08-27 07:33:59 +02:00
wallet_ismine.cpp Merge bitcoin/bitcoin#22838: descriptors: Be able to specify change and receiving in a single descriptor string 2024-08-28 15:56:15 +01:00
wallet_loading.cpp bench: [refactor] iwyu 2024-08-27 07:33:59 +02:00
xor.cpp bench: [refactor] iwyu 2024-08-27 07:33:59 +02:00