Wladimir J. van der Laan b688b859db Merge #17004: validation: Remove REJECT code from CValidationState ... 9075d13153 [docs] Add release notes for removal of REJECT reasons (John Newbery) 04a2f326ec [validation] Fix REJECT message comments (John Newbery) e9d5a59e34 [validation] Remove REJECT code from CValidationState (John Newbery) 0053e16714 [logging] Don't log REJECT code when transaction is rejected (John Newbery) a1a07cfe99 [validation] Fix peer punishment for bad blocks (John Newbery) Pull request description: We no longer send BIP 61 REJECT messages, so there's no need to set a REJECT code in the CValidationState object. Note that there is a minor bug fix in p2p behaviour here. Because the call to `MaybePunishNode()` in `PeerLogicValidation::BlockChecked()` only previously happened if the REJECT code was > 0 and < `REJECT_INTERNAL`, then there are cases were `MaybePunishNode()` can get called where it wasn't previously: - when `AcceptBlockHeader()` fails with `CACHED_INVALID`. - when `AcceptBlockHeader()` fails with `BLOCK_MISSING_PREV`. Note that `BlockChecked()` cannot fail with an 'internal' reject code. The only internal reject code was `REJECT_HIGHFEE`, which was only set in ATMP. This reverts a minor bug introduced in 5d08c9c579. ACKs for top commit: ariard: ACK 9075d13, changes since last reviewed are splitting them in separate commits to ease understanding and fix nits fjahr: ACK 9075d13153, confirmed diff to last review was fixing nits in docs/comments. ryanofsky: Code review ACK 9075d13153. Only changes since last review are splitting the main commit and updating comments Tree-SHA512: 58e8a1a4d4e6f156da5d29fb6ad6a62fc9c594bbfc6432b3252e962d0e9e10149bf3035185dc5320c46c09f3e49662bc2973ec759679c0f3412232087cb8a3a7		2019-10-24 10:49:45 +02:00
..
blockchain.cpp	Remove unused includes	2019-10-15 22:56:43 +00:00
blockchain.h	rpc: Add lock annotations to block{,header}ToJSON	2019-05-02 14:33:26 -04:00
client.cpp	Remove unused includes	2019-10-15 22:56:43 +00:00
client.h	Update copyright headers to 2018	2018-07-27 07:15:02 -04:00
mining.cpp	Merge #16060: Bury bip9 deployments	2019-08-15 16:02:10 -04:00
misc.cpp	Remove unused includes	2019-10-15 22:56:43 +00:00
net.cpp	Remove unused includes	2019-10-15 22:56:43 +00:00
protocol.h	rpc: migrate JSONRPCRequest functionality into request.cpp	2019-07-05 11:22:02 +09:00
rawtransaction.cpp	Merge #17004: validation: Remove REJECT code from CValidationState	2019-10-24 10:49:45 +02:00
rawtransaction_util.cpp	doc: Fix doxygen comment for SignTransaction in rpc/rawtransaction_util	2019-09-19 13:34:50 -04:00
rawtransaction_util.h	doc: Fix doxygen comment for SignTransaction in rpc/rawtransaction_util	2019-09-19 13:34:50 -04:00
register.h	Update copyright headers to 2018	2018-07-27 07:15:02 -04:00
request.cpp	rpc: migrate JSONRPCRequest functionality into request.cpp	2019-07-05 11:22:02 +09:00
request.h	rpc: migrate JSONRPCRequest functionality into request.cpp	2019-07-05 11:22:02 +09:00
server.cpp	Remove unused includes	2019-10-15 22:56:43 +00:00
server.h	Remove unused includes	2019-10-15 22:56:43 +00:00
util.cpp	rpc/net: decode the services flags in a new entry	2019-09-05 15:11:48 +02:00
util.h	rpc/net: decode the services flags in a new entry	2019-09-05 15:11:48 +02:00