0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-05 10:17:30 -05:00
bitcoin-bitcoin-core/src/qt/test
Wladimir J. van der Laan de5af41e35
Merge #15452: Replace CScriptID and CKeyID in CTxDestination with dedicated types
78e407ad0c GetKeyBirthTimes should return key ids, not destinations (Gregory Sanders)
70946e7fee Replace CScriptID and CKeyID in CTxDestination with dedicated types (Gregory Sanders)

Pull request description:

  The current usage seems to be an overloading of meanings. `CScriptID` is used in the wallet as a lookup key, as well as a destination, and `CKeyID` likewise. Instead, have all destinations be dedicated types.

  New types:
  `CScriptID`->`ScriptHash`
  `CKeyID`->`PKHash`

ACKs for commit 78e407:
  ryanofsky:
    utACK 78e407ad0c. Only changes are removing extra CScriptID()s and fixing the test case.
  Sjors:
    utACK 78e407a
  meshcollider:
    utACK 78e407ad0c

Tree-SHA512: 437f59fc3afb83a40540da3351507aef5aed44e3a7f15b01ddad6226854edeee762ff0b0ef336fe3654c4cd99a205cef175211de8b639abe1130c8a6313337b9
2019-05-09 18:54:43 +02:00
..
addressbooktests.cpp Merge #15788: test: Unify testing setups for fuzz, bench, and unit tests 2019-04-15 11:28:25 -04:00
addressbooktests.h [tests] [qt] Add tests for address book manipulation via EditAddressDialog 2018-04-25 13:13:24 -04:00
apptests.cpp Bump minimum Qt version to 5.5.1 2019-02-14 11:12:30 +01:00
apptests.h Add BitcoinApplication & RPCConsole tests 2019-01-04 06:31:07 -05:00
compattests.cpp build: Add --disable-bip70 configure option 2018-10-09 03:36:14 -06:00
compattests.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
Makefile build: add stub makefiles for easier subdir builds 2014-06-05 16:05:43 -04:00
paymentrequestdata.h Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
paymentservertests.cpp Use FRC::randbytes instead of reading >32 bytes from RNG 2019-01-13 09:53:47 -08:00
paymentservertests.h Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
rpcnestedtests.cpp scripted-diff: Rename test_bitcoin to test/setup_common 2019-04-11 10:12:36 -04:00
rpcnestedtests.h Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
test_main.cpp Add BitcoinApplication & RPCConsole tests 2019-01-04 06:31:07 -05:00
uritests.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
uritests.h Bump copyright headers to 2015 2015-12-13 18:08:39 +01:00
util.cpp Revert "Make qt wallet test compatible with qt4" 2018-10-20 05:34:53 -03:00
util.h util.h: explicitly include required QString header 2018-11-13 16:49:34 +09:00
wallettests.cpp Merge #15452: Replace CScriptID and CKeyID in CTxDestination with dedicated types 2019-05-09 18:54:43 +02:00
wallettests.h Add simple qt wallet test sending a transaction 2017-03-15 12:02:02 -05:00