mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-02-13 11:25:02 -05:00
![fanquake](/assets/img/avatar_default.png)
5cf4d266d9
[test] Test i2p private key constraints (Vasil Dimov)cf70a8d565
[net] Check i2p private key constraints (dergoegge) Pull request description: Not sanity checking can lead to crashes or worse: ``` ==1715589==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6140000055c2 at pc 0x5622ed66e7ad bp 0x7ffee547a2c0 sp 0x7ffee547a2b8 READ of size 2 at 0x6140000055c2 thread T0 (b-test) #0 0x5622ed66e7ac in memcpy include/bits/string_fortified.h:29:10 #1 0x5622ed66e7ac in i2p::sam::Session::MyDestination() const src/i2p.cpp:362:5 #2 0x5622ed662e46 in i2p::sam::Session::CreateIfNotCreatedAlready() src/i2p.cpp:414:40 #3 0x5622ed6619f2 in i2p::sam::Session::Listen(i2p::Connection&) src/i2p.cpp:143:9 ``` ACKs for top commit: maflcko: code lgtm ACK5cf4d266d9
stickies-v: re-ACK5cf4d266d9
vasild: ACK5cf4d266d9
Tree-SHA512: 3de3bd396538fa619de67957b9c8a58011ab911f0f51097c387e730c13908278b7322aa3357051fb245a20b15bef34b0e9fadcb1eff8ad751139d2aa634c78ad
172 lines
8 KiB
C++
172 lines
8 KiB
C++
// Copyright (c) 2021-2022 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#include <common/args.h>
|
|
#include <i2p.h>
|
|
#include <logging.h>
|
|
#include <netaddress.h>
|
|
#include <test/util/logging.h>
|
|
#include <test/util/net.h>
|
|
#include <test/util/setup_common.h>
|
|
#include <util/readwritefile.h>
|
|
#include <util/threadinterrupt.h>
|
|
|
|
#include <boost/test/unit_test.hpp>
|
|
|
|
#include <memory>
|
|
#include <string>
|
|
|
|
/// Save the log level and the value of CreateSock and restore them when the test ends.
|
|
class EnvTestingSetup : public BasicTestingSetup
|
|
{
|
|
public:
|
|
explicit EnvTestingSetup(const ChainType chainType = ChainType::MAIN,
|
|
const std::vector<const char*>& extra_args = {})
|
|
: BasicTestingSetup{chainType, extra_args},
|
|
m_prev_log_level{LogInstance().LogLevel()},
|
|
m_create_sock_orig{CreateSock}
|
|
{
|
|
LogInstance().SetLogLevel(BCLog::Level::Trace);
|
|
}
|
|
|
|
~EnvTestingSetup()
|
|
{
|
|
CreateSock = m_create_sock_orig;
|
|
LogInstance().SetLogLevel(m_prev_log_level);
|
|
}
|
|
|
|
private:
|
|
const BCLog::Level m_prev_log_level;
|
|
const std::function<std::unique_ptr<Sock>(const CService&)> m_create_sock_orig;
|
|
};
|
|
|
|
BOOST_FIXTURE_TEST_SUITE(i2p_tests, EnvTestingSetup)
|
|
|
|
BOOST_AUTO_TEST_CASE(unlimited_recv)
|
|
{
|
|
// Mock CreateSock() to create MockSock.
|
|
CreateSock = [](const CService&) {
|
|
return std::make_unique<StaticContentsSock>(std::string(i2p::sam::MAX_MSG_SIZE + 1, 'a'));
|
|
};
|
|
|
|
CThreadInterrupt interrupt;
|
|
i2p::sam::Session session(gArgs.GetDataDirNet() / "test_i2p_private_key", CService{}, &interrupt);
|
|
|
|
{
|
|
ASSERT_DEBUG_LOG("Creating persistent SAM session");
|
|
ASSERT_DEBUG_LOG("too many bytes without a terminator");
|
|
|
|
i2p::Connection conn;
|
|
bool proxy_error;
|
|
BOOST_REQUIRE(!session.Connect(CService{}, conn, proxy_error));
|
|
}
|
|
}
|
|
|
|
BOOST_AUTO_TEST_CASE(listen_ok_accept_fail)
|
|
{
|
|
size_t num_sockets{0};
|
|
CreateSock = [&num_sockets](const CService&) {
|
|
// clang-format off
|
|
++num_sockets;
|
|
// First socket is the control socket for creating the session.
|
|
if (num_sockets == 1) {
|
|
return std::make_unique<StaticContentsSock>(
|
|
// reply to HELLO
|
|
"HELLO REPLY RESULT=OK VERSION=3.1\n"
|
|
// reply to DEST GENERATE
|
|
"DEST REPLY PUB=WnGOLXRBqHQhdVjFlWqRxJwz9hxx~2~wGc2Vplta1KhacY4tdEGodCF1WMWVapHEnDP2HHH~b~AZzZWmW1rUqFpxji10Qah0IXVYxZVqkcScM~Yccf9v8BnNlaZbWtSoWnGOLXRBqHQhdVjFlWqRxJwz9hxx~2~wGc2Vplta1KhacY4tdEGodCF1WMWVapHEnDP2HHH~b~AZzZWmW1rUqFpxji10Qah0IXVYxZVqkcScM~Yccf9v8BnNlaZbWtSoWnGOLXRBqHQhdVjFlWqRxJwz9hxx~2~wGc2Vplta1KhacY4tdEGodCF1WMWVapHEnDP2HHH~b~AZzZWmW1rUqFpxji10Qah0IXVYxZVqkcScM~Yccf9v8BnNlaZbWtSoWnGOLXRBqHQhdVjFlWqRxJwz9hxx~2~wGc2Vplta1KhacY4tdEGodCF1WMWVapHEnDP2HHH~b~AZzZWmW1rUqLE4SD-yjT48UNI7qiTUfIPiDitCoiTTz2cr4QGfw89rBQAEAAcAAA== PRIV=WnGOLXRBqHQhdVjFlWqRxJwz9hxx~2~wGc2Vplta1KhacY4tdEGodCF1WMWVapHEnDP2HHH~b~AZzZWmW1rUqFpxji10Qah0IXVYxZVqkcScM~Yccf9v8BnNlaZbWtSoWnGOLXRBqHQhdVjFlWqRxJwz9hxx~2~wGc2Vplta1KhacY4tdEGodCF1WMWVapHEnDP2HHH~b~AZzZWmW1rUqFpxji10Qah0IXVYxZVqkcScM~Yccf9v8BnNlaZbWtSoWnGOLXRBqHQhdVjFlWqRxJwz9hxx~2~wGc2Vplta1KhacY4tdEGodCF1WMWVapHEnDP2HHH~b~AZzZWmW1rUqFpxji10Qah0IXVYxZVqkcScM~Yccf9v8BnNlaZbWtSoWnGOLXRBqHQhdVjFlWqRxJwz9hxx~2~wGc2Vplta1KhacY4tdEGodCF1WMWVapHEnDP2HHH~b~AZzZWmW1rUqLE4SD-yjT48UNI7qiTUfIPiDitCoiTTz2cr4QGfw89rBQAEAAcAAOvuCIKTyv5f~1QgGq7XQl-IqBULTB5WzB3gw5yGPtd1p0AeoADrq1ccZggLPQ4ZLUsGK-HVw373rcTfvxrcuwenqVjiN4tbbYLWtP7xXGWj6fM6HyORhU63GphrjEePpMUHDHXd3o7pWGM-ieVVQSK~1MzF9P93pQWI3Do52EeNAayz4HbpPjNhVBzG1hUEFwznfPmUZBPuaOR4-uBm1NEWEuONlNOCctE4-U0Ukh94z-Qb55U5vXjR5G4apmBblr68t6Wm1TKlzpgFHzSqLryh3stWqrOKY1H0z9eZ2z1EkHFOpD5LyF6nf51e-lV7HLMl44TYzoEHK8RRVodtLcW9lacVdBpv~tOzlZERIiDziZODPETENZMz5oy9DQ7UUw==\n"
|
|
// reply to SESSION CREATE
|
|
"SESSION STATUS RESULT=OK\n"
|
|
// dummy to avoid reporting EOF on the socket
|
|
"a"
|
|
);
|
|
}
|
|
// Subsequent sockets are for recreating the session or for listening and accepting incoming connections.
|
|
if (num_sockets % 2 == 0) {
|
|
// Replies to Listen() and Accept()
|
|
return std::make_unique<StaticContentsSock>(
|
|
// reply to HELLO
|
|
"HELLO REPLY RESULT=OK VERSION=3.1\n"
|
|
// reply to STREAM ACCEPT
|
|
"STREAM STATUS RESULT=OK\n"
|
|
// continued reply to STREAM ACCEPT, violating the protocol described at
|
|
// https://geti2p.net/en/docs/api/samv3#Accept%20Response
|
|
// should be base64, something like
|
|
// "IchV608baDoXbqzQKSqFDmTXPVgoDbPAhZJvNRXXxi4hyFXrTxtoOhdurNApKoUOZNc9WCgNs8CFkm81FdfGLiHIVetPG2g6F26s0CkqhQ5k1z1YKA2zwIWSbzUV18YuIchV608baDoXbqzQKSqFDmTXPVgoDbPAhZJvNRXXxi4hyFXrTxtoOhdurNApKoUOZNc9WCgNs8CFkm81FdfGLiHIVetPG2g6F26s0CkqhQ5k1z1YKA2zwIWSbzUV18YuIchV608baDoXbqzQKSqFDmTXPVgoDbPAhZJvNRXXxi4hyFXrTxtoOhdurNApKoUOZNc9WCgNs8CFkm81FdfGLiHIVetPG2g6F26s0CkqhQ5k1z1YKA2zwIWSbzUV18YuIchV608baDoXbqzQKSqFDmTXPVgoDbPAhZJvNRXXxi4hyFXrTxtoOhdurNApKoUOZNc9WCgNs8CFkm81FdfGLlSreVaCuCS5sdb-8ToWULWP7kt~lRPDeUNxQMq3cRSBBQAEAAcAAA==\n"
|
|
"STREAM STATUS RESULT=I2P_ERROR MESSAGE=\"Session was closed\"\n"
|
|
);
|
|
} else {
|
|
// Another control socket, but without creating a destination (it is cached in the session).
|
|
return std::make_unique<StaticContentsSock>(
|
|
// reply to HELLO
|
|
"HELLO REPLY RESULT=OK VERSION=3.1\n"
|
|
// reply to SESSION CREATE
|
|
"SESSION STATUS RESULT=OK\n"
|
|
// dummy to avoid reporting EOF on the socket
|
|
"a"
|
|
);
|
|
}
|
|
// clang-format on
|
|
};
|
|
|
|
CThreadInterrupt interrupt;
|
|
i2p::sam::Session session(gArgs.GetDataDirNet() / "test_i2p_private_key",
|
|
CService{in6_addr(IN6ADDR_LOOPBACK_INIT), /*port=*/7656},
|
|
&interrupt);
|
|
|
|
i2p::Connection conn;
|
|
for (size_t i = 0; i < 5; ++i) {
|
|
ASSERT_DEBUG_LOG("Creating persistent SAM session");
|
|
ASSERT_DEBUG_LOG("Persistent SAM session" /* ... created */);
|
|
ASSERT_DEBUG_LOG("Error accepting");
|
|
ASSERT_DEBUG_LOG("Destroying SAM session");
|
|
BOOST_REQUIRE(session.Listen(conn));
|
|
BOOST_REQUIRE(!session.Accept(conn));
|
|
}
|
|
}
|
|
|
|
BOOST_AUTO_TEST_CASE(damaged_private_key)
|
|
{
|
|
const auto CreateSockOrig = CreateSock;
|
|
|
|
CreateSock = [](const CService&) {
|
|
return std::make_unique<StaticContentsSock>("HELLO REPLY RESULT=OK VERSION=3.1\n"
|
|
"SESSION STATUS RESULT=OK DESTINATION=\n");
|
|
};
|
|
|
|
const auto i2p_private_key_file = m_args.GetDataDirNet() / "test_i2p_private_key_damaged";
|
|
|
|
for (const auto& [file_contents, expected_error] : std::vector<std::tuple<std::string, std::string>>{
|
|
{"", "The private key is too short (0 < 387)"},
|
|
|
|
{"abcd", "The private key is too short (4 < 387)"},
|
|
|
|
{std::string(386, '\0'), "The private key is too short (386 < 387)"},
|
|
|
|
{std::string(385, '\0') + '\0' + '\1',
|
|
"Certificate length (1) designates that the private key should be 388 bytes, but it is only "
|
|
"387 bytes"},
|
|
|
|
{std::string(385, '\0') + '\0' + '\5' + "abcd",
|
|
"Certificate length (5) designates that the private key should be 392 bytes, but it is only "
|
|
"391 bytes"}}) {
|
|
BOOST_REQUIRE(WriteBinaryFile(i2p_private_key_file, file_contents));
|
|
|
|
CThreadInterrupt interrupt;
|
|
i2p::sam::Session session(i2p_private_key_file, CService{}, &interrupt);
|
|
|
|
{
|
|
ASSERT_DEBUG_LOG("Creating persistent SAM session");
|
|
ASSERT_DEBUG_LOG(expected_error);
|
|
|
|
i2p::Connection conn;
|
|
bool proxy_error;
|
|
BOOST_CHECK(!session.Connect(CService{}, conn, proxy_error));
|
|
}
|
|
}
|
|
|
|
CreateSock = CreateSockOrig;
|
|
}
|
|
|
|
BOOST_AUTO_TEST_SUITE_END()
|