0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-10 10:52:31 -05:00
bitcoin-bitcoin-core/src/qt
Andrew Chow e30b6ea194
Merge bitcoin/bitcoin#24067: wallet: Actually treat (un)confirmed txs as (un)confirmed
fac8165443 Remove unused checkFinalTx (MarcoFalke)
fa272eab44 wallet: Avoid dropping confirmed coins (MarcoFalke)
888841ea8d interfaces: Remove unused is_final (MarcoFalke)
dddd05e7a3 qt: Treat unconfirmed txs as unconfirmed (MarcoFalke)

Pull request description:

  The wallet has several issues:

  ## Unconfirmed txs in the GUI

  The GUI clumsily attempts to guess if unconfirmed txs are locked until a future time. This is currently based on the locktime only, not nSequence, thus wrong. Fix this by removing the clumsy code and treat all unconfirmed txs as unconfirmed. The GUI already prints whether a tx is in the mempool, in which case the user knows that the tx wasn't locked until a future time. If the tx is not in the mempool, it might be better to report the exact reject reason from the mempool instead of using incorrect heuristics.

  ## Confirmed txs in the wallet

  The wallet drops coins that it incorrectly assumes to be locked until a future time, even if they are already confirmed in the chain. This is because the wallet is using the wrong time (adjusted network time) instead of MTP, due to the `-1` default argument of `CheckFinalTx`.

  The issues are fixed in separate commits and there is even a test.

ACKs for top commit:
  achow101:
    ACK fac8165443
  prayank23:
    reACK fac8165443
  glozow:
    code review ACK fac8165443, I understand now how this fixes both issues.

Tree-SHA512: 210afb855f4c6d903fee49eba6b1a9735d699cf0168b669eabb38178e53b3a522258b7cc669f52489c6cd3e38bf358afde12eef3ba2e2f2ffaeb06b8f652ccd0
2022-01-25 16:17:51 -05:00
..
android build, qt: No need to set inapplicable QPA backend for Android 2022-01-03 14:45:39 +02:00
forms Merge bitcoin-core/gui#441: Add Create Unsigned button to SendConfirmationDialog 2022-01-09 17:46:23 +02:00
locale qt: Handle new added plurals in bitcoin_en.ts 2021-08-22 00:03:31 +03:00
res scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
test Merge bitcoin/bitcoin#23373: test: Parse command line arguments from unit and fuzz tests, make addrman consistency check ratio easier to change 2022-01-17 09:10:21 +01:00
addressbookpage.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
addressbookpage.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
addresstablemodel.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
addresstablemodel.h scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
askpassphrasedialog.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
askpassphrasedialog.h scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
bantablemodel.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
bantablemodel.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
bitcoin.cpp Merge bitcoin-core/gui#517: refactor, qt: Use std::chrono for parameters of QTimer methods 2022-01-12 14:59:24 +02:00
bitcoin.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
bitcoin.qrc gui: Add Roboto Mono font 2021-02-21 21:01:02 +02:00
bitcoin_locale.qrc qt: Pre-splitoff translations update 2020-10-27 19:40:44 +01:00
bitcoinaddressvalidator.cpp
bitcoinaddressvalidator.h scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
bitcoinamountfield.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
bitcoinamountfield.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
bitcoingui.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
bitcoingui.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
bitcoinstrings.cpp Translations update 2021-07-01 17:16:14 +03:00
bitcoinunits.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
bitcoinunits.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
clientmodel.cpp Merge bitcoin-core/gui#517: refactor, qt: Use std::chrono for parameters of QTimer methods 2022-01-12 14:59:24 +02:00
clientmodel.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
coincontroldialog.cpp Add src/wallet/* code to wallet:: namespace 2022-01-06 22:14:16 -05:00
coincontroldialog.h Add src/wallet/* code to wallet:: namespace 2022-01-06 22:14:16 -05:00
coincontroltreewidget.cpp
coincontroltreewidget.h
createwalletdialog.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
createwalletdialog.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
csvmodelwriter.cpp
csvmodelwriter.h
editaddressdialog.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
editaddressdialog.h scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
guiconstants.h qt: Treat unconfirmed txs as unconfirmed 2022-01-14 11:24:58 +01:00
guiutil.cpp scripted-diff: Rename functions to drop mention of boost 2022-01-11 18:32:11 +02:00
guiutil.h scripted-diff: Rename functions to drop mention of boost 2022-01-11 18:32:11 +02:00
initexecutor.cpp qt: Keep InitExecutor in main gui thread 2021-09-27 13:05:40 +01:00
initexecutor.h qt: Keep InitExecutor in main gui thread 2021-09-27 13:05:40 +01:00
intro.cpp scripted-diff: Rename functions to drop mention of boost 2022-01-11 18:32:11 +02:00
intro.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
macdockiconhandler.h
macdockiconhandler.mm
macnotificationhandler.h
macnotificationhandler.mm
macos_appnap.h
macos_appnap.mm
main.cpp
Makefile Qt: add Android packaging support 2021-03-21 22:33:27 +01:00
modaloverlay.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
modaloverlay.h scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
networkstyle.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
networkstyle.h
notificator.cpp doc: Use https URLs where possible 2021-01-04 12:23:16 +08:00
notificator.h
openuridialog.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
openuridialog.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
optionsdialog.cpp refactor, qt: Use std::chrono for non-zero arguments in QTimer methods 2022-01-09 17:54:03 +02:00
optionsdialog.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
optionsmodel.cpp scripted-diff: Rename functions to drop mention of boost 2022-01-11 18:32:11 +02:00
optionsmodel.h Merge bitcoin-core/gui#441: Add Create Unsigned button to SendConfirmationDialog 2022-01-09 17:46:23 +02:00
overviewpage.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
overviewpage.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
paymentserver.cpp scripted-diff: Rename functions to drop mention of boost 2022-01-11 18:32:11 +02:00
paymentserver.h scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
peertablemodel.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
peertablemodel.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
peertablesortproxy.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
peertablesortproxy.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
platformstyle.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
platformstyle.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
psbtoperationsdialog.cpp Add src/node/* code to node:: namespace 2022-01-06 22:14:16 -05:00
psbtoperationsdialog.h [gui] PSBT Operations Dialog (sign & broadcast) 2020-06-19 02:20:04 -07:00
qrimagewidget.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
qrimagewidget.h scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
qvalidatedlineedit.cpp
qvalidatedlineedit.h scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
qvaluecombobox.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
qvaluecombobox.h
README.md Improve gui/src/qt README.md 2021-01-28 14:03:21 -05:00
receivecoinsdialog.cpp Merge bitcoin-core/gui#516: Change 'Show' icon 2022-01-04 12:55:29 +02:00
receivecoinsdialog.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
receiverequestdialog.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
receiverequestdialog.h scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
recentrequeststablemodel.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
recentrequeststablemodel.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
rpcconsole.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
rpcconsole.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
sendcoinsdialog.cpp Merge bitcoin-core/gui#517: refactor, qt: Use std::chrono for parameters of QTimer methods 2022-01-12 14:59:24 +02:00
sendcoinsdialog.h Merge bitcoin/bitcoin#23497: Add src/node/ and src/wallet/ code to node:: and wallet:: namespaces 2022-01-11 11:11:00 +01:00
sendcoinsentry.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
sendcoinsentry.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
sendcoinsrecipient.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
signverifymessagedialog.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
signverifymessagedialog.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
splashscreen.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
splashscreen.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
trafficgraphwidget.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
trafficgraphwidget.h
transactiondesc.cpp qt: Treat unconfirmed txs as unconfirmed 2022-01-14 11:24:58 +01:00
transactiondesc.h
transactiondescdialog.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
transactiondescdialog.h
transactionfilterproxy.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
transactionfilterproxy.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
transactionoverviewwidget.h qt: Add TransactionOverviewWidget class 2021-01-05 22:10:10 +02:00
transactionrecord.cpp qt: Treat unconfirmed txs as unconfirmed 2022-01-14 11:24:58 +01:00
transactionrecord.h qt: Treat unconfirmed txs as unconfirmed 2022-01-14 11:24:58 +01:00
transactiontablemodel.cpp qt: Treat unconfirmed txs as unconfirmed 2022-01-14 11:24:58 +01:00
transactiontablemodel.h scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
transactionview.cpp refactor, qt: Use std::chrono for input_filter_delay constant 2022-01-12 12:24:17 +02:00
transactionview.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
utilitydialog.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
utilitydialog.h gui: Remove unused interfaces::Node references 2020-08-26 05:52:31 -04:00
walletcontroller.cpp Merge bitcoin-core/gui#517: refactor, qt: Use std::chrono for parameters of QTimer methods 2022-01-12 14:59:24 +02:00
walletcontroller.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
walletframe.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
walletframe.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
walletmodel.cpp Merge bitcoin/bitcoin#23497: Add src/node/ and src/wallet/ code to node:: and wallet:: namespaces 2022-01-11 11:11:00 +01:00
walletmodel.h Add src/wallet/* code to wallet:: namespace 2022-01-06 22:14:16 -05:00
walletmodeltransaction.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
walletmodeltransaction.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
walletview.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
walletview.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
winshutdownmonitor.cpp
winshutdownmonitor.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00

This directory contains the source code for the Bitcoin Core graphical user interface (GUI). It uses the Qt cross-platform framework.

The current precise version for Qt 5 is specified in qt.mk.

Compile and run

See build instructions: Unix, macOS, Windows, FreeBSD, NetBSD, OpenBSD

When following your systems build instructions, make sure to install the Qt dependencies.

To run:

./src/qt/bitcoin-qt

Files and Directories

forms/

  • A directory that contains Designer UI files. These files specify the characteristics of form elements in XML. Qt UI files can be edited with Qt Creator or using any text editor.

locale/

  • Contains translations. They are periodically updated and an effort is made to support as many languages as possible. The process of contributing translations is described in doc/translation_process.md.

res/

  • Contains graphical resources used to enhance the UI experience.

test/

  • Functional tests used to ensure proper functionality of the GUI. Significant changes to the GUI code normally require new or updated tests.

bitcoingui.(h/cpp)

  • Represents the main window of the Bitcoin UI.

*model.(h/cpp)

  • The model. When it has a corresponding controller, it generally inherits from QAbstractTableModel. Models that are used by controllers as helpers inherit from other Qt classes like QValidator.
  • ClientModel is used by the main application bitcoingui and several models like peertablemodel.

*page.(h/cpp)

  • A controller. :NAMEpage.cpp generally includes :NAMEmodel.h and forms/:NAME.page.ui with a similar :NAME.

*dialog.(h/cpp)

  • Various dialogs, e.g. to open a URL. Inherit from QDialog.

paymentserver.(h/cpp)

  • (Deprecated) Used to process BIP21 payment URI requests. Also handles URI-based application switching (e.g. when following a bitcoin:... link from a browser).

walletview.(h/cpp)

  • Represents the view to a single wallet.

Other .h/cpp files

  • UI elements like BitcoinAmountField, which inherit from QWidget.
  • bitcoinstrings.cpp: automatically generated
  • bitcoinunits.(h/cpp): BTC / mBTC / etc. handling
  • callback.h
  • guiconstants.h: UI colors, app name, etc.
  • guiutil.h: several helper functions
  • macdockiconhandler.(h/mm): macOS dock icon handler
  • macnotificationhandler.(h/mm): display notifications in macOS

Contribute

See CONTRIBUTING.md for general guidelines.

Note: Do not change local/bitcoin_en.ts. It is updated automatically.

Using Qt Creator as an IDE

Qt Creator is a powerful tool which packages a UI designer tool (Qt Designer) and a C++ IDE into one application. This is especially useful if you want to change the UI layout.

Download Qt Creator

On Unix and macOS, Qt Creator can be installed through your package manager. Alternatively, you can download a binary from the Qt Website.

Note: If installing from a binary grabbed from the Qt Website: During the installation process, uncheck everything except for Qt Creator.

macOS
brew install qt-creator
Ubuntu & Debian
sudo apt-get install qtcreator

Setup Qt Creator

  1. Make sure you've installed all dependencies specified in your systems build instructions
  2. Follow the compile instructions for your system, run ./configure with the --enable-debug flag
  3. Start Qt Creator. At the start page, do: New -> Import Project -> Import Existing Project
  4. Enter bitcoin-qt as the Project Name and enter the absolute path to src/qt as Location
  5. Check over the file selection, you may need to select the forms directory (necessary if you intend to edit *.ui files)
  6. Confirm the Summary page
  7. In the Projects tab, select Manage Kits...

macOS

  • Under Kits: select the default "Desktop" kit
  • Under Compilers: select "Clang (x86 64bit in /usr/bin)"
  • Under Debuggers: select "LLDB" as debugger (you might need to set the path to your LLDB installation)

Ubuntu & Debian

Note: Some of these options may already be set

  • Under Kits: select the default "Desktop" kit
  • Under Compilers: select "GCC (x86 64bit in /usr/bin)"
  • Under Debuggers: select "GDB" as debugger
  1. While in the Projects tab, ensure that you have the bitcoin-qt executable specified under Run
  • If the executable is not specified: click "Choose...", navigate to src/qt, and select bitcoin-qt
  1. You're all set! Start developing, building, and debugging the Bitcoin Core GUI