mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-02-08 10:31:50 -05:00
fa103db2bb
SetHex is fragile, because it accepts any non-hex input or any length of input, without error feedback. This can lead to issues when the input is truncated or otherwise corrupted. Document the problem by renaming the method. In the future, the fragile method should be removed from the public interface. -BEGIN VERIFY SCRIPT- sed -i 's/SetHex/SetHexDeprecated/g' $( git grep -l SetHex ./src ) -END VERIFY SCRIPT-
63 lines
1.9 KiB
C++
63 lines
1.9 KiB
C++
// Copyright (c) 2009-2010 Satoshi Nakamoto
|
|
// Copyright (c) 2009-2020 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#include <uint256.h>
|
|
|
|
#include <util/strencodings.h>
|
|
|
|
template <unsigned int BITS>
|
|
std::string base_blob<BITS>::GetHex() const
|
|
{
|
|
uint8_t m_data_rev[WIDTH];
|
|
for (int i = 0; i < WIDTH; ++i) {
|
|
m_data_rev[i] = m_data[WIDTH - 1 - i];
|
|
}
|
|
return HexStr(m_data_rev);
|
|
}
|
|
|
|
template <unsigned int BITS>
|
|
void base_blob<BITS>::SetHexDeprecated(const std::string_view str)
|
|
{
|
|
std::fill(m_data.begin(), m_data.end(), 0);
|
|
|
|
const auto trimmed = util::RemovePrefixView(util::TrimStringView(str), "0x");
|
|
|
|
// Note: if we are passed a greater number of digits than would fit as bytes
|
|
// in m_data, we will be discarding the leftmost ones.
|
|
// str="12bc" in a WIDTH=1 m_data => m_data[] == "\0xbc", not "0x12".
|
|
size_t digits = 0;
|
|
for (const char c : trimmed) {
|
|
if (::HexDigit(c) == -1) break;
|
|
++digits;
|
|
}
|
|
unsigned char* p1 = m_data.data();
|
|
unsigned char* pend = p1 + WIDTH;
|
|
while (digits > 0 && p1 < pend) {
|
|
*p1 = ::HexDigit(trimmed[--digits]);
|
|
if (digits > 0) {
|
|
*p1 |= ((unsigned char)::HexDigit(trimmed[--digits]) << 4);
|
|
p1++;
|
|
}
|
|
}
|
|
}
|
|
|
|
template <unsigned int BITS>
|
|
std::string base_blob<BITS>::ToString() const
|
|
{
|
|
return (GetHex());
|
|
}
|
|
|
|
// Explicit instantiations for base_blob<160>
|
|
template std::string base_blob<160>::GetHex() const;
|
|
template std::string base_blob<160>::ToString() const;
|
|
template void base_blob<160>::SetHexDeprecated(std::string_view);
|
|
|
|
// Explicit instantiations for base_blob<256>
|
|
template std::string base_blob<256>::GetHex() const;
|
|
template std::string base_blob<256>::ToString() const;
|
|
template void base_blob<256>::SetHexDeprecated(std::string_view);
|
|
|
|
const uint256 uint256::ZERO(0);
|
|
const uint256 uint256::ONE(1);
|