mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-02-05 10:17:30 -05:00
2452c6cc0a
102faad81
Factor out combine / finalize / extract PSBT helpers (Glenn Willen)78b9893d0
Remove op== on PSBTs; check compatibility in Merge (Glenn Willen)bd0dbe876
Switch away from exceptions in refactored tx code (Glenn Willen)c6c3d42a7
Move PSBT definitions and code to separate files (Glenn Willen)81cd95884
Factor BroadcastTransaction out of sendrawtransaction (Glenn Willen)c734aaa15
Split DecodePSBT into Base64 and Raw versions (Glenn Willen)162ffefd2
Add pf_invalid arg to std::string DecodeBase{32,64} (Glenn Willen) Pull request description: * Move most PSBT definitions into psbt.h. * Move most PSBT RPC utilities into psbt.{h,cpp}. * Move wallet-touching PSBT RPC utilities (FillPSBT) into wallet/psbtwallet.{h,cpp}. * Switch exceptions from JSONRPCError() to new PSBTException class. * Split DecodePSBT into DecodeBase64PSBT (old behavior) and DecodeRawPSBT. * Add one new version of DecodeBase64 utility in strencodings.h (and corresponding DecodeBase32 for completeness). * Factor BroadcastTransaction utility function out of sendrawtransaction RPC handler in rpc/rawtransaction.cpp Note: For those keeping score at home wondering why refactor, this is in anticipation of (and developed in parallel with) a change to actually introduce GUI use of all this stuff, which is already under development and working-ish. Tree-SHA512: 2197c448e657421f430943025357597e7b06c4c377d5d4b2622b9edea52a7193c48843dd731abb3a88ac4023a9c88d211991e0a9b740c22f2e1cbe72adefe390
511 lines
16 KiB
C++
511 lines
16 KiB
C++
// Copyright (c) 2017-2018 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#include <key_io.h>
|
|
#include <keystore.h>
|
|
#include <policy/fees.h>
|
|
#include <rpc/protocol.h>
|
|
#include <rpc/util.h>
|
|
#include <tinyformat.h>
|
|
#include <util/strencodings.h>
|
|
#include <validation.h>
|
|
|
|
InitInterfaces* g_rpc_interfaces = nullptr;
|
|
|
|
// Converts a hex string to a public key if possible
|
|
CPubKey HexToPubKey(const std::string& hex_in)
|
|
{
|
|
if (!IsHex(hex_in)) {
|
|
throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, "Invalid public key: " + hex_in);
|
|
}
|
|
CPubKey vchPubKey(ParseHex(hex_in));
|
|
if (!vchPubKey.IsFullyValid()) {
|
|
throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, "Invalid public key: " + hex_in);
|
|
}
|
|
return vchPubKey;
|
|
}
|
|
|
|
// Retrieves a public key for an address from the given CKeyStore
|
|
CPubKey AddrToPubKey(CKeyStore* const keystore, const std::string& addr_in)
|
|
{
|
|
CTxDestination dest = DecodeDestination(addr_in);
|
|
if (!IsValidDestination(dest)) {
|
|
throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, "Invalid address: " + addr_in);
|
|
}
|
|
CKeyID key = GetKeyForDestination(*keystore, dest);
|
|
if (key.IsNull()) {
|
|
throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, strprintf("%s does not refer to a key", addr_in));
|
|
}
|
|
CPubKey vchPubKey;
|
|
if (!keystore->GetPubKey(key, vchPubKey)) {
|
|
throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, strprintf("no full public key for address %s", addr_in));
|
|
}
|
|
if (!vchPubKey.IsFullyValid()) {
|
|
throw JSONRPCError(RPC_INTERNAL_ERROR, "Wallet contains an invalid public key");
|
|
}
|
|
return vchPubKey;
|
|
}
|
|
|
|
// Creates a multisig redeemscript from a given list of public keys and number required.
|
|
CScript CreateMultisigRedeemscript(const int required, const std::vector<CPubKey>& pubkeys)
|
|
{
|
|
// Gather public keys
|
|
if (required < 1) {
|
|
throw JSONRPCError(RPC_INVALID_PARAMETER, "a multisignature address must require at least one key to redeem");
|
|
}
|
|
if ((int)pubkeys.size() < required) {
|
|
throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("not enough keys supplied (got %u keys, but need at least %d to redeem)", pubkeys.size(), required));
|
|
}
|
|
if (pubkeys.size() > 16) {
|
|
throw JSONRPCError(RPC_INVALID_PARAMETER, "Number of keys involved in the multisignature address creation > 16\nReduce the number");
|
|
}
|
|
|
|
CScript result = GetScriptForMultisig(required, pubkeys);
|
|
|
|
if (result.size() > MAX_SCRIPT_ELEMENT_SIZE) {
|
|
throw JSONRPCError(RPC_INVALID_PARAMETER, (strprintf("redeemScript exceeds size limit: %d > %d", result.size(), MAX_SCRIPT_ELEMENT_SIZE)));
|
|
}
|
|
|
|
return result;
|
|
}
|
|
|
|
class DescribeAddressVisitor : public boost::static_visitor<UniValue>
|
|
{
|
|
public:
|
|
explicit DescribeAddressVisitor() {}
|
|
|
|
UniValue operator()(const CNoDestination& dest) const
|
|
{
|
|
return UniValue(UniValue::VOBJ);
|
|
}
|
|
|
|
UniValue operator()(const CKeyID& keyID) const
|
|
{
|
|
UniValue obj(UniValue::VOBJ);
|
|
obj.pushKV("isscript", false);
|
|
obj.pushKV("iswitness", false);
|
|
return obj;
|
|
}
|
|
|
|
UniValue operator()(const CScriptID& scriptID) const
|
|
{
|
|
UniValue obj(UniValue::VOBJ);
|
|
obj.pushKV("isscript", true);
|
|
obj.pushKV("iswitness", false);
|
|
return obj;
|
|
}
|
|
|
|
UniValue operator()(const WitnessV0KeyHash& id) const
|
|
{
|
|
UniValue obj(UniValue::VOBJ);
|
|
obj.pushKV("isscript", false);
|
|
obj.pushKV("iswitness", true);
|
|
obj.pushKV("witness_version", 0);
|
|
obj.pushKV("witness_program", HexStr(id.begin(), id.end()));
|
|
return obj;
|
|
}
|
|
|
|
UniValue operator()(const WitnessV0ScriptHash& id) const
|
|
{
|
|
UniValue obj(UniValue::VOBJ);
|
|
obj.pushKV("isscript", true);
|
|
obj.pushKV("iswitness", true);
|
|
obj.pushKV("witness_version", 0);
|
|
obj.pushKV("witness_program", HexStr(id.begin(), id.end()));
|
|
return obj;
|
|
}
|
|
|
|
UniValue operator()(const WitnessUnknown& id) const
|
|
{
|
|
UniValue obj(UniValue::VOBJ);
|
|
obj.pushKV("iswitness", true);
|
|
obj.pushKV("witness_version", (int)id.version);
|
|
obj.pushKV("witness_program", HexStr(id.program, id.program + id.length));
|
|
return obj;
|
|
}
|
|
};
|
|
|
|
UniValue DescribeAddress(const CTxDestination& dest)
|
|
{
|
|
return boost::apply_visitor(DescribeAddressVisitor(), dest);
|
|
}
|
|
|
|
unsigned int ParseConfirmTarget(const UniValue& value)
|
|
{
|
|
int target = value.get_int();
|
|
unsigned int max_target = ::feeEstimator.HighestTargetTracked(FeeEstimateHorizon::LONG_HALFLIFE);
|
|
if (target < 1 || (unsigned int)target > max_target) {
|
|
throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid conf_target, must be between %u - %u", 1, max_target));
|
|
}
|
|
return (unsigned int)target;
|
|
}
|
|
|
|
RPCErrorCode RPCErrorFromTransactionError(TransactionError terr)
|
|
{
|
|
switch (terr) {
|
|
case TransactionError::MEMPOOL_REJECTED:
|
|
return RPC_TRANSACTION_REJECTED;
|
|
case TransactionError::ALREADY_IN_CHAIN:
|
|
return RPC_TRANSACTION_ALREADY_IN_CHAIN;
|
|
case TransactionError::P2P_DISABLED:
|
|
return RPC_CLIENT_P2P_DISABLED;
|
|
case TransactionError::INVALID_PSBT:
|
|
case TransactionError::PSBT_MISMATCH:
|
|
return RPC_INVALID_PARAMETER;
|
|
case TransactionError::SIGHASH_MISMATCH:
|
|
return RPC_DESERIALIZATION_ERROR;
|
|
default: break;
|
|
}
|
|
return RPC_TRANSACTION_ERROR;
|
|
}
|
|
|
|
UniValue JSONRPCTransactionError(TransactionError terr, const std::string& err_string)
|
|
{
|
|
if (err_string.length() > 0) {
|
|
return JSONRPCError(RPCErrorFromTransactionError(terr), err_string);
|
|
} else {
|
|
return JSONRPCError(RPCErrorFromTransactionError(terr), TransactionErrorString(terr));
|
|
}
|
|
}
|
|
|
|
struct Section {
|
|
Section(const std::string& left, const std::string& right)
|
|
: m_left{left}, m_right{right} {}
|
|
const std::string m_left;
|
|
const std::string m_right;
|
|
};
|
|
|
|
struct Sections {
|
|
std::vector<Section> m_sections;
|
|
size_t m_max_pad{0};
|
|
|
|
void PushSection(const Section& s)
|
|
{
|
|
m_max_pad = std::max(m_max_pad, s.m_left.size());
|
|
m_sections.push_back(s);
|
|
}
|
|
|
|
enum class OuterType {
|
|
ARR,
|
|
OBJ,
|
|
NAMED_ARG, // Only set on first recursion
|
|
};
|
|
|
|
void Push(const RPCArg& arg, const size_t current_indent = 5, const OuterType outer_type = OuterType::NAMED_ARG)
|
|
{
|
|
const auto indent = std::string(current_indent, ' ');
|
|
const auto indent_next = std::string(current_indent + 2, ' ');
|
|
switch (arg.m_type) {
|
|
case RPCArg::Type::STR_HEX:
|
|
case RPCArg::Type::STR:
|
|
case RPCArg::Type::NUM:
|
|
case RPCArg::Type::AMOUNT:
|
|
case RPCArg::Type::BOOL: {
|
|
if (outer_type == OuterType::NAMED_ARG) return; // Nothing more to do for non-recursive types on first recursion
|
|
auto left = indent;
|
|
if (arg.m_type_str.size() != 0 && outer_type == OuterType::OBJ) {
|
|
left += "\"" + arg.m_name + "\": " + arg.m_type_str.at(0);
|
|
} else {
|
|
left += outer_type == OuterType::OBJ ? arg.ToStringObj(/* oneline */ false) : arg.ToString(/* oneline */ false);
|
|
}
|
|
left += ",";
|
|
PushSection({left, arg.ToDescriptionString()});
|
|
break;
|
|
}
|
|
case RPCArg::Type::OBJ:
|
|
case RPCArg::Type::OBJ_USER_KEYS: {
|
|
const auto right = outer_type == OuterType::NAMED_ARG ? "" : arg.ToDescriptionString();
|
|
PushSection({indent + "{", right});
|
|
for (const auto& arg_inner : arg.m_inner) {
|
|
Push(arg_inner, current_indent + 2, OuterType::OBJ);
|
|
}
|
|
if (arg.m_type != RPCArg::Type::OBJ) {
|
|
PushSection({indent_next + "...", ""});
|
|
}
|
|
PushSection({indent + "}" + (outer_type != OuterType::NAMED_ARG ? "," : ""), ""});
|
|
break;
|
|
}
|
|
case RPCArg::Type::ARR: {
|
|
auto left = indent;
|
|
left += outer_type == OuterType::OBJ ? "\"" + arg.m_name + "\": " : "";
|
|
left += "[";
|
|
const auto right = outer_type == OuterType::NAMED_ARG ? "" : arg.ToDescriptionString();
|
|
PushSection({left, right});
|
|
for (const auto& arg_inner : arg.m_inner) {
|
|
Push(arg_inner, current_indent + 2, OuterType::ARR);
|
|
}
|
|
PushSection({indent_next + "...", ""});
|
|
PushSection({indent + "]" + (outer_type != OuterType::NAMED_ARG ? "," : ""), ""});
|
|
break;
|
|
}
|
|
|
|
// no default case, so the compiler can warn about missing cases
|
|
}
|
|
}
|
|
|
|
std::string ToString() const
|
|
{
|
|
std::string ret;
|
|
const size_t pad = m_max_pad + 4;
|
|
for (const auto& s : m_sections) {
|
|
if (s.m_right.empty()) {
|
|
ret += s.m_left;
|
|
ret += "\n";
|
|
continue;
|
|
}
|
|
|
|
std::string left = s.m_left;
|
|
left.resize(pad, ' ');
|
|
ret += left;
|
|
|
|
// Properly pad after newlines
|
|
std::string right;
|
|
size_t begin = 0;
|
|
size_t new_line_pos = s.m_right.find_first_of('\n');
|
|
while (true) {
|
|
right += s.m_right.substr(begin, new_line_pos - begin);
|
|
if (new_line_pos == std::string::npos) {
|
|
break; //No new line
|
|
}
|
|
right += "\n" + std::string(pad, ' ');
|
|
begin = s.m_right.find_first_not_of(' ', new_line_pos + 1);
|
|
if (begin == std::string::npos) {
|
|
break; // Empty line
|
|
}
|
|
new_line_pos = s.m_right.find_first_of('\n', begin + 1);
|
|
}
|
|
ret += right;
|
|
ret += "\n";
|
|
}
|
|
return ret;
|
|
}
|
|
};
|
|
|
|
RPCHelpMan::RPCHelpMan(std::string name, std::string description, std::vector<RPCArg> args, RPCResults results, RPCExamples examples)
|
|
: m_name{std::move(name)},
|
|
m_description{std::move(description)},
|
|
m_args{std::move(args)},
|
|
m_results{std::move(results)},
|
|
m_examples{std::move(examples)}
|
|
{
|
|
std::set<std::string> named_args;
|
|
for (const auto& arg : m_args) {
|
|
// Should have unique named arguments
|
|
assert(named_args.insert(arg.m_name).second);
|
|
}
|
|
}
|
|
|
|
std::string RPCResults::ToDescriptionString() const
|
|
{
|
|
std::string result;
|
|
for (const auto& r : m_results) {
|
|
if (r.m_cond.empty()) {
|
|
result += "\nResult:\n";
|
|
} else {
|
|
result += "\nResult (" + r.m_cond + "):\n";
|
|
}
|
|
result += r.m_result;
|
|
}
|
|
return result;
|
|
}
|
|
|
|
std::string RPCExamples::ToDescriptionString() const
|
|
{
|
|
return m_examples.empty() ? m_examples : "\nExamples:\n" + m_examples;
|
|
}
|
|
|
|
std::string RPCHelpMan::ToString() const
|
|
{
|
|
std::string ret;
|
|
|
|
// Oneline summary
|
|
ret += m_name;
|
|
bool was_optional{false};
|
|
for (const auto& arg : m_args) {
|
|
bool optional;
|
|
if (arg.m_fallback.which() == 1) {
|
|
optional = true;
|
|
} else {
|
|
optional = RPCArg::Optional::NO != boost::get<RPCArg::Optional>(arg.m_fallback);
|
|
}
|
|
ret += " ";
|
|
if (optional) {
|
|
if (!was_optional) ret += "( ";
|
|
was_optional = true;
|
|
} else {
|
|
if (was_optional) ret += ") ";
|
|
was_optional = false;
|
|
}
|
|
ret += arg.ToString(/* oneline */ true);
|
|
}
|
|
if (was_optional) ret += " )";
|
|
ret += "\n";
|
|
|
|
// Description
|
|
ret += m_description;
|
|
|
|
// Arguments
|
|
Sections sections;
|
|
for (size_t i{0}; i < m_args.size(); ++i) {
|
|
const auto& arg = m_args.at(i);
|
|
|
|
if (i == 0) ret += "\nArguments:\n";
|
|
|
|
// Push named argument name and description
|
|
sections.m_sections.emplace_back(std::to_string(i + 1) + ". " + arg.m_name, arg.ToDescriptionString());
|
|
sections.m_max_pad = std::max(sections.m_max_pad, sections.m_sections.back().m_left.size());
|
|
|
|
// Recursively push nested args
|
|
sections.Push(arg);
|
|
}
|
|
ret += sections.ToString();
|
|
|
|
// Result
|
|
ret += m_results.ToDescriptionString();
|
|
|
|
// Examples
|
|
ret += m_examples.ToDescriptionString();
|
|
|
|
return ret;
|
|
}
|
|
|
|
std::string RPCArg::ToDescriptionString() const
|
|
{
|
|
std::string ret;
|
|
ret += "(";
|
|
if (m_type_str.size() != 0) {
|
|
ret += m_type_str.at(1);
|
|
} else {
|
|
switch (m_type) {
|
|
case Type::STR_HEX:
|
|
case Type::STR: {
|
|
ret += "string";
|
|
break;
|
|
}
|
|
case Type::NUM: {
|
|
ret += "numeric";
|
|
break;
|
|
}
|
|
case Type::AMOUNT: {
|
|
ret += "numeric or string";
|
|
break;
|
|
}
|
|
case Type::BOOL: {
|
|
ret += "boolean";
|
|
break;
|
|
}
|
|
case Type::OBJ:
|
|
case Type::OBJ_USER_KEYS: {
|
|
ret += "json object";
|
|
break;
|
|
}
|
|
case Type::ARR: {
|
|
ret += "json array";
|
|
break;
|
|
}
|
|
|
|
// no default case, so the compiler can warn about missing cases
|
|
}
|
|
}
|
|
if (m_fallback.which() == 1) {
|
|
ret += ", optional, default=" + boost::get<std::string>(m_fallback);
|
|
} else {
|
|
switch (boost::get<RPCArg::Optional>(m_fallback)) {
|
|
case RPCArg::Optional::OMITTED: {
|
|
// nothing to do. Element is treated as if not present and has no default value
|
|
break;
|
|
}
|
|
case RPCArg::Optional::OMITTED_NAMED_ARG: {
|
|
ret += ", optional"; // Default value is "null"
|
|
break;
|
|
}
|
|
case RPCArg::Optional::NO: {
|
|
ret += ", required";
|
|
break;
|
|
}
|
|
|
|
// no default case, so the compiler can warn about missing cases
|
|
}
|
|
}
|
|
ret += ")";
|
|
ret += m_description.empty() ? "" : " " + m_description;
|
|
return ret;
|
|
}
|
|
|
|
std::string RPCArg::ToStringObj(const bool oneline) const
|
|
{
|
|
std::string res;
|
|
res += "\"";
|
|
res += m_name;
|
|
if (oneline) {
|
|
res += "\":";
|
|
} else {
|
|
res += "\": ";
|
|
}
|
|
switch (m_type) {
|
|
case Type::STR:
|
|
return res + "\"str\"";
|
|
case Type::STR_HEX:
|
|
return res + "\"hex\"";
|
|
case Type::NUM:
|
|
return res + "n";
|
|
case Type::AMOUNT:
|
|
return res + "amount";
|
|
case Type::BOOL:
|
|
return res + "bool";
|
|
case Type::ARR:
|
|
res += "[";
|
|
for (const auto& i : m_inner) {
|
|
res += i.ToString(oneline) + ",";
|
|
}
|
|
return res + "...]";
|
|
case Type::OBJ:
|
|
case Type::OBJ_USER_KEYS:
|
|
// Currently unused, so avoid writing dead code
|
|
assert(false);
|
|
|
|
// no default case, so the compiler can warn about missing cases
|
|
}
|
|
assert(false);
|
|
}
|
|
|
|
std::string RPCArg::ToString(const bool oneline) const
|
|
{
|
|
if (oneline && !m_oneline_description.empty()) return m_oneline_description;
|
|
|
|
switch (m_type) {
|
|
case Type::STR_HEX:
|
|
case Type::STR: {
|
|
return "\"" + m_name + "\"";
|
|
}
|
|
case Type::NUM:
|
|
case Type::AMOUNT:
|
|
case Type::BOOL: {
|
|
return m_name;
|
|
}
|
|
case Type::OBJ:
|
|
case Type::OBJ_USER_KEYS: {
|
|
std::string res;
|
|
for (size_t i = 0; i < m_inner.size();) {
|
|
res += m_inner[i].ToStringObj(oneline);
|
|
if (++i < m_inner.size()) res += ",";
|
|
}
|
|
if (m_type == Type::OBJ) {
|
|
return "{" + res + "}";
|
|
} else {
|
|
return "{" + res + ",...}";
|
|
}
|
|
}
|
|
case Type::ARR: {
|
|
std::string res;
|
|
for (const auto& i : m_inner) {
|
|
res += i.ToString(oneline) + ",";
|
|
}
|
|
return "[" + res + "...]";
|
|
}
|
|
|
|
// no default case, so the compiler can warn about missing cases
|
|
}
|
|
assert(false);
|
|
}
|