Ava Chow 058af75874 Merge bitcoin/bitcoin#29817: kernel: De-globalize fReindex ... b47bd95920 kernel: De-globalize fReindex (TheCharlatan) Pull request description: fReindex is one of the last remaining globals exposed by the kernel library, so move it into the blockstorage class to reduce the amount of global mutable state and make the kernel library a bit less awkward to use. --- This pull request is part of the [libbitcoinkernel project](https://github.com/bitcoin/bitcoin/issues/27587). ACKs for top commit: achow101: ACK b47bd95920 ryanofsky: Code review ACK b47bd95920. I rereviewed the whole PR, but the only change since last review was reverting the bugfix https://github.com/bitcoin/bitcoin/pull/29817#discussion_r1578327024 and make the change a pure refactoring. mzumsande: Code Review ACK b47bd95920 stickies-v: ACK b47bd95920 Tree-SHA512: f7399d01f93bc0c0c7428fe95d19b9d29b4ed00a4f1deabca78fb0c4fecb434ec971e890feecb105938b5247c926850b1b7b4a4a9caa333a061e40777d0c8463		2024-05-17 15:50:56 -04:00
..
bench	Merge bitcoin/bitcoin#29975: blockstorage: Separate reindexing from saving new blocks	2024-05-16 11:16:08 -04:00
common	scripted-diff: Add IWYU pragma keep to bitcoin-config.h includes	2024-05-01 08:33:04 +02:00
compat	netbase: refactor CreateSock() to accept sa_family_t	2024-03-01 13:13:07 -05:00
config
consensus
crc32c	Update crc32c subtree to latest upstream master	2024-02-27 18:28:19 +00:00
crypto	crypto: disable asan for sha256_sse4 with clang and -O0	2024-05-15 13:50:25 +00:00
index	index: race fix, lock cs_main while 'm_synced' is subject to change	2024-04-17 17:24:05 -03:00
init	scripted-diff: Add IWYU pragma keep to bitcoin-config.h includes	2024-05-01 08:33:04 +02:00
interfaces	wallet: return and display signer error	2024-04-16 17:47:43 +02:00
ipc	multiprocess: Add type conversion code for UniValue types	2023-11-28 12:35:50 -05:00
kernel	kernel: De-globalize fReindex	2024-05-16 11:28:46 +02:00
leveldb
logging
minisketch	Update minisketch subtree to latest master	2024-04-12 14:27:45 +02:00
node	Merge bitcoin/bitcoin#29817: kernel: De-globalize fReindex	2024-05-17 15:50:56 -04:00
policy	Merge bitcoin/bitcoin#30024: doc: replace remaining "520" magic nums with MAX_SCRIPT_ELEMENT_SIZE	2024-05-03 12:36:56 -04:00
primitives	Merge bitcoin/bitcoin#28929: serialization: Support for multiple parameters	2024-05-15 15:09:56 -04:00
qt	Merge bitcoin-core/gui#722: wallet: Allow user to navigate options while encrypting at creation	2024-05-15 18:41:15 +01:00
rpc	Merge bitcoin/bitcoin#27101: Support JSON-RPC 2.0 when requested by client	2024-05-16 10:18:04 -04:00
script	miniscript: make operator_mst consteval	2024-05-03 11:38:14 -04:00
secp256k1	Update secp256k1 subtree to latest master	2024-04-04 12:05:16 +01:00
support	scripted-diff: Fix bitcoin_config_h includes	2024-02-13 20:10:44 +00:00
test	Merge bitcoin/bitcoin#29817: kernel: De-globalize fReindex	2024-05-17 15:50:56 -04:00
univalue	test: Fix failing univalue float test	2024-04-16 16:35:12 +02:00
util	refactor, subprocess: Remove unused stream API calls	2024-05-10 14:58:27 +01:00
wallet	Merge bitcoin/bitcoin#28336: rpc: parse legacy pubkeys consistently with specific error messages	2024-05-08 17:52:58 -04:00
zmq	zmq: accept unix domain socket address for notifier	2024-04-16 14:14:37 -04:00
.bear-tidy-config
.clang-format	refactor: Print verbose serialize compiler error messages	2023-12-15 15:20:54 +01:00
.clang-tidy	[clang-tidy] Enable the misc-no-recursion check	2024-04-07 14:04:45 +01:00
addrdb.cpp	scripted-diff: Add IWYU pragma keep to bitcoin-config.h includes	2024-05-01 08:33:04 +02:00
addrdb.h
addresstype.cpp
addresstype.h
addrman.cpp	Merge bitcoin/bitcoin#28929: serialization: Support for multiple parameters	2024-05-15 15:09:56 -04:00
addrman.h	doc, test: Test and explain service flag handling	2024-01-15 16:19:53 -05:00
addrman_impl.h	Remove timedata	2024-04-10 17:01:27 +02:00
arith_uint256.cpp	refactor: Remove unused and fragile string interface from arith_uint256	2023-11-21 17:37:25 +01:00
arith_uint256.h	refactor: Remove unused and fragile string interface from arith_uint256	2023-11-21 17:37:25 +01:00
attributes.h
banman.cpp
banman.h
base58.cpp
base58.h
bech32.cpp
bech32.h
bip324.cpp
bip324.h
bitcoin-chainstate.cpp	kernel: De-globalize fReindex	2024-05-16 11:28:46 +02:00
bitcoin-cli-res.rc
bitcoin-cli.cpp	Merge bitcoin/bitcoin#27101: Support JSON-RPC 2.0 when requested by client	2024-05-16 10:18:04 -04:00
bitcoin-tx-res.rc
bitcoin-tx.cpp	tools: Use ECC_Context helper in bitcoin-tx and bitcoin-wallet tools	2024-05-09 15:56:06 +02:00
bitcoin-util-res.rc
bitcoin-util.cpp	scripted-diff: Add IWYU pragma keep to bitcoin-config.h includes	2024-05-01 08:33:04 +02:00
bitcoin-wallet-res.rc
bitcoin-wallet.cpp	tools: Use ECC_Context helper in bitcoin-tx and bitcoin-wallet tools	2024-05-09 15:56:06 +02:00
bitcoind-res.rc
bitcoind.cpp	kernel: Remove key module from kernel library	2024-05-09 15:56:08 +02:00
blockencodings.cpp	refactor: Simplify extra_txn to be a vec of CTransactionRef instead of a vec of pair<Wtxid, CTransactionRef>	2024-04-06 19:17:20 +01:00
blockencodings.h	refactor: Simplify extra_txn to be a vec of CTransactionRef instead of a vec of pair<Wtxid, CTransactionRef>	2024-04-06 19:17:20 +01:00
blockfilter.cpp	refactor: SpanReader without nVersion	2023-11-28 12:42:07 +01:00
blockfilter.h
chain.cpp
chain.h	assumeutxo: Remove BLOCK_ASSUMED_VALID flag	2024-03-18 11:28:40 -05:00
chainparams.cpp
chainparams.h
chainparamsbase.cpp
chainparamsbase.h
chainparamsseeds.h	seeds: Update testnet seeds	2024-03-04 19:53:30 -05:00
checkqueue.h
clientversion.cpp	refactor: simplify FormatSubVersion using strprintf/Join	2024-05-13 23:31:46 +02:00
clientversion.h	scripted-diff: Add IWYU pragma keep to bitcoin-config.h includes	2024-05-01 08:33:04 +02:00
coins.cpp	Use Txid in COutpoint	2023-11-21 13:15:44 +00:00
coins.h	Merge bitcoin/bitcoin#28922: Use Txid in COutpoint	2023-11-24 14:41:58 +00:00
compressor.cpp
compressor.h
core_io.h	Remove deprecated -rpcserialversion	2023-12-11 18:22:13 +01:00
core_memusage.h
core_read.cpp	rpc: Reword SighashFromStr error message	2024-04-15 10:01:15 +02:00
core_write.cpp	Remove deprecated -rpcserialversion	2023-12-11 18:22:13 +01:00
cuckoocache.h	doc: fix some typos	2024-03-26 16:51:46 +00:00
dbwrapper.cpp
dbwrapper.h
deploymentinfo.cpp
deploymentinfo.h
deploymentstatus.cpp
deploymentstatus.h
dummywallet.cpp
external_signer.cpp	external_signer: replace boost::process with cpp-subprocess	2024-03-27 14:16:37 +00:00
external_signer.h
flatfile.cpp	scripted-diff: Replace error() with LogError()	2024-03-11 13:49:37 +01:00
flatfile.h
hash.cpp	crypto, hash: replace custom rotl32 with std::rotl	2024-01-05 17:12:38 +01:00
hash.h
headerssync.cpp	refactor: Fix timedata includes	2024-02-01 13:52:05 +01:00
headerssync.h
httprpc.cpp	rpc: JSON-RPC 2.0 should not respond to "notifications"	2024-05-14 11:28:43 -04:00
httprpc.h
httpserver.cpp	scripted-diff: Add IWYU pragma keep to bitcoin-config.h includes	2024-05-01 08:33:04 +02:00
httpserver.h	refactor: Remove call to ShutdownRequested from HTTPRequest	2023-12-04 15:39:15 -04:00
i2p.cpp	Merge bitcoin/bitcoin#27375: net: support unix domain sockets for -proxy and -onion	2024-03-13 06:53:07 -04:00
i2p.h	i2p: construct Session with Proxy instead of CService	2024-03-01 14:47:29 -05:00
indirectmap.h
init.cpp	kernel: De-globalize fReindex	2024-05-16 11:28:46 +02:00
init.h	Get rid of shutdown.cpp/shutdown.h, use SignalInterrupt directly	2023-12-04 15:39:15 -04:00
key.cpp	Refactor: Remove ECC_Start and ECC_Stop from key header	2024-05-09 15:56:10 +02:00
key.h	Refactor: Remove ECC_Start and ECC_Stop from key header	2024-05-09 15:56:10 +02:00
key_io.cpp	refactor: Allow std::span construction from CKey	2024-01-16 15:29:18 +01:00
key_io.h
logging.cpp	logging: remove unused BCLog::UTIL	2024-02-11 15:25:07 +01:00
logging.h	Merge bitcoin/bitcoin#29419: log: deduplicate category names and improve logging.cpp	2024-04-02 10:47:05 -04:00
Makefile.am	Merge bitcoin/bitcoin#30083: kernel: Remove batchpriority from kernel library	2024-05-14 11:20:33 -04:00
Makefile.bench.include	bench: basic block filter index initial sync	2024-03-12 09:30:42 -03:00
Makefile.crc32c.include
Makefile.leveldb.include
Makefile.minisketch.include	build: remove minisketch clz check	2024-04-12 14:28:34 +02:00
Makefile.qt.include
Makefile.qt_locale.include	qt: 27.0 translations update	2024-03-04 10:02:26 +00:00
Makefile.qttest.include
Makefile.test.include	Merge bitcoin/bitcoin#29623: Simplify network-adjusted time warning logic	2024-04-30 18:49:34 -04:00
Makefile.test_fuzz.include	fuzz: move MockedDescriptorConverter to fuzz/util	2023-11-20 15:57:50 -03:00
Makefile.test_util.include
Makefile.univalue.include
mapport.cpp	scripted-diff: Add IWYU pragma keep to bitcoin-config.h includes	2024-05-01 08:33:04 +02:00
mapport.h
memusage.h
merkleblock.cpp	[clang-tidy] Enable the misc-no-recursion check	2024-04-07 14:04:45 +01:00
merkleblock.h	refactor: Use Txid in CMerkleBlock	2023-11-28 17:49:41 +01:00
net.cpp	Merge bitcoin/bitcoin#30085: p2p: detect addnode cjdns peers in GetAddedNodeInfo()	2024-05-16 11:18:26 +08:00
net.h	Merge bitcoin/bitcoin#29984: net: Replace ifname check with IFF_LOOPBACK in Discover	2024-05-07 10:28:58 +08:00
net_permissions.cpp	Accept "in" and "out" flags to -whitelist to allow whitelisting manual connections	2024-02-28 10:05:56 -03:00
net_permissions.h	Accept "in" and "out" flags to -whitelist to allow whitelisting manual connections	2024-02-28 10:05:56 -03:00
net_processing.cpp	Merge bitcoin/bitcoin#30000: p2p: index TxOrphanage by wtxid, allow entries with same txid	2024-05-15 09:56:17 -04:00
net_processing.h	[net processing] Move IgnoresIncomingTxs to PeerManagerInfo	2024-04-10 17:01:27 +02:00
net_types.cpp
net_types.h
netaddress.cpp	netbase: refactor CreateSock() to accept sa_family_t	2024-03-01 13:13:07 -05:00
netaddress.h	Merge bitcoin/bitcoin#28929: serialization: Support for multiple parameters	2024-05-15 15:09:56 -04:00
netbase.cpp	scripted-diff: Add IWYU pragma keep to bitcoin-config.h includes	2024-05-01 08:33:04 +02:00
netbase.h	net: split ConnectToSocket() from ConnectDirectly() for unix sockets	2024-03-01 14:47:28 -05:00
netgroup.cpp	Merge bitcoin/bitcoin#27581: net: Continuous ASMap health check	2023-12-06 11:22:42 -05:00
netgroup.h	net: Add continuous ASMap health check logging	2023-12-02 22:03:08 +01:00
netmessagemaker.h	refactor: NetMsg::Make() without nVersion	2023-11-20 14:02:27 +01:00
noui.cpp	node: Use log levels in noui_ThreadSafeMessageBox	2024-03-21 16:41:16 +01:00
noui.h
outputtype.cpp	Replace remaining "520" magic numbers with MAX_SCRIPT_ELEMENT_SIZE	2024-05-02 13:16:40 -06:00
outputtype.h
pow.cpp
pow.h
prevector.h	refactor: Mark prevector iterator with std::contiguous_iterator_tag	2024-01-18 19:29:34 +01:00
protocol.cpp	net: remove now unused global 'g_initial_block_download_completed'	2024-01-23 10:25:16 -03:00
protocol.h	Merge bitcoin/bitcoin#28929: serialization: Support for multiple parameters	2024-05-15 15:09:56 -04:00
psbt.cpp	Remove unused version.h include	2023-11-30 11:28:19 +01:00
psbt.h	refactor: SpanReader without nVersion	2023-11-28 12:42:07 +01:00
pubkey.cpp	crypto: add NUMS_H const	2024-05-14 10:24:31 +02:00
pubkey.h	crypto: add NUMS_H const	2024-05-14 10:24:31 +02:00
random.cpp	scripted-diff: Add IWYU pragma keep to bitcoin-config.h includes	2024-05-01 08:33:04 +02:00
random.h	crypto: replace CountBits with std::bit_width	2024-02-26 16:13:12 +00:00
randomenv.cpp	scripted-diff: Add IWYU pragma keep to bitcoin-config.h includes	2024-05-01 08:33:04 +02:00
randomenv.h
rest.cpp	scripted-diff: Add IWYU pragma keep to bitcoin-config.h includes	2024-05-01 08:33:04 +02:00
rest.h
reverse_iterator.h
scheduler.cpp	scripted-diff: Rename SingleThreadedSchedulerClient to SerialTaskRunner	2024-02-15 14:43:14 +01:00
scheduler.h	kernel: Remove dependency on CScheduler	2024-02-16 17:12:52 +01:00
serialize.h	Merge bitcoin/bitcoin#28929: serialization: Support for multiple parameters	2024-05-15 15:09:56 -04:00
signet.cpp	refactor: SpanReader without nVersion	2023-11-28 12:42:07 +01:00
signet.h
span.h	Allow int8_t optimized vector serialization	2023-12-22 09:58:19 +01:00
streams.cpp
streams.h	Remove unused CDataStream	2023-11-30 11:27:54 +01:00
sync.cpp	scripted-diff: Fix bitcoin_config_h includes	2024-02-13 20:10:44 +00:00
sync.h
threadsafety.h
tinyformat.h
torcontrol.cpp	Merge bitcoin/bitcoin#28318: logging: Simplify API for level based logging	2024-01-10 14:11:32 -05:00
torcontrol.h
txdb.cpp
txdb.h
txmempool.cpp	refactor: Simply include CTxMemPool::Options in CTxMemPool directly rather than duplicating definition	2024-05-06 20:34:10 +00:00
txmempool.h	refactor: Simply include CTxMemPool::Options in CTxMemPool directly rather than duplicating definition	2024-05-06 20:34:10 +00:00
txorphanage.cpp	Merge bitcoin/bitcoin#30000: p2p: index TxOrphanage by wtxid, allow entries with same txid	2024-05-15 09:56:17 -04:00
txorphanage.h	[p2p] allow entries with the same txid in TxOrphanage	2024-05-14 10:32:28 +01:00
txrequest.cpp	refactor: modernize-use-default-member-init for bit-fields (C++20)	2023-12-07 11:06:01 +01:00
txrequest.h
uint256.cpp
uint256.h
undo.h
validation.cpp	Merge bitcoin/bitcoin#29817: kernel: De-globalize fReindex	2024-05-17 15:50:56 -04:00
validation.h	[refactor] make MempoolAcceptResult::m_replaced_transactions non-optional	2024-05-01 13:34:37 +01:00
validationinterface.cpp	kernel: Remove dependency on CScheduler	2024-02-16 17:12:52 +01:00
validationinterface.h	kernel: Remove dependency on CScheduler	2024-02-16 17:12:52 +01:00
versionbits.cpp
versionbits.h
walletinitinterface.h
warnings.cpp	Merge bitcoin/bitcoin#29494: build: Assume HAVE_CONFIG_H, Add IWYU pragma keep to bitcoin-config.h includes	2024-05-07 14:14:03 -04:00
warnings.h	rpc: return warnings as an array instead of just a single one	2024-05-01 14:44:57 +01:00