foster/bitcoin-bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-05 10:17:30 -05:00
Code Issues Activity
bitcoin-bitcoin-core/src/wallet
History
MeshCollider ef802ef5d6
Merge #15880: utils and libraries: Replace deprecated Boost Filesystem functions 
a0a222eec Replace deprecated Boost Filesystem function (Hennadii Stepanov)
4f65af97b Remove dead code for walletFile check (Hennadii Stepanov)

Pull request description:

  Boost Filesystem `basename()` and `extension()` functions are [deprecated since v1.36.0](https://www.boost.org/doc/libs/1_36_0/libs/filesystem/doc/reference.html#Convenience-functions).

  See more: https://lists.boost.org/Archives/boost/2010/01/160905.php

  Also this PR prevents further use of deprecated Boost Filesystem functions.
  Ref: https://www.boost.org/doc/libs/1_64_0/libs/filesystem/doc/index.htm#Coding-guidelines

  Note: On my Linux system Boost 1.65.1 header `/usr/include/boost/filesystem/convenience.hpp` contains:
  ```c++
  # ifndef BOOST_FILESYSTEM_NO_DEPRECATED

      inline std::string extension(const path & p)
      {
        return p.extension().string();
      }

      inline std::string basename(const path & p)
      {
        return p.stem().string();
      }

      inline path change_extension( const path & p, const path & new_extension )
      {
        path new_p( p );
        new_p.replace_extension( new_extension );
        return new_p;
      }

  # endif
  ```

  UPDATE:
  Also removed unused code as [noted](https://github.com/bitcoin/bitcoin/pull/15880#discussion_r279386614) by **ryanofsky**.

ACKs for commit a0a222:
  Empact:
    utACK a0a222eec0
  practicalswift:
    utACK a0a222eec0
  fanquake:
    utACK a0a222e
  ryanofsky:
    utACK a0a222eec0. Only change is dropping assert and squashing first two commits.

Tree-SHA512: bc54355441c49957507eb8d3a5782b92d65674504d69779bc16b1b997b2e7424d5665eb6bfb6e10b430a6cacd2aca70af2f94e5f7f10bea24624202834ad35c7
2019-05-09 00:01:29 +12:00
..
test scripted-diff: replace chainActive -> ::ChainActive() 2019-05-03 15:02:54 -04:00
coincontrol.cpp scripted-diff: Move util files to separate directory. 2018-11-04 22:46:07 -08:00
coincontrol.h generalize bumpfee to add inputs when needed 2019-04-11 07:21:49 -04:00
coinselection.cpp Introduce a Shuffle for FastRandomContext and use it in wallet and coinselection 2018-12-12 14:22:12 -08:00
coinselection.h amount: Move CAmount CENT to unit test header 2018-09-17 14:34:56 -04:00
crypter.cpp [wallet] Support creating a blank wallet 2019-02-10 12:24:53 -05:00
crypter.h [tools] Add wallet inspection and modification tool 2019-01-30 16:26:52 -05:00
db.cpp Remove dead code for walletFile check 2019-04-30 00:43:50 +03:00
db.h wallet: Improve log output for errors during load 2019-03-14 18:49:19 -07:00
feebumper.cpp Merge #15778: [wallet] Move maxtxfee from node to wallet 2019-04-27 09:28:54 -04:00
feebumper.h generalize bumpfee to add inputs when needed 2019-04-11 07:21:49 -04:00
fees.cpp [wallet] Move maxTxFee to wallet 2019-04-18 11:34:42 -04:00
fees.h Remove uses of fee globals in wallet code 2019-02-22 15:43:02 -04:00
init.cpp [wallet] Move maxTxFee to wallet 2019-04-18 11:34:42 -04:00
load.cpp [build] Move wallet load functions to wallet/load unit 2019-04-09 17:53:08 -04:00
load.h [build] Move wallet load functions to wallet/load unit 2019-04-09 17:53:08 -04:00
psbtwallet.cpp Remove unused TransactionError constants 2019-02-14 10:32:02 -05:00
psbtwallet.h Remove unused TransactionError constants 2019-02-14 10:32:02 -05:00
rpcdump.cpp Take non-importing keys into account for spendability warning in descriptor import 2019-04-06 09:14:56 -07:00
rpcwallet.cpp Merge #15730: rpc: Show scanning details in getwalletinfo 2019-05-06 13:38:12 +02:00
rpcwallet.h rpcwallet: Make helper methods const on CWallet 2019-05-02 10:09:48 -04:00
wallet.cpp Merge #15948: refactor: rename chainActive 2019-05-07 11:51:30 -04:00
wallet.h Merge #15730: rpc: Show scanning details in getwalletinfo 2019-05-06 13:38:12 +02:00
walletdb.cpp [build] Move CheckTransaction from lib_server to lib_consensus 2019-04-09 17:53:08 -04:00
walletdb.h Store key origin info in key metadata 2019-02-14 17:58:25 -05:00
wallettool.cpp bitcoin-wallet tool: Drop MakeChain calls 2019-04-10 09:51:37 -04:00
wallettool.h [tools] Add wallet inspection and modification tool 2019-01-30 16:26:52 -05:00
walletutil.cpp wallet: Avoid logging no_such_file_or_directory error 2019-04-29 00:07:55 +01:00
walletutil.h wallet: Add WalletLocation utility class 2018-10-25 11:53:17 +01:00