mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-02-06 10:18:44 -05:00
8bb40d5f56
fa13e1b0c5build: Add option --enable-danger-fuzz-link-all (MarcoFalke)44444ba759fuzz: Link all targets once (MarcoFalke) Pull request description: Currently the linker is invoked more than 150 times when compiling with `--enable-fuzz`. This is problematic for several reasons: * It wastes disk space north of 20 GB, as all libraries and sanitizers are linked more than 150 times * It wastes CPU time, as the link step can practically not be cached (similar to ccache for object files) * It makes it a blocker to compile the fuzz tests by default for non-fuzz builds #19388, for the aforementioned reasons * The build file is several thousand lines of code, without doing anything meaningful except listing each fuzz target in a highly verbose manner * It makes writing new fuzz tests unnecessarily hard, as build system knowledge is required; Compare that to boost unit tests, which can be added by simply editing an existing cpp file * It encourages fuzz tests that re-use the `buffer` or assume the `buffer` to be concatenations of seeds, which increases complexity of seeds and complexity for the fuzz engine to explore; Thus reducing the effectiveness of the affected fuzz targets Fixes #20088 ACKs for top commit: practicalswift: Tested ACKfa13e1b0c5sipa: ACKfa13e1b0c5. Reviewed the code changes, and tested the 3 different test_runner.py modes (run once, merge, generate). I also tested building with the new --enable-danger-fuzz-link-all Tree-SHA512: 962ab33269ebd51810924c51266ecc62edd6ddf2fcd9a8c359ed906766f58c3f73c223f8d3cc49f2c60f0053f65e8bdd86ce9c19e673f8c2b3cd676e913f2642
89 lines
2.9 KiB
C++
89 lines
2.9 KiB
C++
// Copyright (c) 2020 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#include <banman.h>
|
|
#include <fs.h>
|
|
#include <netaddress.h>
|
|
#include <test/fuzz/FuzzedDataProvider.h>
|
|
#include <test/fuzz/fuzz.h>
|
|
#include <test/fuzz/util.h>
|
|
#include <util/system.h>
|
|
|
|
#include <cstdint>
|
|
#include <limits>
|
|
#include <string>
|
|
#include <vector>
|
|
|
|
namespace {
|
|
int64_t ConsumeBanTimeOffset(FuzzedDataProvider& fuzzed_data_provider) noexcept
|
|
{
|
|
// Avoid signed integer overflow by capping to int32_t max:
|
|
// banman.cpp:137:73: runtime error: signed integer overflow: 1591700817 + 9223372036854775807 cannot be represented in type 'long'
|
|
return fuzzed_data_provider.ConsumeIntegralInRange<int64_t>(std::numeric_limits<int64_t>::min(), std::numeric_limits<int32_t>::max());
|
|
}
|
|
} // namespace
|
|
|
|
void initialize_banman()
|
|
{
|
|
InitializeFuzzingContext();
|
|
}
|
|
|
|
FUZZ_TARGET_INIT(banman, initialize_banman)
|
|
{
|
|
FuzzedDataProvider fuzzed_data_provider{buffer.data(), buffer.size()};
|
|
SetMockTime(ConsumeTime(fuzzed_data_provider));
|
|
const fs::path banlist_file = GetDataDir() / "fuzzed_banlist.dat";
|
|
fs::remove(banlist_file);
|
|
{
|
|
BanMan ban_man{banlist_file, nullptr, ConsumeBanTimeOffset(fuzzed_data_provider)};
|
|
while (fuzzed_data_provider.ConsumeBool()) {
|
|
switch (fuzzed_data_provider.ConsumeIntegralInRange<int>(0, 11)) {
|
|
case 0: {
|
|
ban_man.Ban(ConsumeNetAddr(fuzzed_data_provider),
|
|
ConsumeBanTimeOffset(fuzzed_data_provider), fuzzed_data_provider.ConsumeBool());
|
|
break;
|
|
}
|
|
case 1: {
|
|
ban_man.Ban(ConsumeSubNet(fuzzed_data_provider),
|
|
ConsumeBanTimeOffset(fuzzed_data_provider), fuzzed_data_provider.ConsumeBool());
|
|
break;
|
|
}
|
|
case 2: {
|
|
ban_man.ClearBanned();
|
|
break;
|
|
}
|
|
case 4: {
|
|
ban_man.IsBanned(ConsumeNetAddr(fuzzed_data_provider));
|
|
break;
|
|
}
|
|
case 5: {
|
|
ban_man.IsBanned(ConsumeSubNet(fuzzed_data_provider));
|
|
break;
|
|
}
|
|
case 6: {
|
|
ban_man.Unban(ConsumeNetAddr(fuzzed_data_provider));
|
|
break;
|
|
}
|
|
case 7: {
|
|
ban_man.Unban(ConsumeSubNet(fuzzed_data_provider));
|
|
break;
|
|
}
|
|
case 8: {
|
|
banmap_t banmap;
|
|
ban_man.GetBanned(banmap);
|
|
break;
|
|
}
|
|
case 9: {
|
|
ban_man.DumpBanlist();
|
|
break;
|
|
}
|
|
case 11: {
|
|
ban_man.Discourage(ConsumeNetAddr(fuzzed_data_provider));
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
fs::remove(banlist_file);
|
|
}
|