foster/bitcoin-bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-06 10:18:44 -05:00
Code Issues Activity
bitcoin-bitcoin-core/src/script
History
Samuel Dobson d6492d4ed0
Merge bitcoin/bitcoin#22650: Remove -deprecatedrpc=addresses flag and corresponding code/logic 
43cd6b8af9 doc: add release notes for removal of the -deprecatedrpc=addresses flag (Michael Dietz)
2b1fdc2c6c refactor: minor styling, prefer snake case and same line if (Michael Dietz)
d64deac7b8 refactor: share logic between ScriptPubKeyToUniv and ScriptToUniv (Michael Dietz)
8721638daa rpc: remove deprecated addresses and reqSigs from rpc outputs (Michael Dietz)

Pull request description:

  Resolves #21797 now that we've branched-off to v23 ("addresses" and "reqSigs" deprecated) "ExtractDestinations" should be removed.

   `-deprecatedrpc=addresses` was initially added in this PR #20286 (which resolved the original issue #20102).

  Some chunks of code and logic are no longer used/necessary with the removal of this, and therefore some minor refactoring is done in this PR as well (separated commits)

ACKs for top commit:
  MarcoFalke:
    re-ACK 43cd6b8af9 🐉
  meshcollider:
    Code review ACK 43cd6b8af9
  jonatack:
    ACK 43cd6b8af9 per `git range-diff a9d0cec 92dc5e9 43cd6b8`, also rebased to latest master, debug built + quick re-review of each commit to bring back context, and ran tests locally at the final commit

Tree-SHA512: fba83495e396d3c06f0dcf49292f14f4aa6b68fa758f0503941fade1a6e7271cda8378e2734af1faea550d1b43c85a36c52ebcc9dec0732936f9233b4b97901c
2021-09-29 10:41:30 +13:00
..
bitcoinconsensus.cpp Make all SignatureChecker explicit about missing data 2021-03-15 17:29:39 -07:00
bitcoinconsensus.h build: test for __declspec(dllexport) in configure 2021-02-12 09:04:16 +08:00
descriptor.cpp Consolidate XOnlyPubKey lookup hack 2021-08-23 21:38:34 -04:00
descriptor.h Pass in DescriptorCache to ToNormalizedString 2021-06-24 14:08:45 -04:00
interpreter.cpp Avoid temporary vectors/uint256s in VerifyTaprootCommitment 2021-08-20 14:30:59 -04:00
interpreter.h Improve comments in taproot signing logic 2021-08-20 14:29:23 -04:00
keyorigin.h scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
script.cpp scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
script.h Add LIFETIMEBOUND to CScript where needed 2021-09-03 13:42:03 +02:00
script_error.cpp Implement Tapscript script validation rules (BIP 342) 2020-10-12 17:18:24 -07:00
script_error.h scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
sigcache.cpp scripted-diff: Rename overloaded int GetArg to GetIntArg 2021-09-27 06:57:20 -04:00
sigcache.h Make all SignatureChecker explicit about missing data 2021-03-15 17:29:39 -07:00
sign.cpp Consolidate XOnlyPubKey lookup hack 2021-08-23 21:38:34 -04:00
sign.h Remove default nHashTypeIn arguments to MutableTransactionSignatureCreator 2021-08-20 14:29:23 -04:00
signingprovider.cpp Add TaprootSpendData data structure, equivalent to script map for P2[W]SH 2021-06-12 12:25:28 -07:00
signingprovider.h Consolidate XOnlyPubKey lookup hack 2021-08-23 21:38:34 -04:00
standard.cpp rpc: remove deprecated addresses and reqSigs from rpc outputs 2021-09-24 14:22:49 -05:00
standard.h rpc: remove deprecated addresses and reqSigs from rpc outputs 2021-09-24 14:22:49 -05:00