0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-08 10:31:50 -05:00
bitcoin-bitcoin-core/depends/packages
Wladimir J. van der Laan fa2a5b8f3a
Merge #20421: build: miniupnpc 2.2.2
180dc3c886 build: miniupnpc 2.2.2 (fanquake)

Pull request description:

  Creating the dll subdir is no-longer required.
  We can drop our wingen patch.

  One issue that came up in [#19867](https://github.com/bitcoin/bitcoin/pull/19867#discussion_r483516359):
  > unrelated to this change but: why are we inserting the architecture in here, seems like something not necessary to reveal

  > My assumption is that it was being inserted to make depends more deterministic. However I think we can improve this, as there's no reason to reveal more of the version information either. Could leave the version as is /2.0 and either drop the architecture, or insert something else?

  I've dropped our `sed` and added a patch that just removes the OS string and miniupnpc version from the User-Agent. i.e:
  ```bash
  # master
  strings depends/x86_64-apple-darwin19.6.0/lib/libminiupnpc.a | rg -i User-Agent
  User-Agent: x86_64-apple-darwin19.6.0, UPnP/1.1, MiniUPnPc/2.0.20180203
  User-Agent: x86_64-apple-darwin19.6.0, UPnP/1.1, MiniUPnPc/2.0.20180203

  # this PR
  strings depends/x86_64-apple-darwin19.6.0/lib/libminiupnpc.a | rg -i User-Agent
  User-Agent: UPnP/1.1
  User-Agent: UPnP/1.1
  ```

  Note that built unmodified (22c1386351), the User-Agent would be:
  ```bash
  strings libminiupnpc.dylib | rg User-Agent
  User-Agent: Darwin/19.6.0, UPnP/1.1, MiniUPnPc/2.2.0
  User-Agent: Darwin/19.6.0, UPnP/1.1, MiniUPnPc/2.2.0
  ```

ACKs for top commit:
  laanwj:
    Code review ACK 180dc3c886
  hebasto:
    ACK 180dc3c886.

Tree-SHA512: b0b6e623dbc5499e28faedf992d84278d6a11887a45a3806957b9e08886c5e56044cdfa2e7d7ec81cb1dd55f89be99834367905315d6bc611ba530e91d889ad1
2021-03-23 21:06:41 +01:00
..
bdb.mk Android : Ensure pic build for bdb 2020-12-04 01:57:54 +02:00
boost.mk build: don't build or use Boost Thread 2021-02-02 12:38:22 +08:00
capnp.mk depends: add MULTIPROCESS depends option 2020-05-12 09:47:06 -04:00
expat.mk build: pass --enable-option-checking to applicable packages 2019-10-11 13:31:50 -04:00
fontconfig.mk build: use patch rather than sed in fontconfig package 2020-08-25 14:37:35 +08:00
freetype.mk build: pass --enable-option-checking to applicable packages 2019-10-11 13:31:50 -04:00
libevent.mk build: pass _WIN32_WINNT=0x0601 when building libevent for Windows 2020-06-30 13:25:09 +08:00
libmultiprocess.mk depends: add MULTIPROCESS depends option 2020-05-12 09:47:06 -04:00
libnatpmp.mk build: compile libnatpmp with -DNATPMP_STATICLIB on Windows 2021-03-04 12:34:46 +08:00
libXau.mk build: pass --enable-option-checking to applicable packages 2019-10-11 13:31:50 -04:00
libxcb.mk build: qt 5.12.10 2021-03-10 12:57:22 +08:00
libxkbcommon.mk build: Cleanup libxkbcommon_postprocess_cmds 2021-03-12 14:51:10 +02:00
miniupnpc.mk build: miniupnpc 2.2.2 2021-03-23 08:39:16 +08:00
native_b2.mk depends: boost: Split into non-/native packages 2020-11-23 15:50:54 -05:00
native_capnp.mk depends: add MULTIPROCESS depends option 2020-05-12 09:47:06 -04:00
native_cctools.mk Revert "Add patch to make codesign_allocate compatible with Apple's" 2021-01-04 16:35:18 -08:00
native_ds_store.mk depends: native_ds_store 1.3.0 2020-11-11 08:01:02 +08:00
native_libdmg-hfsplus.mk depends: Use $($(package)_cmake) instead of cmake 2020-08-07 20:52:22 -04:00
native_libmultiprocess.mk depends: add MULTIPROCESS depends option 2020-05-12 09:47:06 -04:00
native_mac_alias.mk build: mac_alias 2.1.1 2020-11-30 15:39:09 +08:00
packages.mk build: revert to using Qts internal zlib 2021-03-10 12:57:26 +08:00
qrencode.mk Merge #16110: depends: Add Android NDK support 2019-11-04 13:32:19 +01:00
qt.mk build: Do not build unused CoreWLAN stuff in depends for macOS 2021-03-21 23:45:26 +02:00
sqlite.mk Add sqlite to travis and depends 2020-10-14 11:18:13 -04:00
xcb_proto.mk depends: don't configure xcb_proto 2019-12-08 17:55:11 -05:00
xproto.mk build: pass --enable-option-checking to applicable packages 2019-10-11 13:31:50 -04:00
zeromq.mk depends: build zeromq with -std=c++17 2020-11-24 10:18:06 +08:00