mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-02-05 10:17:30 -05:00
![MarcoFalke](/assets/img/avatar_default.png)
fa551b3bdd
Remove GetAdjustedTime from init.cpp (MarcoFalke)fa815f8473
Replace addrman.h include with forward decl in net.h (MarcoFalke) Pull request description: It seems confusing to call `GetAdjustedTime` there, because no offset could have been retrieved from the network at this point. Even if connman was started, `timedata` needs at least 5 peer connections to calculate an offset. Fix the confusion by replacing `GetAdjustedTime` with `GetTime`, which does not change behavior. Also: * Replace magic number with `MAX_FUTURE_BLOCK_TIME` to clarify the context * Add test, which passes both on current master and this pull request * An unrelated refactoring commit, happy to drop ACKs for top commit: dongcarl: Code Review ACKfa551b3bdd
, noticed the exact same thing here:e073634c37
mzumsande: Code Review ACKfa551b3bdd
jnewbery: Code review ACKfa551b3bdd
shaavan: ACKfa551b3bdd
theStack: Code-review ACKfa551b3bdd
Tree-SHA512: 15807a0e943e3e8d8c5250c8f6d7b56afb26002b1e290bf93636a2c747f27e78f01f1de04ce1a83d6339e27284c69c43e077a8467545c4078746f4c1ecb1164d
129 lines
5.1 KiB
C++
129 lines
5.1 KiB
C++
// Copyright (c) 2020-2021 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#include <addrman.h>
|
|
#include <chainparams.h>
|
|
#include <chainparamsbase.h>
|
|
#include <net.h>
|
|
#include <netaddress.h>
|
|
#include <protocol.h>
|
|
#include <test/fuzz/FuzzedDataProvider.h>
|
|
#include <test/fuzz/fuzz.h>
|
|
#include <test/fuzz/util.h>
|
|
#include <test/util/setup_common.h>
|
|
#include <util/translation.h>
|
|
|
|
#include <cstdint>
|
|
#include <vector>
|
|
|
|
void initialize_connman()
|
|
{
|
|
static const auto testing_setup = MakeNoLogFileContext<>();
|
|
}
|
|
|
|
FUZZ_TARGET_INIT(connman, initialize_connman)
|
|
{
|
|
FuzzedDataProvider fuzzed_data_provider{buffer.data(), buffer.size()};
|
|
SetMockTime(ConsumeTime(fuzzed_data_provider));
|
|
AddrMan addrman(/*asmap=*/std::vector<bool>(), /*deterministic=*/false, /*consistency_check_ratio=*/0);
|
|
CConnman connman{fuzzed_data_provider.ConsumeIntegral<uint64_t>(), fuzzed_data_provider.ConsumeIntegral<uint64_t>(), addrman, fuzzed_data_provider.ConsumeBool()};
|
|
CNetAddr random_netaddr;
|
|
CNode random_node = ConsumeNode(fuzzed_data_provider);
|
|
CSubNet random_subnet;
|
|
std::string random_string;
|
|
LIMITED_WHILE(fuzzed_data_provider.ConsumeBool(), 10000) {
|
|
CallOneOf(
|
|
fuzzed_data_provider,
|
|
[&] {
|
|
random_netaddr = ConsumeNetAddr(fuzzed_data_provider);
|
|
},
|
|
[&] {
|
|
random_subnet = ConsumeSubNet(fuzzed_data_provider);
|
|
},
|
|
[&] {
|
|
random_string = fuzzed_data_provider.ConsumeRandomLengthString(64);
|
|
},
|
|
[&] {
|
|
connman.AddNode(random_string);
|
|
},
|
|
[&] {
|
|
connman.CheckIncomingNonce(fuzzed_data_provider.ConsumeIntegral<uint64_t>());
|
|
},
|
|
[&] {
|
|
connman.DisconnectNode(fuzzed_data_provider.ConsumeIntegral<NodeId>());
|
|
},
|
|
[&] {
|
|
connman.DisconnectNode(random_netaddr);
|
|
},
|
|
[&] {
|
|
connman.DisconnectNode(random_string);
|
|
},
|
|
[&] {
|
|
connman.DisconnectNode(random_subnet);
|
|
},
|
|
[&] {
|
|
connman.ForEachNode([](auto) {});
|
|
},
|
|
[&] {
|
|
(void)connman.ForNode(fuzzed_data_provider.ConsumeIntegral<NodeId>(), [&](auto) { return fuzzed_data_provider.ConsumeBool(); });
|
|
},
|
|
[&] {
|
|
(void)connman.GetAddresses(
|
|
/*max_addresses=*/fuzzed_data_provider.ConsumeIntegral<size_t>(),
|
|
/*max_pct=*/fuzzed_data_provider.ConsumeIntegral<size_t>(),
|
|
/*network=*/std::nullopt);
|
|
},
|
|
[&] {
|
|
(void)connman.GetAddresses(
|
|
/*requestor=*/random_node,
|
|
/*max_addresses=*/fuzzed_data_provider.ConsumeIntegral<size_t>(),
|
|
/*max_pct=*/fuzzed_data_provider.ConsumeIntegral<size_t>());
|
|
},
|
|
[&] {
|
|
(void)connman.GetDeterministicRandomizer(fuzzed_data_provider.ConsumeIntegral<uint64_t>());
|
|
},
|
|
[&] {
|
|
(void)connman.GetNodeCount(fuzzed_data_provider.PickValueInArray({ConnectionDirection::None, ConnectionDirection::In, ConnectionDirection::Out, ConnectionDirection::Both}));
|
|
},
|
|
[&] {
|
|
(void)connman.OutboundTargetReached(fuzzed_data_provider.ConsumeBool());
|
|
},
|
|
[&] {
|
|
// Limit now to int32_t to avoid signed integer overflow
|
|
(void)connman.PoissonNextSendInbound(
|
|
std::chrono::microseconds{fuzzed_data_provider.ConsumeIntegral<int32_t>()},
|
|
std::chrono::seconds{fuzzed_data_provider.ConsumeIntegral<int>()});
|
|
},
|
|
[&] {
|
|
CSerializedNetMsg serialized_net_msg;
|
|
serialized_net_msg.m_type = fuzzed_data_provider.ConsumeRandomLengthString(CMessageHeader::COMMAND_SIZE);
|
|
serialized_net_msg.data = ConsumeRandomLengthByteVector(fuzzed_data_provider);
|
|
connman.PushMessage(&random_node, std::move(serialized_net_msg));
|
|
},
|
|
[&] {
|
|
connman.RemoveAddedNode(random_string);
|
|
},
|
|
[&] {
|
|
connman.SetNetworkActive(fuzzed_data_provider.ConsumeBool());
|
|
},
|
|
[&] {
|
|
connman.SetTryNewOutboundPeer(fuzzed_data_provider.ConsumeBool());
|
|
});
|
|
}
|
|
(void)connman.GetAddedNodeInfo();
|
|
(void)connman.GetExtraFullOutboundCount();
|
|
(void)connman.GetLocalServices();
|
|
(void)connman.GetMaxOutboundTarget();
|
|
(void)connman.GetMaxOutboundTimeframe();
|
|
(void)connman.GetMaxOutboundTimeLeftInCycle();
|
|
(void)connman.GetNetworkActive();
|
|
std::vector<CNodeStats> stats;
|
|
connman.GetNodeStats(stats);
|
|
(void)connman.GetOutboundTargetBytesLeft();
|
|
(void)connman.GetReceiveFloodSize();
|
|
(void)connman.GetTotalBytesRecv();
|
|
(void)connman.GetTotalBytesSent();
|
|
(void)connman.GetTryNewOutboundPeer();
|
|
(void)connman.GetUseAddrmanOutgoing();
|
|
}
|