MarcoFalke ca424e242a Merge bitcoin/bitcoin#22200: zmq: use std::string in zmqError() ... 3f05a9e681 zmq: use msg: prefix over errno= in zmqError (fanquake) 9a7cb57bbc zmq: use std::string in zmqError() (fanquake) Pull request description: This is two minor changes. The first is to change `zmqError` to take a `const std::string&` instead of a `const char*`. The second is to change the second portion of `zmqError` to print `msg: message` rather than `errno=message`, given that `zmq_strerror` returns a message. To me, this seems more readable / useful than output like: `Error: Unable to initialize context errno=No such file or directory`. ACKs for top commit: practicalswift: cr ACK 3f05a9e681 instagibbs: utACK 3f05a9e681 theStack: Code-Review ACK 3f05a9e681 Tree-SHA512: 197cf381e8b3ced271d0e575e0c6d8e5e9ed93c4b284338b17873c5232eaabe64d6c4b66e1aeb5e76befc89e316abae2b28b7fd760f178481d7b9f4e3f85da67		2021-06-09 19:32:34 +02:00
..
bench	Merge bitcoin/bitcoin#22008: wallet: Cleanup and refactor CreateTransactionInternal	2021-06-09 22:37:34 +12:00
compat	Remove support for double serialization	2021-05-24 16:15:05 -07:00
config
consensus	Mark CheckTxInputs [[nodiscard]] (out-param txfee only set if call is successful). Avoid UUM in fuzzing harness coins_view.	2021-05-25 21:09:05 +00:00
crc32c
crypto	crypto: Make MuHash Remove method efficient	2021-04-19 20:28:46 +02:00
index	Merge bitcoin/bitcoin#21767: [Bundle 6/n] Prune g_chainman usage in auxiliary modules	2021-06-01 13:34:18 +02:00
init	scripted-diff: Replace GetDataDir() calls with gArgs.GetDataDirNet() calls	2021-05-24 10:29:58 +02:00
interfaces	Merge bitcoin-core/gui#4: UI external signer support (e.g. hardware wallet)	2021-06-09 18:59:59 +12:00
ipc	multiprocess: Add echoipc RPC method and test	2021-04-23 03:02:50 -05:00
leveldb
logging
node	node: add externalSigners to interface	2021-05-27 14:01:54 +02:00
policy	Merge bitcoin/bitcoin#20833: rpc/validation: enable packages through testmempoolaccept	2021-05-27 22:40:24 +02:00
primitives
qt	Merge bitcoin-core/gui#4: UI external signer support (e.g. hardware wallet)	2021-06-09 18:59:59 +12:00
rpc	p2p, rpc, fuzz: various tiny follow-ups	2021-06-06 15:49:22 +02:00
script	Add tr() descriptor (derivation only, no signing)	2021-05-24 12:14:16 -07:00
secp256k1	Update libsecp256k1 subtree to latest upstream master	2021-04-23 11:35:15 -07:00
support
test	fuzz: Increase branch coverage of the float fuzz target	2021-06-07 13:41:14 +02:00
univalue
util	Merge bitcoin/bitcoin#22137: util: Properly handle -noincludeconf on command line (take 2)	2021-06-07 13:20:57 +08:00
wallet	Merge bitcoin/bitcoin#22173: wallet: Do not load external signers wallets when unsupported	2021-06-09 23:12:40 +12:00
zmq	zmq: use msg: prefix over errno= in zmqError	2021-06-09 19:25:13 +08:00
.clang-format
addrdb.cpp	scripted-diff: Replace GetDataDir() calls with gArgs.GetDataDirNet() calls	2021-05-24 10:29:58 +02:00
addrdb.h
addrman.cpp	refactor: Switch serialize to uint8_t (1/n)	2021-05-31 14:56:17 +02:00
addrman.h	move-only: Group and re-order CAddrMan members by access type	2021-05-24 19:26:49 +03:00
amount.h
arith_uint256.cpp
arith_uint256.h
attributes.h
banman.cpp	scripted-diff: Replace three dots with ellipsis in the UI strings	2021-05-02 22:17:16 +03:00
banman.h
base58.cpp
base58.h
bech32.cpp
bech32.h
bitcoin-cli-res.rc
bitcoin-cli.cpp	scripted-diff: rename GetSystemTimeInSeconds to GetTimeSeconds	2021-05-31 15:11:18 +08:00
bitcoin-tx-res.rc
bitcoin-tx.cpp
bitcoin-util-res.rc
bitcoin-util.cpp
bitcoin-wallet-res.rc
bitcoin-wallet.cpp
bitcoind-res.rc
bitcoind.cpp	multiprocess: Add bitcoin-node process spawning support	2021-04-23 03:02:50 -05:00
blockencodings.cpp
blockencodings.h
blockfilter.cpp
blockfilter.h
bloom.cpp
bloom.h
chain.cpp
chain.h	doc: Various validation doc fixups	2021-06-03 13:53:31 +02:00
chainparams.cpp	CRegTestParams: Use args instead of gArgs.	2021-06-02 22:36:48 +02:00
chainparams.h	refactor: Use type-safe assumeutxo hash	2021-05-11 10:40:40 +02:00
chainparamsbase.cpp	versionbits: Add support for delayed activation	2021-04-12 11:14:49 +10:00
chainparamsbase.h
chainparamsseeds.h	contrib: remove torv2 seed nodes	2021-06-03 14:04:06 +02:00
checkqueue.h
clientversion.cpp
clientversion.h
coins.cpp
coins.h	refactor: Remove unused code	2021-05-11 10:39:44 +02:00
compat.h
compressor.cpp	refactor: Use CPubKey vector constructor where possible	2021-05-04 06:53:32 +02:00
compressor.h
core_io.h
core_memusage.h
core_read.cpp
core_write.cpp
cuckoocache.h
dbwrapper.cpp	refactor: Use only one temporary buffer in CreateObfuscateKey	2021-05-04 06:53:37 +02:00
dbwrapper.h
dummywallet.cpp	tests: Skip SQLite fsyncs while testing	2021-04-12 19:29:03 -04:00
external_signer.cpp	external_signer: remove ExternalSignerException	2021-04-13 20:09:34 +08:00
external_signer.h	external_signer: remove ExternalSignerException	2021-04-13 20:09:34 +08:00
flatfile.cpp
flatfile.h
fs.cpp
fs.h
hash.cpp
hash.h	Squashed 'src/secp256k1/' changes from 3967d96bf1..efad3506a8	2021-04-23 11:35:15 -07:00
httprpc.cpp
httprpc.h
httpserver.cpp	refactor: Add TSA annotations to the WorkQueue class members	2021-05-09 13:48:07 +03:00
httpserver.h
i2p.cpp
i2p.h
indirectmap.h
init.cpp	Merge bitcoin/bitcoin#21767: [Bundle 6/n] Prune g_chainman usage in auxiliary modules	2021-06-01 13:34:18 +02:00
init.h
key.cpp	refactor: Avoid &foo[0] on C-Style arrays	2021-05-04 06:55:30 +02:00
key.h	refactor: Avoid &foo[0] on C-Style arrays	2021-05-04 06:55:30 +02:00
key_io.cpp	Separate WitnessV1Taproot variant in CTxDestination	2021-05-24 12:14:16 -07:00
key_io.h
logging.cpp	multiprocess: Add Ipc interface implementation	2021-04-23 03:02:50 -05:00
logging.h	multiprocess: Add Ipc interface implementation	2021-04-23 03:02:50 -05:00
Makefile.am	Merge bitcoin/bitcoin#21207: MOVEONLY: CWallet transaction code out of wallet.cpp/.h	2021-05-30 22:00:40 +12:00
Makefile.bench.include
Makefile.crc32c.include
Makefile.leveldb.include
Makefile.qt.include	Merge bitcoin/bitcoin#21654: build, qt: Make Qt rcc output always deterministic	2021-06-03 21:25:30 +08:00
Makefile.qt_locale.include
Makefile.qttest.include
Makefile.test.include	Merge bitcoin/bitcoin#22029: [fuzz] Improve transport deserialization fuzz test coverage	2021-05-27 15:02:57 +02:00
Makefile.test_fuzz.include
Makefile.test_util.include
mapport.cpp	refactor: Use appropriate thread constructor	2021-04-29 18:39:01 +03:00
mapport.h
memusage.h
merkleblock.cpp
merkleblock.h
miner.cpp	miner: Pass in chainman to RegenerateCommitments	2021-05-27 13:50:11 -04:00
miner.h	miner: Pass in chainman to RegenerateCommitments	2021-05-27 13:50:11 -04:00
net.cpp	Merge bitcoin/bitcoin#21969: refactor: Switch serialize to uint8_t (Bundle 1/2)	2021-06-01 09:01:29 +02:00
net.h	Merge bitcoin/bitcoin#21186: net/net processing: Move addr data into net_processing	2021-05-24 20:28:31 +08:00
net_permissions.cpp	p2p: pass strings to NetPermissions::TryParse functions by const ref	2021-05-19 19:41:05 +02:00
net_permissions.h	p2p: pass strings to NetPermissions::TryParse functions by const ref	2021-05-19 19:41:05 +02:00
net_processing.cpp	net: cleanup newly added PeerManagerImpl::ProcessNewBlock	2021-05-31 14:36:46 +08:00
net_processing.h	[net processing] Add internal _RelayTransactions()	2021-05-04 09:31:03 +01:00
net_types.h
netaddress.cpp	p2p, rpc, fuzz: various tiny follow-ups	2021-06-06 15:49:22 +02:00
netaddress.h	p2p: remove torv2 in SetIP() and ADDR_TORV2_SIZE constant	2021-06-03 13:36:46 +02:00
netbase.cpp
netbase.h
netmessagemaker.h
noui.cpp
noui.h
outputtype.cpp
outputtype.h
pow.cpp
pow.h
prevector.h
protocol.cpp	refactor: Replace memset calls with array initialization	2021-05-13 12:42:21 +01:00
protocol.h	refactor: Replace memset calls with array initialization	2021-05-13 12:42:21 +01:00
psbt.cpp
psbt.h
pubkey.cpp	Add TaprootBuilder class	2021-05-24 12:14:16 -07:00
pubkey.h	Add tr() descriptor (derivation only, no signing)	2021-05-24 12:14:16 -07:00
random.cpp	refactor: Replace &foo[0] with foo.data()	2021-05-04 06:55:31 +02:00
random.h
randomenv.cpp
randomenv.h
rest.cpp	rest: Add GetChainman function and use it	2021-05-27 13:49:09 -04:00
reverse_iterator.h
scheduler.cpp	test: Fix off-by-one in mockscheduler test RPC	2021-05-14 12:49:16 +02:00
scheduler.h
serialize.h	refactor: Switch serialize to uint8_t (1/n)	2021-05-31 14:56:17 +02:00
shutdown.cpp
shutdown.h
signet.cpp	Merge #21330: Deal with missing data in signature hashes more consistently	2021-04-13 10:24:31 +08:00
signet.h
span.h
streams.h	streams: Accept URef obj for VectorReader unserialize	2021-05-05 20:19:03 +02:00
sync.cpp
sync.h
threadinterrupt.cpp
threadinterrupt.h
threadsafety.h
timedata.cpp
timedata.h
tinyformat.h
torcontrol.cpp	scripted-diff: Replace GetDataDir() calls with gArgs.GetDataDirNet() calls	2021-05-24 10:29:58 +02:00
torcontrol.h
txdb.cpp	refactor: Switch serialize to uint8_t (1/n)	2021-05-31 14:56:17 +02:00
txdb.h
txmempool.cpp	[coins/mempool] extend CCoinsViewMemPool to track temporary coins	2021-05-20 21:34:31 +01:00
txmempool.h	Merge bitcoin/bitcoin#20833: rpc/validation: enable packages through testmempoolaccept	2021-05-27 22:40:24 +02:00
txorphanage.cpp
txorphanage.h
txrequest.cpp
txrequest.h
uint256.cpp
uint256.h	Make XOnlyPubKey act like byte container	2021-05-24 12:14:16 -07:00
undo.h
validation.cpp	Merge bitcoin/bitcoin#21946: Document and test lack of inherited signaling in RBF policy	2021-06-08 17:00:28 +02:00
validation.h	doc: Various validation doc fixups	2021-06-03 13:53:31 +02:00
validationinterface.cpp
validationinterface.h
version.h
versionbits.cpp	versionbits: simplify state transitions	2021-04-12 11:14:49 +10:00
versionbits.h	versionbits: Add support for delayed activation	2021-04-12 11:14:49 +10:00
versionbitsinfo.cpp
versionbitsinfo.h
walletinitinterface.h
warnings.cpp
warnings.h