Wladimir J. van der Laan 312d27b11c Merge #17477: Remove the mempool's NotifyEntryAdded and NotifyEntryRemoved signals ... e57980b473 [mempool] Remove NotifyEntryAdded and NotifyEntryRemoved callbacks (John Newbery) 2dd561f361 [validation] Remove pool member from ConnectTrace (John Newbery) 969b65f3f5 [validation] Remove NotifyEntryRemoved callback from ConnectTrace (John Newbery) 5613f9842b [validation] Remove conflictedTxs from PerBlockConnectTrace (John Newbery) cdb893443c [validation interface] Remove vtxConflicted from BlockConnected (John Newbery) 1168394d75 [wallet] Notify conflicted transactions in TransactionRemovedFromMempool (John Newbery) Pull request description: These boost signals were added in #9371, before we had a `TransactionRemovedFromMempool` method in the validation interface. The `NotifyEntryAdded` callback was used by validation to build a vector of conflicted transactions when connecting a block, which the wallet was notified of in the `BlockConnected` CValidationInterface callback. Now that we have a `TransactionRemovedFromMempool` callback, we can fire that signal directly from the mempool for conflicted transactions. Note that #9371 was implemented to ensure `-walletnotify` events were fired for these conflicted transaction. We inadvertently stopped sending these notifications in #16624 (Sep 2019 commit 7e89994). We should probably fix that, but in a different PR. ACKs for top commit: jonatack: Re-ACK e57980b ryanofsky: Code review ACK e57980b473, no code changes since previous review, but helpful new code comments have been added and the PR description is now more clear about where the old code came from Tree-SHA512: 3bdbaf1ef2731e788462d4756e69c42a1efdcf168691ce1bbfdaa4b7b55ac3c5b1fd4ab7b90bcdec653703600501b4224d252cfc086aef28f9ce0da3b0563a69		2020-03-19 17:26:51 +01:00
..
base.cpp	Merge #17477: Remove the mempool's NotifyEntryAdded and NotifyEntryRemoved signals	2020-03-19 17:26:51 +01:00
base.h	Merge #17477: Remove the mempool's NotifyEntryAdded and NotifyEntryRemoved signals	2020-03-19 17:26:51 +01:00
blockfilterindex.cpp	Add Travis check for single parameter constructors not marked "explicit"	2019-06-26 16:57:14 +02:00
blockfilterindex.h	index: Access functions for global block filter indexes.	2019-04-06 12:10:55 -07:00
txindex.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
txindex.h	index: Move index DBs into index/ directory.	2018-06-04 19:22:30 -07:00