foster/bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-03-06 14:19:59 -05:00
Code Issues Activity

wallet: Reset BerkeleyDB handle after connection fails

Browse source 
According to the BerkeleyDB docs, the DbEnv handle may not be accessed
after close() has been called. This change ensures that we create a new
handle after close() is called. This avoids a segfault when the first
connection attempt fails and then a second connection attempt tries to
call open() on the already closed DbEnv handle.
This commit is contained in:
Tim Ruffing 2018-05-03 17:45:51 +02:00
parent a024a1841d
commit 264c643809
No known key found for this signature in database
GPG key ID: EACFF772B38B3479
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/wallet/db.cpp
View file

@ -169,6 +169,7 @@ bool BerkeleyEnvironment::Open(bool retry)
S_IRUSR | S_IWUSR); S_IRUSR | S_IWUSR);
if (ret != 0) { if (ret != 0) {
dbenv->close(0); dbenv->close(0);
Reset();
LogPrintf("BerkeleyEnvironment::Open: Error %d opening database environment: %s\n", ret, DbEnv::strerror(ret)); LogPrintf("BerkeleyEnvironment::Open: Error %d opening database environment: %s\n", ret, DbEnv::strerror(ret));
if (retry) { if (retry) {
// try moving the database env out of the way // try moving the database env out of the way