foster/bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-03-05 14:06:27 -05:00
Code Issues Activity

refactor: Move code from ctor into private BanMan::LoadBanlist()

Browse source 
Co-authored-by: Anthony Towns <aj@erisian.com.au>
This commit is contained in:
Hennadii Stepanov 2022-05-20 14:54:33 +02:00
parent 4d0c00dffd
commit 3919059deb
No known key found for this signature in database
GPG key ID: 410108112E7EA81F
2 changed files with 14 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
src/banman.cpp
View file

@ -16,6 +16,19 @@
BanMan::BanMan(fs::path ban_file, CClientUIInterface* client_interface, int64_t default_ban_time) BanMan::BanMan(fs::path ban_file, CClientUIInterface* client_interface, int64_t default_ban_time)
: m_client_interface(client_interface), m_ban_db(std::move(ban_file)), m_default_ban_time(default_ban_time) : m_client_interface(client_interface), m_ban_db(std::move(ban_file)), m_default_ban_time(default_ban_time)
{ {
LoadBanlist();
DumpBanlist();
}
BanMan::~BanMan()
{
DumpBanlist();
}
void BanMan::LoadBanlist()
{
LOCK(m_cs_banned);
if (m_client_interface) m_client_interface->InitMessage(_("Loading banlist…").translated); if (m_client_interface) m_client_interface->InitMessage(_("Loading banlist…").translated);
int64_t n_start = GetTimeMillis(); int64_t n_start = GetTimeMillis();
@ -29,13 +42,6 @@ BanMan::BanMan(fs::path ban_file, CClientUIInterface* client_interface, int64_t
m_banned = {}; m_banned = {};
m_is_dirty = true; m_is_dirty = true;
} }
DumpBanlist();
}
BanMan::~BanMan()
{
DumpBanlist();
} }
void BanMan::DumpBanlist() void BanMan::DumpBanlist()

1
src/banman.h
View file

@ -80,6 +80,7 @@ public:
void DumpBanlist(); void DumpBanlist();
private: private:
void LoadBanlist() EXCLUSIVE_LOCKS_REQUIRED(!m_cs_banned);
bool BannedSetIsDirty(); bool BannedSetIsDirty();
//!set the "dirty" flag for the banlist //!set the "dirty" flag for the banlist
void SetBannedSetDirty(bool dirty = true); void SetBannedSetDirty(bool dirty = true);