foster/bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-03-06 14:19:59 -05:00
Code Issues Activity

Make IsHex use string_view

Browse source
This commit is contained in:
Pieter Wuille 2022-04-04 11:12:04 -04:00 • committed by MacroFake
parent c1d165a8c2
commit 40062997f2
2 changed files with 4 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/util/strencodings.cpp
View file

@ -58,12 +58,10 @@ signed char HexDigit(char c)
return p_util_hexdigit[(unsigned char)c]; return p_util_hexdigit[(unsigned char)c];
} }
bool IsHex(const std::string& str) bool IsHex(std::string_view str)
{ {
for(std::string::const_iterator it(str.begin()); it != str.end(); ++it) for (char c : str) {
{ if (HexDigit(c) < 0) return false;
if (HexDigit(*it) < 0)
return false;
} }
return (str.size() > 0) && (str.size()%2 == 0); return (str.size() > 0) && (str.size()%2 == 0);
} }

2
src/util/strencodings.h
View file

@ -59,7 +59,7 @@ std::vector<unsigned char> ParseHex(std::string_view str);
signed char HexDigit(char c); signed char HexDigit(char c);
/* Returns true if each character in str is a hex character, and has an even /* Returns true if each character in str is a hex character, and has an even
* number of hex digits.*/ * number of hex digits.*/
bool IsHex(const std::string& str); bool IsHex(std::string_view str);
/** /**
* Return true if the string is a hex number, optionally prefixed with "0x" * Return true if the string is a hex number, optionally prefixed with "0x"
*/ */